20

I'm trying to write a simple Resource Manager for the little hobby game I'm writing. One of the tasks that this resource manager needs to do is unloading unused resources. I can think of doing this in two ways:

  • When an object no longer requires a reference to the resource, it must call a method of the Resource Manager to signify it is no longer using it; or

  • When an object no longer requires a reference to the resource, it simply sets it to null. Then when the Resource Manager is asked to unload unused resources, it gets the reference count (via reflection?) of each resource. If the reference count is one (the Resource Manager will have a reference to the resource), unload the resource.

Is there any way to acheive the second solution in C#? Thanks.

  • 2
    What will your resource manager do that the garbace collector doesn't? – CannibalSmith Nov 06 '09 at 09:28
  • 1
    @CannibalSmith - typically, allow multiple bits of code to re-use the resource (essentially, a cache) – Marc Gravell Nov 06 '09 at 09:32
  • Its for loading images, making sure only one image is loaded at a time (no matter how many things ask for it, only one version can be in memory). –  Nov 06 '09 at 10:50

5 Answers5

37

Couple things. First off, objects are not reference counted; reference counting schemes have the circular reference problem, whereby two objects refer to each other but are otherwise inaccessible, and thereby leak. .NET uses a mark-and-sweep approach which does not use ref counts.

Second, though the suggestion to use a weak reference is not terrible, it's also not a slam dunk. You are building a cache for performance reasons. (I assume that your careful, empirical, realistic research into the performance characteristics of your application has convincingly demonstrated that a caching strategy is necessary in order to achieve acceptable performance; if that's not the case, then you are making these decisions prematurely.) Every cache has to have a POLICY about when it releases its resources, otherwise it's a memory leak.

How do you know that the GC policy and your policy are equivalent policies? The GC was not designed with your specific performance needs in mind. That is, it was designed to release resources that really are garbage, not to achieve any particular performance goal you've got in mind. By delegating the decision to the GC, you give up your ability to tune your cache policy to your performance needs.

Eric Lippert
  • 647,829
  • 179
  • 1,238
  • 2,067
17

It sounds to me that you could just use WeakReference from the resource manager. The GC will do the rest. You'll need to do a little casting, but it will be simple, and will work.

class Manager {
    Dictionary<string, WeakReference> refs =
        new Dictionary<string, WeakReference>();
    public object this[string key] {
        get {
            WeakReference wr;
            if (refs.TryGetValue(key, out wr)) {
                if(wr.IsAlive) return wr.Target;
                refs.Remove(key);
            }
            return null;
        }
        set {
            refs[key] = new WeakReference(value);
        }
    }
}
static void Main() {
    Manager mgr = new Manager();
    var obj = new byte[1024];
    mgr["abc"] = obj;

    GC.Collect(GC.MaxGeneration, GCCollectionMode.Forced);
    Console.WriteLine(mgr["abc"] != null); // true (still ref'd by "obj")

    obj = null;
    GC.Collect(GC.MaxGeneration, GCCollectionMode.Forced);
    Console.WriteLine(mgr["abc"] != null); // false (no remaining refs)
}
Marc Gravell
  • 1,026,079
  • 266
  • 2,566
  • 2,900
  • I'd do this :) One thing, though: I could be wrong, but I think you may have to get the proper reference out of the dictionary and check if it's null prior to returning it. If you do "if(wr.IsAlive) return wr.Target", you're never taking a strong ref, so IsAlive may return true, but by the time you return the value, wr.Target may have been collected. There's an alternative code sample here here: http://msdn.microsoft.com/en-us/library/system.weakreference.aspx – Mark Simpson Nov 06 '09 at 10:17
  • 2
    `object` is strong enough to prevent collection; either it will be `null` or strong. The caller would have to cast it to make it a *typed* reference, but that is a different issue... – Marc Gravell Nov 06 '09 at 10:23
  • .NET 4.5 has a generic version of WeakReference, check this out http://www.philosophicalgeek.com/2014/08/14/prefer-weakreferencet-to-weakreference/ – Logerfo Oct 27 '17 at 11:49
  • Isn't whole point of caching to be able to reuse resources even if they are temporarily not required? If cache is cleaned by GC, then does cache do anything except obscuring code? Won't it just pretend that it does something different than GC. – Adas Lesniak Nov 10 '20 at 12:53
  • @AdasLesniak I'm not the enquirer but one use case for this would be to keep the cache under a certain size. Check if the object is currently used - this is done to not cause bugs in your UI and then remove it or leave it be. And yes, basically this is a 'GC' for your own cache. – Steffen Winkler Jan 12 '21 at 08:11
3

We already have a resource manager in .NET, called the Garbage collector. So a very efficient approach is to set the references to null and do nothing.

A more direct answer: No, there is no way to get the references to an object.

You may want to study the WeakReference class or use a Caching system.

H H
  • 263,252
  • 30
  • 330
  • 514
1

Ensure the resource manager uses WeakReferences to your resources. That way, when no one else is referencing the resources, they will be eligible for garbage collection.

Kent Boogaart
  • 175,602
  • 35
  • 392
  • 393
0

As already told by other users, what you are trying to achieve is already made by the GC, and can be fine tuned using a WeakReference.

This imply that in managed environments like .NET, java, and so on, this is a non-problem.

Since the low-level framework architecture isolates you from the memory management, if you still need for that kind of functionality, I strongly suggest you to review your own code architecture, cause it would mean that you are doing some sort of bad-practise in memory management

NinjaCross
  • 784
  • 2
  • 9
  • 20