RoleEnvironment.Stopping/RoleEntryPoint.OnStop() are not called for dying instances when I reduce my role instance count. They are called when the instance is rebooted or the deployment is stopped. What am I doing wrong, or am I just not supposed to need to clean up in this case?
I have a simple worker role (VS2012 update 1, default Cloud project with one worker role, added smarx's Table storage trace listener). All code here; no other dependencies:
using System;
using System.Collections.Generic;
using System.Data.Services.Client;
using System.Diagnostics;
using System.Linq;
using System.Net;
using System.Threading;
using Microsoft.WindowsAzure;
using Microsoft.WindowsAzure.Diagnostics;
using Microsoft.WindowsAzure.ServiceRuntime;
using Microsoft.WindowsAzure.StorageClient;
namespace WorkerRole1
{
public class WorkerRole : RoleEntryPoint
{
bool shouldRun = true;
EventWaitHandle runFinished = new EventWaitHandle(true, EventResetMode.ManualReset);
public override bool OnStart()
{
ServicePointManager.DefaultConnectionLimit = 12;
RoleEnvironment.Stopping += (object sender, RoleEnvironmentStoppingEventArgs e) => {
Trace.WriteLine("WorkerRole1 Stopping called", "Information");
shouldRun = false;
};
return base.OnStart();
}
public override void Run()
{
runFinished.Reset();
try {
Trace.WriteLine("WorkerRole1 entry point called", "Information");
while (shouldRun) {
Thread.Sleep(10000);
Trace.WriteLine("Working", "Information");
}
Trace.WriteLine("Finished", "Information");
} finally {
runFinished.Set();
}
}
public override void OnStop()
{
Trace.WriteLine("OnStop: Waiting for Run() to finish", "Information");
runFinished.WaitOne();
Trace.WriteLine("OnStop: Run() finished", "Information");
base.OnStop();
}
}
public class LogMessage : TableServiceEntity
{
public DateTime Time { get; set; }
public string Message { get; set; }
public string InstanceId { get; set; }
public string Category { get; set; }
public LogMessage() { }
public LogMessage(string message, string category)
{
Message = message;
Category = category;
Time = DateTime.UtcNow;
InstanceId = RoleEnvironment.CurrentRoleInstance.Id;
PartitionKey = RoleEnvironment.DeploymentId;
RowKey = (DateTime.MaxValue.Ticks - Time.Ticks).ToString("d19");
}
}
public class TableTraceListener : TraceListener
{
private TableServiceContext _context = null;
private TableServiceContext context
{
get
{
if (_context == null) {
var tables = CloudStorageAccount
.Parse(RoleEnvironment.GetConfigurationSettingValue(
Attributes["connectionStringName"] ?? "DataConnectionString"))
.CreateCloudTableClient();
tables.CreateTableIfNotExist("log");
_context = tables.GetDataServiceContext();
_context.MergeOption = MergeOption.NoTracking;
}
return _context;
}
}
protected override string[] GetSupportedAttributes() { return new[] { "connectionStringName" }; }
public override void Write(string message, string category)
{
context.AddObject("log", new LogMessage(message, category));
context.SaveChangesWithRetries();
}
public override void WriteLine(string message, string category) { Write(message + "\n", category); }
public override void Write(string message) { Write(message, null); }
public override void WriteLine(string message) { Write(message + "\n"); }
}
}
