Unable to Replace Fragment A with Fragment B in same Activity

Question

My App have one Main Activity which has a Linear Layout and Linear layout is showing one Fragment A having list containing Button and Text View. I want click on a Button of List view of Fragment A then It should Replace fragment A with Fragment B.

Now I am able to Click on the Button of list view of Fragment A but(it is not showing Fragment B) it is showing Android not responding. I have done Debug and I am Getting error at committing of transaction for Fragment B. other piece of Code is Working Fine.

Please help me out why I am getting this error Full code is below

Main Activity Code

public class MainActivity extends Activity {

FrameLayout frameLayout = null;
@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);
    Log.d("Async","On Create");

    frameLayout = (FrameLayout) findViewById(R.id.fragment_Container);
    InstallFragmetA();
}

protected void InstallFragmetA()
{
    FragmentA fragmentA = new FragmentA();
    FragmentManager manager= getFragmentManager();
    FragmentTransaction transaction = getFragmentManager().beginTransaction();
    transaction.add(R.id.fragment_Container,fragmentA,"A");
    transaction.commit();
}

protected void InstallFragmetB()
{
    FragmentB fragmentB = new FragmentB();
    FragmentManager manager= getFragmentManager();
    FragmentTransaction transaction = getFragmentManager().beginTransaction();
    transaction.add(R.id.fragment_Container,fragmentB,"B");
  transaction.commit();
}
protected void RemoveFragmetA()
{

    Log.d("Async","In Remove Fragment A");
    FragmentB fragmentB = new FragmentB();
    Log.d("Async","Fragment b initializeed");
   // FragmentManager manager= getFragmentManager();
    FragmentTransaction transaction = getFragmentManager().beginTransaction();
    Log.d("Async","Begin fragment transaction");
    FragmentA fragmentA = (FragmentA) getFragmentManager().findFragmentByTag("A");
   // fragmentA.onDestroy();
  //  fragmentA.onDestroyView();
    transaction.replace(R.id.fragment_Container, fragmentB, "B");
    Log.d("Async", "Fragment  A replaced");
//  transaction.setTransition(FragmentTransaction.TRANSIT_FRAGMENT_FADE);
    Log.d("Async","Fragment Failed");
//  transaction.addToBackStack(null);
    transaction.commit();
    Log.d("Async","Transaction Commit");

}

Fragment A Code

public class FragmentA extends Fragment  {
MainActivity mainActivity= null;
TextView textView=null;
String[] friendList= null;
public FragmentA()
{
    mainActivity = new MainActivity();
}
//Activity activity= null;
@Override
public void onAttach(Activity activity) {
    super.onAttach(activity);
    // this.activity = activity;
}
@Override
public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    Log.d("Async","On Create");
}
@Nullable
@Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
    Log.d("Async","On Create view");
    return inflater.inflate(R.layout.fragmenta,container,false);
}
@Override
public void onActivityCreated(Bundle savedInstanceState) {
    super.onActivityCreated(savedInstanceState);

    textView = (TextView) getActivity().findViewById(R.id.textView);
    ListView list = (ListView) getActivity().findViewById(R.id.listView);
    Log.d("Async","Array is "+getResources().getStringArray(R.array.FriendsList));
    friendList = getResources().getStringArray(R.array.FriendsList);
    Log.d("Async","Array is "+friendList[0]);
    textView.setText(friendList[0]);
    //   ArrayAdapter<CharSequence> adapter = ArrayAdapter.createFromResource(getActivity(),R.array.FriendsList,R.layout.text);

    AdapterClass adapterClass = new AdapterClass(getActivity(),friendList,mainActivity);
    list.setAdapter(adapterClass);
    list.setItemsCanFocus(true);
    list.setFocusable(true);
    list.setOnItemClickListener(new AdapterView.OnItemClickListener() {
        @Override


        public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
            Log.d("Async","A");
            Toast.makeText(getActivity(),"Hello "+position,Toast.LENGTH_LONG).show();

        }
    });
    Log.d("Async","On Activity Created");
}

}

Adapter Class Which I am Using for Fragment A

public class AdapterClass extends ArrayAdapter {
Button btn;
int counter=0;
Context c=null;
String[] friendList= null;
LayoutInflater l;
MainActivity mainActivity = null;
public AdapterClass(Context c, String[] friendList, MainActivity mainActivity) {
   super(c,R.layout.a,R.id.textView3,friendList);
   l  = (LayoutInflater) c.getSystemService(c.LAYOUT_INFLATER_SERVICE);
   Log.d("Async","counter is ");
   this.c=c;
   this.friendList = friendList;
   this.mainActivity = mainActivity;

}
@Override
public View getView(final int position, View convertView, ViewGroup parent) {
    Log.d("Async","getView is "+position);
    Log.d("Async","counter is "+counter);
    View row = convertView;
    Myholder holder = null;
    if(row == null)
    {
        Log.d("Async","Row is Null");
       row  = l.inflate(R.layout.a, parent,false);
        holder = new Myholder(row);
        row.setTag(holder);
        Log.d("Async","Row Set tag");
    }
    else
    {
        Log.d("Async","Row is not null");
        holder = (Myholder) row.getTag();
        Log.d("Async","Holder not tag");
    }
   holder.btn.setText(friendList[position]);
   holder.text.setText(friendList[position]);
   holder.btn.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View v) {
            Log.d("Async","Button Clicked "+friendList[position]);
            Toast.makeText(c,"Button clicked "+friendList[position],Toast.LENGTH_LONG).show();

           mainActivity.RemoveFragmetA();
        }
    });
    return row;
}

}

Fragment B Code

public class FragmentB extends Fragment {
public void onAttach(Activity activity) {
    super.onAttach(activity);
    // this.activity = activity;
}
@Override
public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    Log.d("Async", " Fragment B On Create");
}
@Nullable
@Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
    Log.d("Async"," Fragment B On Create view");
    return inflater.inflate(R.layout.fragmentb,container,false);
}
@Override
public void onActivityCreated(Bundle savedInstanceState) {
    super.onActivityCreated(savedInstanceState);
}

}

activity_main.xml

<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent"
android:layout_height="match_parent" android:paddingLeft="@dimen/activity_horizontal_margin"
android:paddingRight="@dimen/activity_horizontal_margin"
android:paddingTop="@dimen/activity_vertical_margin"
android:id="@+id/mainActivity"
android:paddingBottom="@dimen/activity_vertical_margin" tools:context=".MainActivity">
<FrameLayout
    android:layout_width="fill_parent"
    android:id="@+id/fragment_Container"
    android:layout_height="fill_parent"
    android:layout_alignParentTop="true"
    android:layout_alignParentLeft="true"
    android:layout_alignParentStart="true"></FrameLayout>

fragmenta.xml

<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:orientation="vertical" android:layout_width="match_parent"
android:id="@+id/linearLayouts"
android:layout_height="match_parent">
<TextView
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:background="#2233"
    android:textAppearance="?android:attr/textAppearanceLarge"
    android:text="Small Text"
    android:id="@+id/textView" />
<ListView
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:id="@+id/listView" />

fragmentb.xml

<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:orientation="vertical" android:layout_width="match_parent"
android:layout_height="match_parent">

<TextView
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:background="#2233"
    android:textAppearance="?android:attr/textAppearanceLarge"
    android:text="Small Text"
    android:id="@+id/textView" />

<ListView
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:id="@+id/listView1" />

I am getting bellow Error.

E/AndroidRuntime(1021):     java.lang.IllegalStateException: Activity has been destroyed
E/AndroidRuntime(1021):     at android.app.FragmentManagerImpl.enqueueAction(FragmentManager.java:1333)
E/AndroidRuntime(1021):     at android.app.BackStackRecord.commitInternal(BackStackRecord.java:595)
E/AndroidRuntime(1021):     at android.app.BackStackRecord.commit(BackStackRecord.java:574)
E/AndroidRuntime(1021):     at com.example.bathla.lab5_asynctasklabtest.MainActivity.InstallFragmetB(MainActivity.java:38)
E/AndroidRuntime(1021):     at com.example.bathla.lab5_asynctasklabtest.AdapterClass$1.onClick(AdapterClass.java:64)
E/AndroidRuntime(1021):     at android.view.View.performClick(View.java:4240)
E/AndroidRuntime(1021):     at android.view.View$PerformClick.run(View.java:17721)
E/AndroidRuntime(1021):     at android.os.Handler.handleCallback(Handler.java:730)
E/AndroidRuntime(1021):     at android.os.Handler.dispatchMessage(Handler.java:92)
E/AndroidRuntime(1021):     at android.os.Looper.loop(Looper.java:137)
E/AndroidRuntime(1021):     at android.app.ActivityThread.main(ActivityThread.java:5103)
E/AndroidRuntime(1021):     at java.lang.reflect.Method.invokeNative(Native Method)
E/AndroidRuntime(1021):     at java.lang.reflect.Method.invoke(Method.java:525)
E/AndroidRuntime(1021):     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:737)
E/AndroidRuntime(1021):     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553)
E/AndroidRuntime(1021):     at dalvik.system.NativeStart.main(Native Method)

Post your error log. And you need to use transaction.replace(), not the transaction.add() — kolombo, Sep 05 '15 at 19:41
Can you post your fragments and activity code somewhere? Maybe you have git repo? Or you can post it in your question. I show you how it must be. If you realy need this... — kolombo, Sep 06 '15 at 15:24
Hey! What a hell is this - `mainActivity = new MainActivity();`? Ohh... its very bad code, very bad code, my friend... Post your layouts. — kolombo, Sep 06 '15 at 17:28
Yes I know its bad code but i want some work around that's why I have done — Bat, Sep 06 '15 at 17:35
You were Right It was Bad Code Only. Now I am Able to Replace the Fragment B with Fragment A. It was Giving error due to MainActivity = new MainActivity(); only Now I have Made a seprate class and Now I am Calling those methods by That Class name Only. Thanks Very much for Your help — Bat, Sep 06 '15 at 18:17
Thanks Kolombo for your Help. Please let me know your email I will mail you whole code and Let me know how can I make it good code and what best practice I can use in this. — Bat, Sep 06 '15 at 18:26
Provide your list item layout `R.layout.a`. Not on email, add it in your post. Do you want to replace fragment when press on button inside list item, or just pressed in list item? — kolombo, Sep 06 '15 at 18:53
I want to replace the Fragment I am pressing the button of List item — Bat, Sep 06 '15 at 19:33
Acc. to my requirement It was working fine but code structure was bad so I have deleted my code but can you tell me why my code was bad so that I can improve? I am also new to java and android development So please me help I want to improve my skills on Programming. — Bat, Sep 06 '15 at 21:47
First of all, you need to mark my answer as accepted answer, because it's good example for others and besides that I spend a lot of time to write it for you. Now about your code. No, it wasn't working fine, because it's wrong code, so, wrong code can't working fine. Now I see that you do not understand activity and fragment lifecycle. You need to read it in documentation and read some tutorials in a Google. Secondary you don't need so many debug information, it's redundant. And you need Google your questions, before you post it on stackoverflow, because 99% answers is already there. — kolombo, Sep 06 '15 at 22:10

score 1 · Accepted Answer · answered Sep 06 '15 at 20:47

MainActivity

public class MainActivity extends Activity implements FragmentAListener
{
    private FragmentA fragmentA;
    private FragmentB fragmentB;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);
        fragmentA = (FragmentA) getFragmentManager().findFragmentByTag(FragmentA.class.getSimpleName());
        if (savedInstanceState == null) {
            fragmentA = new FragmentA();
            replaceToFragment(fragmentA, false);
        }
    }

    @Override
    public void onListItemButtonClicked(String itemName) {
        fragmentB = new FragmentB();
        Bundle bundle = new Bundle();
        bundle.putString(FragmentB.ITEM_NAME_KEY, itemName);
        fragmentB.setArguments(bundle);
        replaceToFragment(fragmentB, true);
    }

    public void replaceToFragment(Fragment fragment, boolean addToBackStack) {
        FragmentTransaction transaction = getFragmentManager().beginTransaction();
        transaction.replace(R.id.container, fragment, fragment.getClass().getSimpleName());
        if (addToBackStack) {
            transaction.addToBackStack(fragment.getClass().getSimpleName());
        }
        transaction.commit();
    }
}

FragmentA

public class FragmentA extends Fragment
{
    private String[] friendList;
    private FragmentAListener listener;

    @Override
    public void onAttach(Activity activity) {
        super.onAttach(activity);
        if (!(activity instanceof FragmentAListener)) {
            throw new RuntimeException("Activity must implements FragmentAListener");
        }
        listener = (FragmentAListener) activity;
    }

    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setRetainInstance(true);
    }

    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
        View view = inflater.inflate(R.layout.fragmenta, container, false);
        TextView textView = (TextView) view.findViewById(R.id.textView);
        ListView listView = (ListView) view.findViewById(R.id.listView);
        friendList = getResources().getStringArray(R.array.FriendsList);
        textView.setText(friendList[0]);
        AdapterClass adapterClass = new AdapterClass(inflater.getContext(), friendList, listener);
        listView.setAdapter(adapterClass);
        listView.setOnItemClickListener(itemClickListener);
        return view;
    }

    private AdapterView.OnItemClickListener itemClickListener = new AdapterView.OnItemClickListener()
    {
        @Override
        public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
            //TODO your code
        }
    };


    public interface FragmentAListener
    {
        void onListItemButtonClicked(String itemName);
    }
}

FragmentB

public class FragmentB extends Fragment
{
    public static final String ITEM_NAME_KEY = "item_name";

    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setRetainInstance(true);
    }

    @Nullable
    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
        View view = inflater.inflate(R.layout.fragmentb, container, false);
        //TODO find your views here
        TextView textView = (TextView) view.findViewById(R.id.textView);
        textView.setText("Its FragmentB. Selected item: " + getArguments().getString(ITEM_NAME_KEY));
        return view;
    }
}

Adapter

 public class AdapterClass extends ArrayAdapter<String>
{
    private LayoutInflater inflater;
    private FragmentAListener listener;

    public AdapterClass(Context context, String[] friendList, FragmentAListener listener) {
        super(context, 0, friendList);
        inflater = LayoutInflater.from(context);
        this.listener = listener;
    }

    @Override
    public View getView(final int position, View convertView, ViewGroup parent) {
        View view = convertView;
        Holder holder;
        if (view == null) {
            view = inflater.inflate(R.layout.list_item, parent, false);
            holder = new Holder(view);
            view.setTag(holder);
        } else {
            holder = (Holder) view.getTag();
        }
        String itemName = getItem(position);
        holder.textView.setText(itemName);
        holder.button.setText(itemName);
        holder.button.setTag(itemName);
        return view;
    }

    private class Holder
    {
        private TextView textView;
        private Button button;

        public Holder(View row) {
            textView = (TextView) row.findViewById(R.id.textView);
            button = (Button) row.findViewById(R.id.button);
            button.setOnClickListener(onClickListener);
        }
    }

    private OnClickListener onClickListener = new OnClickListener()
    {
        @Override
        public void onClick(View v) {
            listener.onListItemButtonClicked(v.getTag().toString());
        }
    };
}

Activity layout

<LinearLayout
    android:id="@+id/mainActivity"
    xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:paddingBottom="@dimen/activity_vertical_margin"
    android:paddingLeft="@dimen/activity_horizontal_margin"
    android:paddingRight="@dimen/activity_horizontal_margin"
    android:paddingTop="@dimen/activity_vertical_margin"
    tools:context=".MainActivity">

    <FrameLayout
        android:id="@+id/container"
        android:layout_width="match_parent"
        android:layout_height="match_parent">

    </FrameLayout>
</LinearLayout>

FragmentA layout

<LinearLayout android:id="@+id/linearLayouts"
    xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:orientation="vertical">

    <TextView
        android:id="@+id/textView"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:background="#2233"
        android:text="This is Fragment A"
        android:textAppearance="?android:attr/textAppearanceLarge"/>

    <ListView
        android:id="@+id/listView"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"/>
</LinearLayout>

FragmentB Layout

<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:orientation="vertical">

    <TextView
        android:id="@+id/textView"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:background="#2233"
        android:text="This is Fragment B"
        android:textAppearance="?android:attr/textAppearanceLarge"/>

    <ListView
        android:id="@+id/listView"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"/>
</LinearLayout>

List Item Layout

<?xml version="1.0" encoding="utf-8"?>
<LinearLayout
    android:id="@+id/fancy_item_fragment"
    xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:descendantFocusability="blocksDescendants"
    android:orientation="horizontal"
    android:padding="15dp">

    <TextView
        android:id="@+id/textView"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:layout_weight="1"
        android:text="Text"/>

    <Button
        android:id="@+id/button"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="Button"/>
</LinearLayout>

score 0 · Answer 2 · answered Sep 05 '15 at 22:06

0

Add this on your activity.xml, container for Fragment

    <FrameLayout
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        android:id="@+id/fragmentcontainer">
    </FrameLayout>

and this for attach Fragment

    Fragment fr;
    FragmentManager fm = getFragmentManager();
    FragmentTransaction fragmentTransaction = fm.beginTransaction();
    fr = new YourFragmentToShow();
    fragmentTransaction.replace(R.id.fragmentcontainer, fr)                    
    fragmentTransaction.setTransition(FragmentTransaction.TRANSIT_FRAGMENT_FADE);
    fragmentTransaction.commit();

answered Sep 05 '15 at 22:06

Michele Lacorte

5,323
7
32
54

I am still getting Illegal state Exception java.lang.IllegalStateException: Activity has been destroyed . – Bat Sep 06 '15 at 14:44
Still I am getting the Error – Bat Sep 06 '15 at 14:47
@Michele Lacorte because its a code of adapter, not the activity code – kolombo Sep 06 '15 at 15:26
This Is Adapter class which I am using in the Fragment's A Listview to populate rows of list view and I am calling fragment B by clicking on the item of List view from the adapter class directly. – Bat Sep 06 '15 at 15:27
@SahilBathla put your logcat error when your start fragment b – Michele Lacorte Sep 06 '15 at 15:41
I have already done after each statement I have put logs but I am getting error at tansaction.commit() statement – Bat Sep 06 '15 at 15:55
have you attach fragment a on the same fragmentcontainer?? – Michele Lacorte Sep 06 '15 at 15:56
Yes my Fragment A is attached to same Fragment container.I am not understanding why it is showing illegal state exception activity not destroyed. Because I am not destroying any activity or fragment I just want to replace One Fragment with another – Bat Sep 06 '15 at 16:00
check this http://stackoverflow.com/questions/15207305/getting-the-error-java-lang-illegalstateexception-activity-has-been-destroyed – Michele Lacorte Sep 06 '15 at 16:09
1

Thanks Michele for your help. Your last link is also helpful to me – Bat Sep 06 '15 at 18:27

Unable to Replace Fragment A with Fragment B in same Activity

2 Answers2

Linked