514

Given the following code:

var arr = [1,2,3,4,5];

var results: number[] = await arr.map(async (item): Promise<number> => {
        await callAsynchronousOperation(item);
        return item + 1;
    });

which produces the following error:

TS2322: Type 'Promise<number>[]' is not assignable to type 'number[]'. Type 'Promise<number> is not assignable to type 'number'.

How can I fix it? How can I make async await and Array.map work together?

Alon
  • 10,381
  • 23
  • 88
  • 152
  • 10
    Why are you trying to make a synchronous operation into an async operation? `arr.map()` is synchronous and does not return a promise. – jfriend00 Oct 19 '16 at 19:45
  • 4
    You can't send an asynchronous operation to a function, like `map`, which expects a synchronous one, and expect it to work. – Heretic Monkey Oct 19 '16 at 19:46
  • 5
    @jfriend00 I have many await statements in the inner function. It's actually a long function and I just simplified it to make it readable. I've added now an await call to make it clearer why it should be async. – Alon Oct 19 '16 at 20:05
  • 2
    You need to await something that returns a promise, not something that returns an array. – jfriend00 Oct 19 '16 at 20:15
  • async/await is not part of ES7. – Felix Kling Oct 21 '16 at 06:01
  • 5
    One useful thing to realise is that every time you mark a function as `async`, you're making that function return a promise. So of course, a map of async returns an array of promises :) – Anthony Manning-Franklin Oct 29 '18 at 06:52

9 Answers9

1066

The problem here is that you are trying to await an array of promises rather than a Promise. This doesn't do what you expect.

When the object passed to await is not a Promise, await simply returns the value as-is immediately instead of trying to resolve it. So since you passed await an array (of Promise objects) here instead of a Promise, the value returned by await is simply that array, which is of type Promise<number>[].

What you probably want to do is call Promise.all on the array returned by map in order to convert it to a single Promise before awaiting it.

According to the MDN docs for Promise.all:

The Promise.all(iterable) method returns a promise that resolves when all of the promises in the iterable argument have resolved, or rejects with the reason of the first passed promise that rejects.

So in your case:

var arr = [1, 2, 3, 4, 5];

var results: number[] = await Promise.all(arr.map(async (item): Promise<number> => {
    await callAsynchronousOperation(item);
    return item + 1;
}));

This will resolve the specific error you are encountering here.

Depending on exactly what it is you're trying to do you may also consider using Promise.allSettled, Promise.any, or Promise.race instead of Promise.all, though in most situations (almost certainly including this one) Promise.all will be the one you want.

Ajedi32
  • 45,670
  • 22
  • 127
  • 172
  • 4
    What do the `:` colons mean? – Daniel Node.js Oct 13 '17 at 23:20
  • 28
    @DanielPendergast It's for type annotations in TypeScript. – Ajedi32 Oct 13 '17 at 23:28
  • What is the difference between calling `callAsynchronousOperation(item);` with and without `await` inside the async map function? – nerdizzle Mar 27 '20 at 13:08
  • 2
    @nerdizzle That sounds like a good candidate for another question. Basically though, with `await` the function will wait for the asynchronous operation to complete (or fail) before continuing, otherwise it'll just immediately continue without waiting. – Ajedi32 Mar 27 '20 at 14:20
64

This is simplest way to do it.

await Promise.all(
    arr.map(async (element) => {
        ....
    })
)
ajitspyd
  • 754
  • 5
  • 8
59

Solution below to properly use async await and Array.map together. Process all elements of the array in parallel, asynchronously AND preserve the order:

const arr = [1, 2, 3, 4, 5, 6, 7, 8];

const randomDelay = () => new Promise(resolve => setTimeout(resolve, Math.random() * 1000));

const calc = async n => {
  await randomDelay();
  return n * 2;
};

const asyncFunc = async() => {
  const unresolvedPromises = arr.map(calc);
  const results = await Promise.all(unresolvedPromises);
  document.write(results);
};

document.write('calculating...');
asyncFunc();

Also codepen.

Notice we only "await" for Promise.all. We call calc without "await" multiple times, and we collect an array of unresolved promises right away. Then Promise.all waits for resolution of all of them and returns an array with the resolved values in order.

Miki
  • 1,625
  • 21
  • 29
  • 4
    Over the years of using Javascript, I have always had issues with mapping over arrays without messing up the order due to the async nature of js. I have used promised.all but never thought that it resolves them as is. This answer literally changed how I write maps and other things now. God bless. – sakib11 Aug 14 '20 at 19:12
  • 2
    Thanks for this solution, I found it much more eloquent and readable than the others provided. – S.. Dec 17 '21 at 16:40
23

There's another solution for it if you are not using native Promises but Bluebird.

You could also try using Promise.map(), mixing the array.map and Promise.all

In you case:

  var arr = [1,2,3,4,5];

  var results: number[] = await Promise.map(arr, async (item): Promise<number> => {
    await callAsynchronousOperation(item);
    return item + 1;
  });
Bojan Markovic
  • 510
  • 7
  • 22
Gabriel Cheung
  • 526
  • 3
  • 9
  • 3
    It is different - it doesn't run all operations in parallel, but rather executes them in sequence. – Andrey Tserkus Nov 15 '17 at 03:02
  • 5
    @AndreyTserkus `Promise.mapSeries` or `Promise.each` are sequencial, `Promise.map` starts them all at once. – Kiechlus Nov 30 '17 at 15:46
  • 1
    @AndreyTserkus you can run all or some operations in parallel by providing `concurrency` option. –  Jan 18 '18 at 21:26
  • 39
    It's worth mentioning that it's not a vanilla JS. – Michal Feb 24 '18 at 13:46
  • I missed the fact that you are talking about Bluebird when I first read this answer. It would be great to update the code of your answer to explicitly import `Promise` from `Bluebird`. – SunnyPro Jun 21 '23 at 17:50
16

If you map to an array of Promises, you can then resolve them all to an array of numbers. See Promise.all.

Dan Beaulieu
  • 400
  • 1
  • 11
14

You can use:

for await (let resolvedPromise of arrayOfPromises) {
  console.log(resolvedPromise)
}

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for-await...of

If you wish to use Promise.all() instead you can go for Promise.allSettled() So you can have better control over rejected promises.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/allSettled

5

I'd recommend using Promise.all as mentioned above, but if you really feel like avoiding that approach, you can do a for or any other loop:

const arr = [1,2,3,4,5];
let resultingArr = [];
for (let i in arr){
  await callAsynchronousOperation(i);
  resultingArr.push(i + 1)
}

FYI: If you want to iterate over items of an array, rather than indices (@ralfoide 's comment), use of instead of in inside let i in arr statement.

Just Mohit
  • 141
  • 1
  • 13
Beckster
  • 213
  • 3
  • 5
  • 14
    The Promise.all will be async for each element of the array. This will be a sync, it have to wait to finish one element in order to start the next one. – Santiago Mendoza Ramirez Mar 01 '18 at 15:38
  • 2
    For those trying this approach, note that for..of is the proper way to iterate an array content, whereas for..in iterates over the indices. – ralfoide Feb 14 '20 at 02:46
4

A solution using modern-async's map():

import { map } from 'modern-async'

...
const result = await map(myArray, async (v) => {
    ...
})

The advantage of using that library is that you can control the concurrency using mapLimit() or mapSeries().

nicolas-van
  • 935
  • 8
  • 13
0

I had a task on BE side to find all entities from a repo, and to add a new property url and to return to controller layer. This is how I achieved it (thanks to Ajedi32's response):

async findAll(): Promise<ImageResponse[]> {
    const images = await this.imageRepository.find(); // This is an array of type Image (DB entity)
    const host = this.request.get('host');
    const mappedImages = await Promise.all(images.map(image => ({...image, url: `http://${host}/images/${image.id}`}))); // This is an array of type Object
    return plainToClass(ImageResponse, mappedImages); // Result is an array of type ImageResponse
  }

Note: Image (entity) doesn't have property url, but ImageResponse - has