160

I have several output listeners that are implementing OutputStream. It can be either a PrintStream writing to stdout or to a File, or it can be writing to memory or any other output destination; therefore, I specified OutputStream as (an) argument in the method.

Now, I have received the String. What is the best way to write to streams here?

Should I just use Writer.write(message.getBytes())? I can give it bytes, but if the destination stream is a character stream then will it convert automatically?

Do I need to use some bridge streams here instead?

Joachim Sauer
  • 302,674
  • 57
  • 556
  • 614
yart
  • 7,515
  • 12
  • 37
  • 37
  • 2
    I am not sure but this sounds like you are trying to reinvent the wheel here, have you looked through the Java Base API, as well as Commons IO API? – posdef Nov 01 '10 at 12:57

6 Answers6

163

Streams (InputStream and OutputStream) transfer binary data. If you want to write a string to a stream, you must first convert it to bytes, or in other words encode it. You can do that manually (as you suggest) using the String.getBytes(Charset) method, but you should avoid the String.getBytes() method, because that uses the default encoding of the JVM, which can't be reliably predicted in a portable way.

The usual way to write character data to a stream, though, is to wrap the stream in a Writer, (often a PrintWriter), that does the conversion for you when you call its write(String) (or print(String)) method. The corresponding wrapper for InputStreams is a Reader.

PrintStream is a special OutputStream implementation in the sense that it also contain methods that automatically encode strings (it uses a writer internally). But it is still a stream. You can safely wrap your stream with a writer no matter if it is a PrintStream or some other stream implementation. There is no danger of double encoding.

Example of PrintWriter with OutputStream:

try (PrintWriter p = new PrintWriter(new FileOutputStream("output-text.txt", true))) {
    p.println("Hello");
} catch (FileNotFoundException e1) {
    e1.printStackTrace();
}
hnefatl
  • 5,860
  • 2
  • 27
  • 49
MForster
  • 8,806
  • 5
  • 28
  • 32
  • 7
    So using `PrintWriter` is just like using `String.getBytes()`. It uses whatever random encoding that happens to be the default of the JVM. So it only works if you're lucky. – Christoffer Hammarström Mar 16 '18 at 14:38
  • the code snippet should really be using a constructor that also takes a `Charset` param, especially given the first paragraph of the answer... – morgwai Jun 15 '23 at 19:27
122

OutputStream writes bytes, String provides chars. You need to define Charset to encode string to byte[]:

outputStream.write(string.getBytes(Charset.forName("UTF-8")));

Change UTF-8 to a charset of your choice.

Peter Knego
  • 79,991
  • 11
  • 123
  • 154
35

You can create a PrintStream wrapping around your OutputStream and then just call it's print(String):

final OutputStream os = new FileOutputStream("/tmp/out");
final PrintStream printStream = new PrintStream(os);
printStream.print("String");
printStream.close();
Illarion Kovalchuk
  • 5,774
  • 8
  • 42
  • 54
30

By design it is to be done this way:

OutputStream out = ...;
try (Writer w = new OutputStreamWriter(out, "UTF-8")) {
    w.write("Hello, World!");
} // or w.close(); //close will auto-flush
Anthony
  • 12,407
  • 12
  • 64
  • 88
  • 5
    Note that `w.close()` will close `out` as well. – Franklin Yu Jan 11 '18 at 16:32
  • 1
    I prefer this answer because it provides an explicit encoding specification! And I recommend using the existing predefined encodings, like StandardCharsets.UTF_8 instead of String literals ("UTF-8"). – HooNose Jun 08 '21 at 15:24
13

Wrap your OutputStream with a PrintWriter and use the print methods on that class. They take in a String and do the work for you.

NG.
  • 22,560
  • 5
  • 55
  • 61
9

You may use Apache Commons IO:

try (OutputStream outputStream = ...) {
    IOUtils.write("data", outputStream, "UTF-8");
}
Felix
  • 3,999
  • 3
  • 42
  • 66
  • `IOUtils.write(String data, OutputStream output, Charset encoding)` is implemented as `output.write(data.getBytes(Charsets.toCharset(encoding)))`, so it may if an encoded string can't fit in a byte array – Šarūnas Jun 15 '18 at 10:14