60

I have something along the lines of this:

object[] parameter = new object[1];
parameter[0] = x;
object instantiatedType =
Activator.CreateInstance(typeToInstantiate, parameter);

and

internal class xxx : ICompare<Type>
{
    private object[] x;

    # region Constructors

    internal xxx(object[] x)
    {
        this.x = x;
    }

    internal xxx()
    {
    }

    ...
}

And I get:

threw exception: System.MissingMethodException: Constructor on type 'xxxx.xxx' not found..

Any ideas?

giokoguashvili
  • 2,013
  • 3
  • 18
  • 37
KP65
  • 13,315
  • 13
  • 45
  • 46
  • I originally though you intended `parameter` to be the thing you passed as `x`. However, I just realised that's probably not what you meant and, looking at the other answers, it seems I'm not alone. If this is correct, I suggest renaming `parameter` to `parameters`. Or better still, dispense with `parameter` altogether: `Activator.CreateInstance(typeToInstantiate, new object[]{x})`. – Marcelo Cantos Nov 02 '10 at 11:55

4 Answers4

101

The issue is that Activator.CreateInstance(Type, object[]) does not consider non-public constructors.

Exceptions

MissingMethodException: No matching public constructor was found.

This is easily shown by changing the constructor to publicvisibility; the code then works correctly.

Here's one workaround (tested):

 BindingFlags flags = BindingFlags.NonPublic | BindingFlags.Instance;
 CultureInfo culture = null; // use InvariantCulture or other if you prefer
 object instantiatedType =   
   Activator.CreateInstance(typeToInstantiate, flags, null, parameter, culture);

If you only require the parameterless constructor this will work as well:

//using the overload: public static object CreateInstance(Type type, bool nonPublic)
object instantiatedType = Activator.CreateInstance(typeToInstantiate, true)
Sander Aernouts
  • 959
  • 4
  • 16
Ani
  • 111,048
  • 26
  • 262
  • 307
  • 10
    I tested this and think it's worth mentioning that this method ONLY works with non-public constructors. To make it work with both public AND non-public constructors, change the `BindingFlags` to `BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance` – qxn Jun 19 '14 at 19:53
  • Also you don't have to use object, you can use it like this: `YourType instantiatedType = (YourType)Activator.CreateInstance(typeof(YourType), true)` – donatasj87 Mar 16 '21 at 08:46
33

(tested successfully)

object instantiatedType =
   Activator.CreateInstance(typeToInstantiate,
   System.Reflection.BindingFlags.NonPublic |
     System.Reflection.BindingFlags.Instance,
   null, new object[] {parameter}, null);

There are two issues this addresses:

  • the new object[] {parameter} helps it handle the issue of passing an object[] as a single parameter of method that takes a params object[] argument
  • the BindingFlags helps resolve the non-public constructor

(the two nulls relate to the binder; the default binder behaviour is fine for what we want)

Marc Gravell
  • 1,026,079
  • 266
  • 2,566
  • 2,900
  • It seems like ` Activator.CreateInstance` can't determine the difference between two single-parameter constructors that accept different types... – Douglas Gaskell Jul 30 '19 at 22:45
  • This approach of running `Activator.CreateInstance()` really makes encapsulation irrelevant. Really nice one! – Jari Turkia Oct 24 '19 at 08:41
5

You need to call a different overload of Activator.CreateInstance that lets you pass a nonPublic or BindingFlags parameter.

I find all these CreateInstance overloads clumsy; what I prefer to do is:

  1. Call typeToInstantiate.GetConstructor(), passing BindingFlags.NonPublic
  2. Call ConstructorInfo.Invoke, passing it the constructor parameter
Tim Robinson
  • 53,480
  • 10
  • 121
  • 138
2

change it to

Activator.CreateInstance(typeToInstantiate,new object[] { parameter });

This is because your constructor also expects an object array and activator already splits it up into separate objects

Doggett
  • 3,364
  • 21
  • 17