2

I have a CDialogEx Class called Properties in which I handle the ON_COMMAND message. Now, ON_COMMAND should get called when I click the menu item ID_EDIT_PROPERTIES (as a submenu from main menu). The event handler wizard wrote that code for me, but when I start the Application the menu item remains grayed out. I've tried to manually activate it by calling EnableMenuItem when ON_UPDATE_COMMAND_UI happens, but to no avail.

Any help would be greatly appreciated.

Michen
  • 51
  • 2
  • 10
  • 1
    I've found out that it gets handled if I target the Document class of my project. This is an easy workaround it seems. But I'm still curious why I cannot handle it from the CDialogEx class. – Michen Nov 29 '16 at 11:31
  • Does your `ON_UPDATE_COMMAND_UI` handler ever get called? – Mark Ransom Nov 29 '16 at 16:19
  • AFAIK, The command handler are not called for dialogs. (see https://support.microsoft.com/en-us/kb/242577) – Max Nov 29 '16 at 18:56

3 Answers3

2

Per m_bAutoMenuEnable, When this data member is enabled (which is the default), menu items that do not have ON_UPDATE_COMMAND_UI or ON_COMMAND handlers will be automatically disabled when the user pulls down a menu.

Santosh Dhanawade
  • 1,756
  • 14
  • 29
2

You just need to understand how menu items enabling/disabling is handled:

  • If there is neither ON_COMMAND nor ON_UPDATE_COMMAND_UI handler the item is disabled.
  • If there exists no ON_UPDATE_COMMAND_UI handler but there is an ON_COMMAND one in the currently active document or view (or even the "mainframe"), the item is enabled.
  • If there exists a ON_UPDATE_COMMAND_UI handler, en-/disabling the item is determined by the handler (pCmdUI->Enable(bEnableState)).

Also keep in mind that:

  • You may not call EnableMenuItem() yourself, instead call pCmdUI->Enable(bEnableState) in an ON_UPDATE_COMMAND_UI handler. This affects not only the menu item, but any other "command"-type item (with the same ID), eg main menu, context menu, toolbar or rebar button.
  • Where to put the handler, is a matter of application design and depends on the data you are processing or representing. It can be put in the mainframe class (if it depends on some "global" data or setting), in the document class (if it depends on or changes some data or setting in the document - possibly affecting all views), or in the view class(-es) (depending on or affecting the current view only).

In your case, if I understand correctly, the item is disabled because the handler is in the CDialogEx-derived class, but no instance of this class has been created yet, ie there exists no ON_COMMAND handler for your ID_EDIT_PROPERTIES command.

Constantine Georgiou
  • 2,412
  • 1
  • 13
  • 17
0

I admit that I don't know ii it is different for CDialogEx, But for CDialog I found that the UPDATE_COMMAND_UI didn't ever work unless I handled the WM_KICKIDLE event.

In your OnKickIdle event handler make a call to:

CWnd::UpdateDialogControls

There is a short tutorial on it here.

Forgive me if CDialogEx supercedes this information and I will remove the answer.

Andrew Truckle
  • 17,769
  • 16
  • 66
  • 164