How do you revert a faulty git merge commit

Question

So one of my coworkers accidentally made a merge that actually only kept one side of the tree. So he started a merge, deleted all the changes introduced by the merge, and then committed the merge.

Here is a simple test case I did on a test repo. This repo has three branches. idx is the topic branch that was accidentally merged, and master is the mainline. dev is just a test of how revert -m works so you can ignore it.

alt text

What I want to do is revert the faulty merge. So from master I try to run git revert -m 1 <sha1sum of faulty merge> but then git responds with:

# On branch master                               
nothing to commit (working directory clean)

So it doesn't actually create a revert commit that undoes the merge. I believe that this happens because the merge didn't actually contain any real changes.

Is this a git bug, or am I missing something?

I'm not sure why you say "it doesn't actually create a merge commit" - it shouldn't. You should be expecting it to create a normal commit, which reverses the effect of the merge commit. — Cascabel, Nov 03 '10 at 15:40
Yeah, sorry that was supposed to say it doesn't actually create a revert commit. — Jason Axelson, Nov 03 '10 at 23:51
I don't understand the `-m 1` parameter. Why is it `1`? What other possible values could it be? What happens if it was `-m 2`? — Fábio Roberto Teodoro, Feb 16 '22 at 15:22

score 10 · Answer 1 · edited May 17 '18 at 15:32

10

The git documentation says this about reverting merges: git/Documentation/howto/revert-a-faulty-merge.txt although this is mostly about reverting merges that brought in bad changes, rather than reverting merges that were done incorrectly.

Basically, reverting a merge will undo the data changes, but not the history (graph) changes. Therefore it is expected that reverting your faulty merge does nothing.

One way you can deal with this is to do the merge again, then merge the result of that into master. In your example this could be like:

git checkout -b temp/merge-fixup ead364653b601f48159bca5cb59d6a204a426168
git merge 2fce9bfe8f721c45ea1ed5f93176322cac60a1d9
git checkout master
git merge temp/merge-fixup
git branch -d temp/merge-fixup

edited May 17 '18 at 15:32

sonnyb

3,194
2
32
42

answered Nov 04 '10 at 21:00

jilles

10,509
2
26
39

2

And now that documentation seems to be gone. – kojiro Dec 05 '11 at 22:56
1

@kojiro: Googling for `revert-a-faulty-merge.txt` yields plenty of mirrors, as of today. – Frerich Raabe Jan 30 '12 at 13:02

score 9 · Accepted Answer · answered Nov 03 '10 at 05:40

9

The best rule of thumb here is to never ever change the history of your repo after it has been made public. It really screws things up. I don't think this case can avoid it though.

I think there are a couple of options here but the simplest is to do a rebase. Using your repo, these are the commands I used:

git rebase -i ead3646

Then, when the interactive shell comes up, remove the entire line of the faulty commit. Save that and you should wind up with a new history like this:

* f0ab6d5 more normal work on dev
* ebb5103 idx commit
* ead3646 master change
* 582c38c dev commits
* f4b8bc6 initial commit

Getting you two (and others) back in sync is going to take some branching, pushing, emailing and lunch buying.

answered Nov 03 '10 at 05:40

brycemcd

4,343
3
26
29

Getting back in synch is really not that complicated. Since I have never seen a recipe elsewhere, though, I wrote one up and posted it here: http://stackoverflow.com/questions/4084868 – Aristotle Pagaltzis Nov 03 '10 at 07:09
2

I haven't had a chance to carefully read the `git revert` docs on the subject of merge commits, but the `-m` option is specifically to allow it to operate on merge commits. Clearly there is supposed to be a way to do it, and the questions is why it didn't work in this case. – Cascabel Nov 03 '10 at 15:40

How do you revert a faulty git merge commit

2 Answers2

Linked

Related