Use data binding to set View visibility

Question

Trying to set visibility of View using custom variable, but error occurs: Identifiers must have user defined types from the XML file. visible is missing it. Is it possible to set view visibility using data binding? Thanks.

<data>
    <variable
        name="sale"
        type="java.lang.Boolean"/>
</data>

<FrameLayout android:visibility="@{sale ? visible : gone}"/>

Refer [Android Data Binding: visibility on include tag](https://stackoverflow.com/questions/35723823/android-data-binding-visibility-on-include-tag) — Ravi, Jun 08 '17 at 05:00

score 339 · Accepted Answer · edited Jun 07 '17 at 21:26

339

As stated in the Android Developer Guide, you need to do it like this:

<data>
    <import type="android.view.View"/>
    <variable
        name="sale"
        type="java.lang.Boolean"/>
</data>

<FrameLayout android:visibility="@{sale ? View.GONE : View.VISIBLE}"/>

edited Jun 07 '17 at 21:26

tynn

38,113
8
108
143

answered Jun 07 '17 at 18:48

David Artmann

4,272
1
16
24

7

and how to set value to "sale"? – RobinHood Nov 01 '17 at 13:31
So you mean how to assign the value "sale" to a String variable? – David Artmann Nov 01 '17 at 13:38
exactly! I'm facing issue. Please share I will compare and then let you know. – RobinHood Nov 01 '17 at 13:49
58

Damn it! How I missed the Silly *import*. Done, thanks. – RobinHood Nov 01 '17 at 14:00
Hey! any idea why *position* glitch on scroll? [Adapter](https://paste.ofcode.org/38HVLLLMa9mUZMxq9BfMSeh) – RobinHood Nov 01 '17 at 14:12
I can not see any issue with the code, but I doubt that this is enough to analyse your problem. Maybe you can provide me a fully running example which I could test (e.g. a sample GitHub repo)? – David Artmann Nov 01 '17 at 15:05
@RobinHood from your activity or fragment. example for activity ``` boolean isSale = true; binding = DataBindingUtil.setContentView(this, R.layout.activity_main); binding.setSale(isSale); ``` – Moaz Rashad Mar 26 '19 at 10:51
I am the 222th click – Raymond Chenon Nov 24 '20 at 21:55

score 69 · Answer 2 · answered Jun 07 '17 at 19:10

69

In your layout:

<data>
    <variable
        name="viewModel"
        type="...."/>
</data>


<View
 android:layout_width="10dp"
 android:layout_height="10dp"
 android:visibility="@{viewModel.saleVisibility, default=gone}"/>

In your ViewModel java code:

@Bindable
public int getSaleVisibility(){
 return mSaleIndecator ? VISIBLE : GONE;
}

answered Jun 07 '17 at 19:10

Lior

832
6
6

4

you saved me from a minor headache – vanlooverenkoen Oct 23 '17 at 13:06
2

Your data model have to be Observable for that to work. – yshahak Jan 29 '18 at 06:47
this worked for me *without* including `@Bindable`. When I included that I was getting different binding errors, including suggestion to extend `BaseObservable`. Good pointer here – Gene Bo Feb 02 '18 at 01:24
2

Must be the accepted answer ! It's worked for me perfectly ! – Crisic Feb 12 '18 at 12:09
1

Any suggestion for `LiveData`? – Sourav Bagchi Dec 13 '19 at 07:34

score 50 · Answer 3 · answered Jun 07 '17 at 18:46

50

The problem is that visibility is an Integer on the View class, this means you have two ways to make this work:

Use the View.VISIBLE and View.GONE constants. https://developer.android.com/topic/libraries/data-binding/index.html#imports
Define a custom setter for visibility that takes a Boolean. https://developer.android.com/topic/libraries/data-binding/index.html#custom_setters

Possible implementation:

@BindingAdapter("android:visibility")
public static void setVisibility(View view, Boolean value) {
    view.setVisibility(value ? View.VISIBLE : View.GONE);
}

Which will make <FrameLayout android:visibility="@{sale}"/> work.

answered Jun 07 '17 at 18:46

Kiskae

24,655
2
77
74

4

Where it is convenient for you, the annotation processor automatically detects them during compilation. – Kiskae Dec 26 '17 at 18:02
Thank you, I put it in my BindingUtils.java – nhoxbypass Dec 26 '17 at 18:05
but how to set value sale? – EslamWael74 Aug 12 '18 at 14:31
1

how can I apply same approach to – Zafer Celaloglu Sep 05 '18 at 19:15
1

@EslamWael74 you set the value of sale via the binding in your Java/Kotlin code. Something like val binding = MyClassBinding.inflate(...), and then you can just call binding.sale = true. – Matt Robertson Feb 16 '19 at 17:32

score 5 · Answer 4 · answered Jun 16 '21 at 18:21

Similar to Kiskae solution. Put this method in a separate file, for instance, Bindings.kt:

@BindingAdapter("android:visibility")
fun View.bindVisibility(visible: Boolean?) {
    isVisible = visible == true
    // visibility = if (visible == true) View.VISIBLE else View.GONE
}

Then in layout XML:

<data>

    <variable
        name="viewModel"
        type="SomeViewModel" />
</data>

<TextView
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:visibility="@{viewModel.number == 1}" />

Use data binding to set View visibility

4 Answers4