redis keys getting stuck with TTL at -1

Question

I am using redis to manage rate limits on an API, and using SETEX to have the rate limit automatically reset every hour.

I've found that redis is failing to purge some keys and reporting their TTL at -1. Here's an example of a redis-cli session demonstrating this, using a placeholder IP address:

> GET allowance:127.0.0.1
> 0
> TTL allowance:127.0.0.1
-1
> GET allowance:127.0.0.1
0

Notice that despite its TTL being negative, redis does not purge this key when I GET it.

I've tried to reproduce this state and cannot.

> SETEX doomedkey -1 hello
(error) ERR invalid expire time in SETEX
> SETEX doomedkey 0 hello
(error) ERR invalid expire time in SETEX
> SETEX doomedkey 5 hello
OK
> TTL doomedkey
4
> GET doomedkey
hello

(... wait 5 seconds)

> TTL doomedkey
-2
> GET doomedkey
(nil)

Is this some unfortunate race condition causing redis to fail to expire these keys? Out of tens of thousands that have been successfully expired, only about 10 remain stuck in the -1 state.

I am using redis_version:2.8.9.

`-1` means there's no associated expire with the key. I think someone called `set key value` on the key, and the expire has been reset. — for_stack, Feb 21 '17 at 01:58
interesting. thank you, I will look into why this would be happening. — Artur Sapek, Feb 22 '17 at 01:00

score 2 · Answer 1 · answered Jun 15 '17 at 19:48

I ran into the same issue, only using Redis 2.8.24, but also using it for API rate limiting.

I suspect you are doing the rate limiting like this (using Ruby code just for the example):

def consume_rate_limit
  # Fetch the current limit for a given account or user
  rate_limit = Redis.get('available_limit:account_id')

  # It can be nil if not already initialized or if TTL has expired
  if rate_limit == nil
    # So let's just initialize it to the initial limit
    # Let's use a window of 10,000 requests, resetting every hour
    rate_limit = 10000
    Redis.setex('available_limit:account_id', 3600, rate_limit - 1)
  else
    # If the key already exists, just decrement the limit
    Redis.decr('available_limit:account_id')
  end

  # Return true if we are OK or false the limit has been reached
  return (rate_limit > 0)
end

Well, I was using this approach and found out there's a cocurrency problem between the "get" and the "decr" call which leads to the exact issue you described.

The issue happens when the TTL of the rate-limit key expires just after the "get" call but before the "decr" call. What will happen:

First the "get" call will return the current limit. Let's say it returned 500. Then in just a matter of some fraction of miliseconds, the TTL of that key expires, so it doesn't exist anymore in Redis. So the code continues to run and the "decr" call is reached. Also the bug is reached here:

The decr documentation states (my emphasis):

Decrements the number stored at key by one. If the key does not exist, it is set to 0 before performing the operation. (...)

As the key has been deleted (because it has expired), the "decr" instruction will initialize the key to zero and then decrement it, which is why the key value is -1. And the key will be created without a TTL, so issuing a TTL key_name will also issue -1.

The solution for that might be to wrap all that code inside a transaction block using MULTI and EXEC commands. However, that might be slow because it requires multiple round-trips to the Redis server.

The solution I've used was to write a Lua script and run it using the EVAL command. It has the advantage of being atomical (which means no concurrency issues) and has only one RTT to the Redis server.

local expire_time = ARGV[1]
local initial_rate_limit = ARGV[2]
local rate_limit = redis.call('get', KEYS[1])
-- rate_limit will be false when the key does not exist. 
-- That's because redis converts Nil to false in Lua scripts.
if rate_limit == false then
  rate_limit = initial_rate_limit
  redis.call('setex', KEYS[1], initial_rate_limit, rate_limit - 1)
else
  redis.call('decr', KEYS[1])
end
return rate_limit

To use it, we could rewrite the consume_rate_limit function to this:

def consume_rate_limit
  script = <<-LUA
      ... that script above, omitting it here not to bloat things ... 
    LUA
  rate_limit = Redis.eval(script, keys: ['available_limit:account_id'], argv: [3600, 10000]).to_i
  return (rate_limit > 0)
end

redis keys getting stuck with TTL at -1

1 Answers1

Linked