14

I've an XML file test.xml

<?xml version="1.0"?>
<info>
  <user>
    <name>
      <firstname>FirstName</firstname>
      <lastname>Last Name</lastname>
      <nameCoordinate>
        <xName>125</xName>
        <yName>20</yName>
      </nameCoordinate>
    </name>
  </user>
</info>

I'm trying to update the node xName & yName using PHP on a form submission. So, I've loaded the file using simplexml_load_file(). The PHP form action code is below

<?php 
    $xPostName = $_POST['xName'];
    $yPostName = $_POST['yName'];

    //load xml file to edit
        $xml = simplexml_load_file('test.xml');

    $xml->info->user->name->nameCoordinate->xName = $xPostName;
    $xml->info->user->name->nameCoordinate->yName = $yPostName;
    echo "done";
?>

I want to update the node values but the above code seems to be incorrect. Can anyone help me rectify it??

UPDATE: My question is somewhat similar to this Updating a XML file using PHP but here, I'm loading the XML from an external file and also I'm updating an element, not an attribute. That's where my confusion lies.

Community
  • 1
  • 1
ptamzz
  • 9,235
  • 31
  • 91
  • 147

3 Answers3

37

You're not accessing the right node. In your example, $xml holds the root node <info/>. Here's a great tip: always name the variable that holds your XML document after its root node, it will prevent such confusion.

Also, as Ward Muylaert pointed out, you need to save the file.

Here's the corrected example:

// load the document
// the root node is <info/> so we load it into $info
$info = simplexml_load_file('test.xml');

// update
$info->user->name->nameCoordinate->xName = $xPostName;
$info->user->name->nameCoordinate->yName = $yPostName;

// save the updated document
$info->asXML('test.xml');
Josh Davis
  • 28,400
  • 5
  • 52
  • 67
3

You have to write the changes back to the file, use the asXML method of the SimpleXMLElement.

Ward Muylaert
  • 545
  • 4
  • 27
  • I believe that rewrites the whole tags. I want to update only specific nodes. – ptamzz Jan 20 '11 at 14:13
  • 1
    It does, but short of writing half the XML interpreting logic in your own code to only write specific nodes, I believe that is as far as you'll get with SimpleXML. – Ward Muylaert Jan 20 '11 at 14:17
2

try like this.

$xmlDoc = new \DOMDocument;
$xmlDoc->load('Books.xml');
$response = $xmlDoc->getElementsByTagName('Text');

foreach ($response as $node){
        $node->nodeValue = 'test';
    }
$xmlDoc->saveXML();

this might not the best answer but it worked for me.

Ruhith Udakara
  • 2,236
  • 1
  • 18
  • 24