Shell Script Syntax Error: Unexpected End of File

Question

In the following script I get an error:

syntax error: unexpected end of file

What is this error how can I resove it? It is pointing at the line whee the function is called.

#!/bin/sh

expected_diskusage="264"
expected_dbconn="25"
expected_httpdconn="20"
expected_cpuusage="95"
#expected_fd="100"

httpdconn=`ps -ef|grep -i httpd|grep -v grep|wc -l` #httpd connections
cpu_usage=`ps aux|awk 'NR > 0 { s +=$3 }; END {print s}'`
disk_usage=`df -h|awk {'print $2'}|head -n3|awk 'NF{s=$0}END{print s}'`
#db_connections=`mysql -uroot -pexxxxxx -s -N -e "show processlist"|wc -l`

db_connections=6
cld_alert()
{
    nwconn=$1
    cpu_usage=$2
    disk_usage=$3
    db_connections=$4
    message=$5
    `touch /tmp/alert.txt && > /tmp/alert.txt`
    date=`date`
    echo -e "$date\n" > /tmp/alert.txt
    echo -e "$message" >> /tmp/alert.txt
    path="/proc/$httpd/fd/";
    cd $path
    tfd=`ls -l|wc -l`;
    sfd=`ls -ltr|grep sock|wc -l`;
    echo "Total fds: $tfd" >> /tmp/alert.txt
    echo "Socket fds: $sfd" >> /tmp/alert.txt
    echo "Other fds: $[$tfd - $sfd]" >> /tmp/alert.txt


    freememory=`vmstat | awk '{if (NR == 3) print "Free Memory:"\$4}'`;
    echo "Free memory :$freememory" >> /tmp/alert.txt
    Bufferedmemory=`vmstat | awk '{if (NR == 3) print "Buffered Memory:"\$5}'`;
    echo "Buffered memory $Bufferedmemory" >> /tmp/alert.txt
    CacheMemory=`vmstat | awk '{if (NR == 3) print "Cache Memory:"\$6}'`;
    echo "Cache memory : $CacheMemory" >> /tmp/alert.txt
    sshconn=`netstat -an|grep 22|wc -l`  #ssh connections
    httpsconn=`netstat -an|grep 443|wc -l`  #https connections
    wwwconn=`netstat -an|grep 80|wc -l`  #www connections
    echo "Disk usage is $disk_usage" >> /tmp/alert.txt
    echo "DB connections $db_connections" >> /tmp/alert.txt
    echo "Network connections $nwconn" >> /tmp/alert.txt
    echo "CPU Usage: $cpu_usage" >> /tmp/alert.txt
    topsnapshot=`top -n 1 -b`
    echo "===========================TOP COMMAND    SNAPSHOT====================================================";
    echo "$topsnapshot" >> /tmp/alert.txt
    echo"==================PS COMMAND SNAPSHOT=============================================================="
    entireprocesslist=`ps -ef`
    echo "$entireprocesslist" >> /tmp/alert.txt


    echo Hello hi"";

}



message=""
if [ ${disk_usage%?} -le $expected_diskusage ]    ##{x%?} Removes last character
then
    echo "disk usage exceeded";
    message="Disk usage limit exceeded \nCurrent disk usage is $disk_usage\nConfigured disk usage is    $expected_diskusage\n\n\n\n\n";
    #Checking for CPU usage
    if [ $cpu_usage -ge $expected_cpuusage]    ##{x%?}
    then
        echo "CPU usage exceeded";
        if [ $message -ne "" ]
        then
            message="$message\n\nCPU usage exceeded configured usage limit \nCurrent CPU usage is $cpu_usage\nConfigured CPU usage is $expected_cpuusage\n\n\n\n\n";
        else
            message="CPU usage exceeded configured usage limit \nCurrent CPU usage is   $cpu_usage\nConfigured CPU usage is $expected_cpuusage\n\n\n\n\n";
        fi ;
    fi
    #Checking for httpd connections
    if [ $httpdconn -ge $expected_httpdconn]    ##{x%?}
    then
        echo "HTTPD connections exceeded";
        if [ $message -ne "" ]
        then
            message="$message\n\nHTTPD connections exceeded configured usage limit \nCurrent HTTPD connections is $httpdconn\nConfigured HTTPD connection is $expected_httpdconn";
        else
            message="HTTPD connections exceeded configured usage limit \nCurrent HTTPD connections is $httpdconn\nConfigured HTTPD connection is $expected_httpdconn";
        fi ;
    fi ;
    message="$message\n\n\n\n\n";
    value=$(cld_alert $message $httpdconn $cpu_usage $disk_usage $db_connections)

please copy the whole script (well, we would like to see a minimal code that reproduces the problem, but you already failed to post that...) — Karoly Horvath, Mar 27 '12 at 09:01
Indent the code according to nesting level. And at least 4 spaces per indentation level at that, so you can really see the structure. It's most probably missing `fi` or `}` somewhere, but without indentation you won't ever see where. — Jan Hudec, Mar 27 '12 at 09:17
What is the assignment to value in the last line used for - the value is never used. — user unknown, Mar 27 '12 at 09:23
The value can be removed ,i will edit the post for the last line — Rajeev, Mar 27 '12 at 09:24

camh · Accepted Answer · 2017-11-30T04:52:14.060

148

Edit: Note that the original post has been edited since this answer was written and has been reformatted. You should look at the history to see the original formatting to understand the context for this answer.

This error occurs often when you have mismatched structure - that is, you do not have matching double quotes, matching single quotes, have not closed a control structure such as a missing fi with an if, or a missing done with a for.

The best way to spot these is to use correct indentation, which will show you where you have a broken control structure, and syntax highlighting, which will show you where quotes are not matched.

In this particular case, I can see you are missing a fi. In the latter part of your code, you have 5 ifs and 4 fis. However you also have a number of other problems - your backquoted touch /tmp/alert.txt... command is syntactically invalid, and you need a space before the closing bracket of an if test.

Clean up your code, and errors start to stand out.

edited Nov 30 '17 at 04:52

answered Mar 27 '12 at 09:27

camh

40,988
13
62
70

1

Awesome! This was really helpful. These are the common things which just slip. Keep adding :) – Shobhit Puri May 14 '15 at 23:07
Thanks a lot :-) – Sudarshana Dayananda May 23 '19 at 06:42
2

[ShellCheck](https://www.shellcheck.net/) is great for finding out the exact error locations and maybe even further errors or warnings. – SimonH Jan 20 '22 at 15:23
[shfmt](https://github.com/mvdan/sh#shfmt) is another tool that has also been released since I answered this question that does the code clean-up for you. shellcheck and shfmt are essential tools for writing shell scripts. – camh Jan 22 '22 at 21:32

score 57 · Answer 2 · answered May 07 '18 at 11:04

57

in my case the issue was in the EOL Conversion. (End Of Line).

i created the file on windows and only after i converted the EOL from windows(CR LF) to unix(LF), everything went well.

I did the conversion with Notepad++ very easily from: Edit -> EOL Conversion -> Unix(LF)

answered May 07 '18 at 11:04

David Gidony

1,243
3
16
31

12

This answer helped me. Using vscode , at bottom right of the editor change *CRLF* to *LF* – cjmling Jun 25 '19 at 12:11
2

this helped me, I was running my file in wsl, and file was created in windows notepad++. – Tushar Gautam Jun 10 '20 at 14:06
2

This one helped, exact same approach as @cjmling said – Minh Kha Feb 23 '21 at 02:54

score 16 · Answer 3 · answered Apr 23 '19 at 16:01

16

Unrelated to the OP's problem, but my issue was that I'm a noob shell scripter. All the other languages I've used require parentheses to invoke methods, whereas shell doesn't seem to like that.

function do_something() {
  # do stuff here
}

# bad
do_something()

# works
do_something

answered Apr 23 '19 at 16:01

ps2goat

8,067
1
35
68

1

its worked, thank you – C.V Apr 13 '21 at 12:33

score 11 · Answer 4 · edited Feb 11 '14 at 06:35

11

In my case, I found that placing a here document (like sqplus ... << EOF) statements indented also raise the same error as shown below:

./dbuser_case.ksh: line 25: syntax error: unexpected end of file

So after removing the indentation for this, then it went fine.

Hope it helps...

edited Feb 11 '14 at 06:35

Shiva Saurabh

1,281
2
25
47

answered Feb 11 '14 at 06:13

Praveen Rao K

111
1
2

1

This! I used heredoc inside an `if` block. It felt so wrong to have un-indented code in the block, but it's absolutely necessary. – Zeal Jul 06 '16 at 17:50

score 9 · Answer 5 · answered Nov 06 '17 at 23:02

9

Indentation when using a block can cause this error and is very hard to find.

if [ ! -d /var/lib/mysql/mysql ]; then
   /usr/bin/mysql --protocol=socket --user root << EOSQL
        SET @@SESSION.SQL_LOG_BIN=0;
        CREATE USER 'root'@'%';
   EOSQL
fi

=> Example above will cause an error because EOSQL is indented. Remove indentation as shown below. Posting this because it took me over an hour to figure out the error.

if [ ! -d /var/lib/mysql/mysql ]; then
   /usr/bin/mysql --protocol=socket --user root << EOSQL
        SET @@SESSION.SQL_LOG_BIN=0;
        CREATE USER 'root'@'%';
EOSQL
fi

answered Nov 06 '17 at 23:02

ibaralf

12,218
5
47
69

5

You are not joking when you said this error is `VERY HARD` to find – Kenan Aug 27 '18 at 18:49
If only I could give you a medal for this answer. Thanks. This indentation just took my half day!! – likeGreen Dec 09 '22 at 04:32

score 6 · Answer 6 · answered Mar 11 '16 at 13:27

6

I have found that this is sometimes caused by running a MS Dos version of a file. If that's the case dos2ux should fix that.

dos2ux file1 > file2

answered Mar 11 '16 at 13:27

patel8786

111
1
2

score 4 · Answer 7 · answered Dec 03 '13 at 16:34

4

Helpful post, I found that my error was using else if instead of elif like so:

if [ -z "$VARIABLE1" ]; then
    # do stuff
else if [ -z "$VARIABLE2" ]; then
    # do other stuff
fi

Fixed it by changing to this:

if [ -z "$VARIABLE1" ]; then
    # do stuff
elif [ -z "$VARIABLE2" ]; then
    # do other stuff
fi

answered Dec 03 '13 at 16:34

pinkston00

168
9

Thank you from nearly 9 years in the future – Thomas Wood Mar 20 '22 at 07:47

score 4 · Answer 8 · edited May 23 '17 at 11:54

4

I had this problem when running some script in cygwin. Fixed by running dos2unix on the script, with proper description of problem and solution given in that answer

edited May 23 '17 at 11:54

Community

1
1

answered Feb 06 '15 at 09:47

shtolik

1,341
22
29

score 3 · Answer 9 · answered Mar 27 '12 at 09:24

You've got an unclosed quote, brace, bracket, if, loop, or something.

If you can't see it just by looking (I'd recommend a syntax colouring editor and a neat indentation style), take a copy of the script, and delete half of it, cutting it of somewhere that ought to be valid. If the script runs, as far as it can, then the problem is in the other half. Repeat until you've narrowed down the problem.

score 2 · Answer 10 · edited Jun 20 '20 at 09:12

echo"==================PS COMMAND SNAPSHOT=============================================================="

needs to be

echo "==================PS COMMAND SNAPSHOT=============================================================="

Else, a program or command named echo"===... is searched.

Shell Script Syntax Error: Unexpected End of File

12 Answers12

more problems:

Linked