6

I am working on a project where I need to make a function that will parse the 4 default math operations (addition, subtraction, multiplication, division). It would be nice if the function could parse operations between brackets.

So, a must is that the function first check for multiplication and division operations (should check for that after it parser all operations between brackets if they exist, and that rule should apply for bracket operations [the biggest problem is that the brackets can contain brackets]). After doing all multiplication and division operations, it should do all addition and subtraction operations. The final number should be returned by functions.

Another nice addition would be a RegExp string that will check for math operations.

Thanks in advance!

6 Answers6

6

This should be pretty secure:

function do_maths($expression) {
  eval('$o = ' . preg_replace('/[^0-9\+\-\*\/\(\)\.]/', '', $expression) . ';');
  return $o;
}

echo do_maths('1+1');
dave1010
  • 15,135
  • 7
  • 67
  • 64
2

You could use eval() (WARNING: be sure what enters is a math operation and not some other arbitrary input or php code).

$input = "3 + (4 - 2 * 8) / 2";

eval('$result = ' . $input . ';');

echo "The result is $result";
Carlos Campderrós
  • 22,354
  • 11
  • 51
  • 57
  • I wonder if it would be possible to make an eval() 100% safe for math expressions if you were to check for any unrecognized character; i.e. `preg_replace('~[^0-9.()-+*/]~', '', $input);` – Martijn Jan 16 '14 at 16:11
  • @Martijn probably that would work, and is the method used in the accepted answer as well. – Carlos Campderrós Jan 17 '14 at 08:42
2

there was a similar problem
How to evaluate formula passed as string in PHP? you can try to use Class: Eval Math from php classes http://www.phpclasses.org/package/2695-PHP-Safely-evaluate-mathematical-expressions.html

Community
  • 1
  • 1
Fivell
  • 11,829
  • 3
  • 61
  • 99
1

I can recommend https://github.com/andig/php-shunting-yard which is a PSR-0 compatible implementation of the Shunting Yard algorithm.

andig
  • 13,378
  • 13
  • 61
  • 98
0

Regular expressions aren't the answer here; I suggest using an expression tree where all terminal nodes are constants or variables, and the rest of the nodes are operators. For example, 2 + 3 * 4 becomes:

+ --- 2
  |
  --- * --- 3
        |
        --- 4

Then, you evaluate the expression by using a depth-first traversal. In PHP it's sort of difficult to represent trees, but you could either use a built-in library as a commenter suggested or represent them using an associative array of arrays.

Jimmy Sawczuk
  • 13,488
  • 7
  • 46
  • 60
0

if you want a truly safe math parser, then eval won't do it. bcParserPHP can do it. It is implemented in PHP and does not use eval, thus it is very secure.

Henry
  • 9
  • 1