152

Forgive me for this is a very simple script in Bash. Here's the code:

#!/bin/bash
# june 2011

if [ $# -lt 3 -o $# -gt 3 ]; then
   echo "Error... Usage: $0 host database username"
   exit 0
fi

after running sh file.sh:

syntax error: unexpected end of file

fedorqui
  • 275,237
  • 103
  • 548
  • 598
markcruz
  • 1,577
  • 2
  • 10
  • 7

23 Answers23

184

I think file.sh is with CRLF line terminators.

run

dos2unix file.sh

then the problem will be fixed.

You can install dos2unix in ubuntu with this:

sudo apt-get install dos2unix
clyfish
  • 10,240
  • 2
  • 31
  • 23
  • Whats the reason behind this problem? I usually work on Windows but need to transfer scripts to unix systems. – CMCDragonkai Nov 02 '13 at 16:06
  • Newline in windows is "\r\n", while in linux is "\n". – clyfish Nov 04 '13 at 03:12
  • 10
    @KeesdeKooter I wouldn't say just because something didn't work for you that you should downvote it, clearly it worked for the 28 upvotes. A simple it didn't work for me suffices. That's why SO allowed multiple answers to a question because there can be multiple solutions to a problem. – Jeff Wilbert Jul 27 '15 at 15:33
  • 3
    Using notepad++ editor Edit>EOL Conversion>Old Mac Format solved it for me. – raktale Jan 22 '16 at 12:15
  • If you can Edit your bash file with Notepad++. Go to Edit-> EOL Conversion-> Macintosh(CR). Change it to Macintosh(CR) even if you are using Windows OS. – Juniar Jul 28 '17 at 13:50
  • 1
    Before installing maybe try (in vim) ':set fileformat=unix'. This worked for me in the Windows Subsystem for Linux (WSL). – Jay Killeen Mar 12 '18 at 01:23
  • @CMCDragonkai — the problem arises because Bash treats `then\r` as a command name, and `fi\r` as another, and then thinks that it has not seen the correct format for an `if …; then …; fi` statement — so it reports 'unexpected EOF'. – Jonathan Leffler May 01 '20 at 05:33
179

Another thing to check (just occured to me):

  • terminate bodies of single-line functions with semicolon

I.e. this innocent-looking snippet will cause the same error:

die () { test -n "$@" && echo "$@"; exit 1 }

To make the dumb parser happy:

die () { test -n "$@" && echo "$@"; exit 1; }
ulidtko
  • 14,740
  • 10
  • 56
  • 88
  • 7
    +1 Also applies to code snippets with brackets like so: [[ "$#" == 1 ]] && [[ "$arg" == [1,2,3,4] ]] && printf "%s\n" "blah" || { printf "%s\n" "blahblah"; usage; } ............ Note that semicolon inside the squiggly brackets, just after calling some previously defined function 'usage'. Forgetting that will get you the same syntax error: unexpected eof. – Cbhihe Jun 19 '15 at 08:45
  • 1
    you nailed it. Actually the simple thing is the `;` Every statement is being expected to end with `;` so put that at the end eg: `if [ -f ~/.git-completion.bash ]; then . ~/.git-completion.bash fi` will produce that error, whereas `if [ -f ~/.git-completion.bash ]; then . ~/.git-completion.bash; fi;` will not... notice the little semi-colons at the end, ie: after `.bash` and `fi`. – Emmanuel Mahuni Aug 27 '18 at 07:51
  • 2
    I had this in a script shared with me from a `zsh` user. The former does work in `zsh` but not in `sh` nor `bash`. Wish I was 4 people so I could give this 4 upvotes – Davos Jan 04 '19 at 00:41
73

i also just got this error message by using the wrong syntax in an if clause

  • else if (syntax error: unexpected end of file)
  • elif (correct syntax)

i debugged it by commenting bits out until it worked

marengaz
  • 1,639
  • 18
  • 28
37

an un-closed if => fi clause will raise this as well

tip: use trap to debug, if your script is huge...

e.g.

set -x
trap read debug
Salman Zafar
  • 3,844
  • 5
  • 20
  • 43
theRiley
  • 1,077
  • 13
  • 16
  • 2
    I exactly forgot the "fi"! Thanks :) If you could, for the benefit of everyone, elaborate a bit on your tip of using trap. – Neithan Max Oct 25 '17 at 21:38
  • 4
    sorry for the delay, my friend. 'the 'trap' command is a way to debug your scripts by esentially breaking after every line. a fuller discussion is here: https://stackoverflow.com/questions/9080431/how-execute-bash-script-line-by-line – theRiley Dec 13 '17 at 01:14
  • 2
    That was useful thanks a lot. Note that the `unexpected end of file` error will occur as soon as the `fi` is hit. – Stephane B. May 19 '18 at 19:53
  • Ah so, one should not write those set and trap commands into the actual script, as it says in that post you suggested might clarify your answer? You write it in the shell, and then call the script. Please do clarify, save everyone running round in circles. – markling Mar 20 '23 at 16:49
  • @Markling - I anticipate folks would take the traps out after they have debugged their script. – theRiley May 25 '23 at 06:14
  • That is, if they are advised well enough that they know what a trap is, and where and how they should put it! – markling May 25 '23 at 10:29
17

I got this answer from this similar problem on StackOverflow

Open the file in Vim and try

:set fileformat=unix

Convert eh line endings to unix endings and see if that solves the issue. If editing in Vim, enter the command :set fileformat=unix and save the file. Several other editors have the ability to convert line endings, such as Notepad++ or Atom

Thanks @lemongrassnginger

Jay Killeen
  • 2,832
  • 6
  • 39
  • 66
12

I had the problem when I wrote "if - fi" statement in one line:

if [ -f ~/.git-completion.bash ]; then . ~/.git-completion.bash fi

Write multiline solved my problem:

if [ -f ~/.git-completion.bash ]; then 
    . ~/.git-completion.bash
 fi
Salman Zafar
  • 3,844
  • 5
  • 20
  • 43
Sergey
  • 959
  • 8
  • 10
  • 2
    You can also keep it as one line like this: `if [ -f ~/.git-completion.bash ]; then . ~/.git-completion.bash; fi` (note the `;` near the end). – YorSubs Jan 29 '21 at 16:09
12

This was happening for me when I was trying to call a function using parens, e.g.

run() {
  echo hello
}

run()

should be:

run() {
  echo hello
}

run
Christian Scott
  • 893
  • 7
  • 19
8

So I found this post and the answers did not help me but i was able to figure out why it gave me the error. I had a

cat > temp.txt < EOF
some content
EOF

The issue was that i copied the above code to be in a function and inadvertently tabbed the code. Need to make sure the last EOF is not tabbed.

Rafael Urena
  • 111
  • 2
  • 3
  • 2
    This was exactly my case. I had `EOF` indented by four spaces and bash didn't parse it because of that. Removing spaces fixed the issue. – ᴍᴇʜᴏᴠ Nov 13 '16 at 12:56
7

on cygwin I needed:-

 export SHELLOPTS
 set -o igncr

in .bash_profile . This way I didn't need to run unix2dos

zzapper
  • 4,743
  • 5
  • 48
  • 45
5

FOR WINDOWS:

In my case, I was working on Windows OS and I got the same error while running autoconf.

  • I simply open configure.ac file with my NOTEPAD++ IDE.
  • Then I converted the File with EOL conversion into Windows (CR LF) as follows:

    EDIT -> EOL CONVERSION -> WINDOWS (CR LF)

Juniar
  • 1,269
  • 1
  • 15
  • 24
4

Missing a closing brace on a function definition will cause this error as I just discovered.

function whoIsAnIidiot() {
    echo "you are for forgetting the closing brace just below this line !"

Which of course should be like this...

function whoIsAnIidiot() {
    echo "not you for sure"
}
Mike
  • 59
  • 4
2

In my case, there is a redundant \ in the like following:

function foo() {
    python tools/run_net.py \
                           --cfg configs/Kinetics/X3D_8x8_R50.yaml \
                           NUM_GPUS 1 \
                           TRAIN.BATCH_SIZE 8 \
                           SOLVER.BASE_LR 0.0125 \
                           DATA.PATH_TO_DATA_DIR ./afs/kinetics400 \
                           DATA.PATH_PREFIX  ./afs/kinetics400  \  # Error
}

There is NOT a \ at the end of DATA.PATH_PREFIX ./afs/kinetics400

one
  • 2,205
  • 1
  • 15
  • 37
2

I was able to cut and paste your code into a file and it ran correctly. If you execute it like this it should work:

Your "file.sh":

#!/bin/bash
# june 2011

if [ $# -lt 3 -o $# -gt 3 ]; then
   echo "Error... Usage: $0 host database username"
   exit 0
fi

The command:

$ ./file.sh arg1 arg2 arg3

Note that "file.sh" must be executable:

$ chmod +x file.sh

You may be getting that error b/c of how you're doing input (w/ a pipe, carrot, etc.). You could also try splitting the condition into two:

if [ $# -lt 3 ] || [ $# -gt 3 ]; then
   echo "Error... Usage: $0 host database username"
   exit 0
fi

Or, since you're using bash, you could use built-in syntax:

if [[ $# -lt 3 || $# -gt 3 ]]; then
   echo "Error... Usage: $0 host database username"
   exit 0
fi

And, finally, you could of course just check if 3 arguments were given (clean, maintains POSIX shell compatibility):

if [ $# -ne 3 ]; then
   echo "Error... Usage: $0 host database username"
   exit 0
fi
aaronstacy
  • 6,189
  • 13
  • 59
  • 72
  • i still got the same error. im not exactly sure where the code goes wrong – markcruz Jun 16 '11 at 02:43
  • weird, i cut and pasted your code and it worked as expected. was there any more error output? a lot of time bash will list a line number. also, what system are you running? (Linux, MacOS, BSD, distro, etc) – aaronstacy Jun 16 '11 at 02:47
1

Apparently, some versions of the shell can also emit this message when the final line of your script lacks a newline.

tripleee
  • 175,061
  • 34
  • 275
  • 318
1

For those who don't have dos2unix installed (and don't want to install it):

Remove trailing \r character that causes this error:

sed -i 's/\r$//' filename

Details from this StackOverflow answer. This was really helpful. https://stackoverflow.com/a/32912867/7286223

0

Make sure the name of the directory in which the .sh file is present does not have a space character. e.g: Say if it is in a folder called 'New Folder', you're bound to come across the error that you've cited. Instead just name it as 'New_Folder'. I hope this helps.

0

In Ubuntu:

$ gedit ~/.profile

Then, File -> Save as and set end line to Unix/Linux

Neb
  • 2,270
  • 1
  • 12
  • 22
0

I know I am too late to the party. Hope this may help someone.

Check your .bashrc file. Perhaps rename or move it.

Discussion here: Unable to source a simple bash script

viggy28
  • 760
  • 1
  • 10
  • 21
0

For people using MacOS:

If you received a file with Windows format and wanted to run on MacOS and seeing this error, run these commands.

brew install dos2unix
sh <file.sh>
vmorusu
  • 936
  • 1
  • 15
  • 32
0

I just cut-and-pasted your example into a file; it ran fine under bash. I don't see any problems with it.

For good measure you may want to ensure it ends with a newline, though bash shouldn't care. (It runs for me both with and without the final newline.)

You'll sometimes see strange errors if you've accidentally embedded a control character in the file. Since it's a short script, try creating a new script by pasting it from your question here on StackOverflow, or by simply re-typing it.

What version of bash are you using? (bash --version)

Good luck!

Adam Liss
  • 47,594
  • 12
  • 108
  • 150
0

If the the script itself is valid and there are no syntax errors, then some possible causes could be:

  • Invalid end-of-lines (for example, \r\n instead of \n)
  • Presence of the byte order mark (BOM) at the beginning of the file

Both can be fixed using vim or vi.

To fix line endings open the file in vim and from the command mode type:

:set ff=unix

To remove the BOM use:

:set nobomb
ccpizza
  • 28,968
  • 18
  • 162
  • 169
0

If you're using vscode you can create a .editorconfig file and put this in it:

[*.sh]
end_of_line = cr

then save your bash files again, as far as I understood when you save a file vscode by default uses crlf as end of line to present line breaks.

Hirbod
  • 67
  • 11
0

I found @Juniar 's answer very helpful https://stackoverflow.com/a/56693268/5838310

Mine was originally set as Windows(CR LF) and reported error; when I changed it to Unix (LF), it worked!