19

I was making a base class so that all bindings for child will be set in base

I have done till this

abstract class BaseActivity2<B : ViewBinding?, T : BaseViewModel?> : AppCompatActivity() {
    private var viewBinding: B? = null
    private var baseViewModel: T? = null

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
    }
}

but am unable to get a way to bind view in oncreat() generally we bind layout in view binding as

binding = ActivityLoginBinding.inflate(layoutInflater)
        setContentView(binding.root)

but i am looking for generalized way in base activity

Mirza Ahmed Baig
  • 5,605
  • 3
  • 22
  • 39
  • Does this answer your question? [How using ViewBinding with an abstract base class](https://stackoverflow.com/questions/62407823/how-using-viewbinding-with-an-abstract-base-class) – Chetan Gupta Dec 06 '20 at 10:34

3 Answers3

24

You can declare a lambda property in the constructor to create the binding object

abstract class BaseActivity<B : ViewBinding>(val bindingFactory: (LayoutInflater) -> B) : AppCompatActivity() {
    private lateinit var binding: B

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        binding = bindingFactory(layoutInflater)
        setContentView(binding.root)
    }
}

You can also define binding as lazy property

private val binding: B by lazy { bindingFactory(layoutInflater) }

Then you need to override nothing in your activities

class MainActivity : BaseActivity<ActivityMainBinding>(ActivityMainBinding::inflate)
Sinner of the System
  • 2,558
  • 1
  • 8
  • 17
15

Other answer will also solve problem but I would like to do in a clean way.

My Base Class

abstract class BaseVMActivity<VM : ViewModel, B : ViewBinding> : BaseActivity() {

    lateinit var viewModel: VM
    lateinit var binding: B


    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        viewModel = ViewModelProvider(this, factory).get(getViewModelClass())
        binding = getViewBinding()
        setContentView(binding.root)
    }

    private fun getViewModelClass(): Class<VM> {
        val type = (javaClass.genericSuperclass as ParameterizedType).actualTypeArguments[0]
        return type as Class<VM>
    }

    abstract fun getViewBinding(): B

}

My activity:

class MainActivity : BaseVMActivity<AppViewModel, ActivityMainBinding>() {
    override fun getViewBinding() = ActivityMainBinding.inflate(layoutInflater)
   
}

Now I can directly access viewModel or binding:

fun dummy(){
        binding.bvReport.text = viewModel.getReportText()
    }
Mirza Ahmed Baig
  • 5,605
  • 3
  • 22
  • 39
6

It's cleaner to override binding object getter inside the child activity I think. So:

abstract class VBActivity<VB : ViewBinding> : AppCompatActivity() {
  protected abstract val binding: VB

  override fun onCreate(savedInstanceState: Bundle?) {
    super.onCreate(savedInstanceState)
    setContentView(binding.root)
  }
}

And lets say MainActivity will be something like:

class MainActivity : VBActivity<ActivityMainBinding>() {

  override val binding get() = ActivityMainBinding.inflate(layoutInflater)

}
Reza
  • 906
  • 2
  • 15
  • 29
  • if you want to extend MainActivity with different layout, how can i reach it? view binding can't do it. not prefer using view binding, i guess it – Abah Adilah Feb 14 '22 at 07:15