Using strstr inside a switch php

Question

I just cannot think of the code. I have waay too many if statments which I want to change to be a switch statement, but I cannot find of the logic.

At the moment I have:

if(strstr($var,'texttosearch'))
   echo 'string contains texttosearch';

if(strstr($var,'texttosearch1'))
   echo 'string contains texttosearch1';

if(strstr($var,'texttosearch2'))
   echo 'string contains texttosearc2h';

//etc etc...

But how can I achieve the same within a switch?

Actually `foreach` solution by `php-coder` is better to use `switch`. it will reduce line of codes. — jeni, Jul 14 '11 at 10:15

score 11 · Accepted Answer · answered Jul 14 '11 at 10:08

switch (true) {
  case strstr($var,'texttosearch'):
    echo 'string contains texttosearch';
    break;
  case strstr($var,'texttosearch1'):
    echo 'string contains texttosearch1';
    break;
  case strstr($var,'texttosearch2'):
    echo 'string contains texttosearc2h';
    break;
}

Note, that this is slightly different to your own solution, because the switch-statement will not test against the other cases, if an earlier already matches, but because you use separate ifs, instead if if-else your way always tests against every case.

score 11 · Answer 2 · answered Jul 14 '11 at 10:10

11

I think you can't achieve this with switch (more elegant than now) because it compare values but you want compare only part of values. Instead you may use loop:

$patterns = array('texttosearch', 'texttosearch1', 'texttosearch2');
foreach ($patterns as $pattern) {
    if (strstr($var, $pattern)) {
        echo "String contains '$pattern'\n";
    }
}

answered Jul 14 '11 at 10:10

Slava Semushin

14,904
7
53
69

1

Definitely +1. Definitely. I'd give you +2 if I could. – cwallenpoole Jul 14 '11 at 10:15
better answer to this case +1, but @KingCrunch snippet is interesting for realize a specific action. – Mike Castro Demaria Aug 16 '13 at 17:04

score 2 · Answer 3 · edited Jul 14 '11 at 10:10

2

You can do it the other way around:

switch(true) {
case strstr($var, "texttosearch"):
    // do stuff
    break;
case strstr($var, "texttosearch1"):
    // do other stuff
    break;
}

edited Jul 14 '11 at 10:10

Ólafur Waage

68,817
22
142
198

answered Jul 14 '11 at 10:07

Mads Ohm Larsen

3,315
3
20
22

@William Jones can you pls avoid such words in public, that to tech discussion. – jeni Jul 14 '11 at 10:13

Using strstr inside a switch php

3 Answers3

Linked