How to eliminate ALL line breaks in string?

Question

I have a need to get rid of all line breaks that appear in my strings (coming from db). I do it using code below:

value.Replace("\r\n", "").Replace("\n", "").Replace("\r", "")

I can see that there's at least one character acting like line ending that survived it. The char code is 8232.

It's very lame of me, but I must say this is the first time I have a pleasure of seeing this char. It's obvious that I can just replace this char directly, but I was thinking about extending my current approach (based on replacing combinations of "\r" and "\n") to something much more solid, so it would not only include the '8232' char but also all others not-found-by-me yet.

Do you have a bullet-proof approach for such a problem?

EDIT#1:

It seems to me that there are several possible solutions:

use Regex.Replace
remove all chars if it's IsSeparator or IsControl
replace with " " if it's IsWhiteSpace
create a list of all possible line endings ( "\r\n", "\r", "\n",LF ,VT, FF, CR, CR+LF, NEL, LS, PS) and just replace them with empty string. It's a lot of replaces.

I would say that the best results will be after applying 1st and 4th approaches but I cannot decide which will be faster. Which one do you think is the most complete one?

EDIT#2

I posted anwer below.

For what it's worth, the character you're running into is U+2028, 'LINE SEPARATOR'. http://www.fileformat.info/info/unicode/char/2028/index.htm — Joe White, Jul 19 '11 at 15:57
I have deleted my answer but what about the following:http://stackoverflow.com/questions/238002/replace-line-breaks-in-a-string-c — Massimiliano Peluso, Jul 19 '11 at 16:02
It just asks about line breaks, not about special cases of them. In the context of this old question, the answer is correct, because the OP obviously doesn't care about such special cases, otherwise he would have mentioned them. — Daniel Hilgarth, Jul 19 '11 at 16:03
thanks for the explanation I have never got -3 in less than 1 minute. is there a badge for that? :-))) — Massimiliano Peluso, Jul 19 '11 at 16:04

score 72 · Accepted Answer · edited Feb 23 '18 at 15:08

72

Below is the extension method solving my problem. LineSeparator and ParagraphEnding can be of course defined somewhere else, as static values etc.

public static string RemoveLineEndings(this string value)
{
    if(String.IsNullOrEmpty(value))
    {
        return value;
    }
    string lineSeparator = ((char) 0x2028).ToString();
    string paragraphSeparator = ((char)0x2029).ToString();

    return value.Replace("\r\n", string.Empty)
                .Replace("\n", string.Empty)
                .Replace("\r", string.Empty)
                .Replace(lineSeparator, string.Empty)
                .Replace(paragraphSeparator, string.Empty);
}

edited Feb 23 '18 at 15:08

MadDeveloper

796
11
20

answered Jul 20 '11 at 17:04

IamDeveloper

5,156
6
34
50

this miss only one offending char I have in my strings : \f Formfeed – maborg Mar 25 '13 at 13:33
I used it successfully to solve problems during csv file creation. Some strings in it were with line separators and it was a cause of incorrect lines arrangement. With the code above I solved the problem. – Sharunas Bielskis Dec 06 '16 at 16:05
This is great. Thank you +1 – Dan Beaulieu Feb 09 '17 at 22:42

score 25 · Answer 2 · answered Jul 19 '11 at 16:04

25

According to wikipedia, there are numerous line terminators you may need to handle (including this one you mention).

LF: Line Feed, U+000A
VT: Vertical Tab, U+000B
FF: Form Feed, U+000C
CR: Carriage Return, U+000D
CR+LF: CR (U+000D) followed by LF (U+000A)
NEL: Next Line, U+0085
LS: Line Separator, U+2028
PS: Paragraph Separator, U+2029

answered Jul 19 '11 at 16:04

Tremmors

2,906
17
13

19

In regex form: `Regex.Replace(str, @"[\u000A\u000B\u000C\u000D\u2028\u2029\u0085]+", String.Empty)` – mikebridge Mar 27 '15 at 05:30

score 13 · Answer 3 · answered Jul 19 '11 at 15:59

13

8232 (0x2028) and 8233 (0x2029) are the only other ones you might want to eliminate. See the documentation for char.IsSeparator.

answered Jul 19 '11 at 15:59

Ed Bayiates

11,060
4
43
62

Well, no -- what's "already implemented in the language" doesn't actually solve the original problem. Read the docs for char.IsSeparator -- it *won't* return true for the "normal" newline characters, because Unicode classifies those as "control characters". – Joe White Jul 19 '11 at 16:02
2

@Joe - yes, but I was showing the OP that there *is* an official list of what character points he wants to get rid of, and it's in the documentation. – Ed Bayiates Jul 19 '11 at 16:03
3

I think he meant just to look at the documentation, not to actually use `char.IsSeparator`. – Vladislav Zorov Jul 19 '11 at 16:04

csharptest.net · Answer 4 · 2011-07-19T20:11:59.480

11

Props to Yossarian on this one, I think he's right. Replace all whitespace with a single space:

data = Regex.Replace(data, @"\s+", " ");

edited Jul 19 '11 at 20:11

answered Jul 19 '11 at 18:23

csharptest.net

62,602
11
71
89

3

Uh... won't that insert spaces everywhere? As that not only matches all whitespace, it also matches the empty string. You'd want to use `"\s+"` instead. – JAB Jul 19 '11 at 19:55
1

Yes, `"\s*"` will match at every character, and insert a space after each one. Great if you're coding a spiffy Geocities site for 1995! – Steven Jul 19 '11 at 20:11

score 7 · Answer 5 · answered Jul 19 '11 at 16:10

7

I'd recommend removing ALL the whitespace (char.IsWhitespace), and replacing it with single space.. IsWhiteSpace takes care of all weird unicode whitespaces.

answered Jul 19 '11 at 16:10

nothrow

15,882
9
57
104

score 4 · Answer 6 · edited Feb 16 '15 at 10:19

4

Have you tried string.Replace(Environment.NewLine, "") ? That usually gets a lot of them for me.

edited Feb 16 '15 at 10:19

Mad Dog Tannen

7,129
5
31
55

answered Jul 19 '11 at 16:05

Josh

10,352
12
58
109

1

I've read somewhere here that it doesn't cover ALL situations. – IamDeveloper Jul 19 '11 at 16:08
1

it definitely doesn't cover ALL situations, just tested it. – IamDeveloper Jul 19 '11 at 17:52

score 4 · Answer 7 · answered Jul 19 '11 at 16:07

4

This is my first attempt at this, but I think this will do what you want....

var controlChars = from c in value.ToCharArray() where Char.IsControl(c) select c;
foreach (char c in controlChars)  
   value = value.Replace(c.ToString(), "");

Also, see this link for details on other methods you can use: Char Methods

answered Jul 19 '11 at 16:07

Robert Iver

711
2
9
14

1

Slightly shorter: `value = new string(value.Where(c => !char.IsControl(c)).ToArray())` – maxp Apr 13 '15 at 10:44

score 1 · Answer 8 · answered Jul 19 '11 at 16:06

Check out this link: http://msdn.microsoft.com/en-us/library/844skk0h.aspx

You wil lhave to play around and build a REGEX expression that works for you. But here's the skeleton...

static void Main(string[] args)
{

        StringBuilder txt = new StringBuilder();
        txt.Append("Hello \n\n\r\t\t");
        txt.Append( Convert.ToChar(8232));

        System.Console.WriteLine("Original: <" + txt.ToString() + ">");

        System.Console.WriteLine("Cleaned: <" + CleanInput(txt.ToString()) + ">");

        System.Console.Read();

    }

    static string CleanInput(string strIn)
    {
        // Replace invalid characters with empty strings.
        return Regex.Replace(strIn, @"[^\w\.@-]", ""); 
    }

I've tried all the other solutions and finally this is the only solution that working for me with : Regex.Replace(strIn, @"[^\w\.@-]", ""), thank you @BBC — Mimouni, Mar 02 '18 at 09:55

score 0 · Answer 9 · answered Feb 22 '17 at 14:51

0

If you've a string say "theString" then use the method Replace and give it the arguments shown below:

theString = theString.Replace(System.Environment.NewLine, "");

answered Feb 22 '17 at 14:51

Mahmoud Maghrabi

941
6
6

score 0 · Answer 10 · answered Aug 03 '18 at 12:42

Here are some quick solutions with .NET regex:

To remove any whitespace from a string: s = Regex.Replace(s, @"\s+", ""); (\s matches any Unicode whitespace chars)
To remove all whitespace BUT CR and LF: s = Regex.Replace(s, @"[\s-[\r\n]]+", ""); ([\s-[\r\n]] is a character class containing a subtraction construct, it matches any whitespace but CR and LF)
To remove any vertical whitespace, subtract \p{Zs} (any horizontal whitespace but tab) and \t (tab) from \s: s = Regex.Replace(s, @"[\s-[\p{Zs}\t]]+", "");.

Wrapping the last one into an extension method:

public static string RemoveLineEndings(this string value)
{
    return Regex.Replace(value, @"[\s-[\p{Zs}\t]]+", "");
}

See the regex demo.

score 0 · Answer 11 · answered Jul 19 '11 at 15:57

0

Assuming that 8232 is unicode, you can do this:

value.Replace("\u2028", string.Empty);

answered Jul 19 '11 at 15:57

Icemanind

47,519
50
171
296

score 0 · Answer 12 · answered Jul 20 '11 at 09:24

personally i'd go with

    public static String RemoveLineEndings(this String text)
    {
        StringBuilder newText = new StringBuilder();
        for (int i = 0; i < text.Length; i++)
        {
            if (!char.IsControl(text, i))
                newText.Append(text[i]);
        }
        return newText.ToString();
    }

How to eliminate ALL line breaks in string?

12 Answers12

Linked