@Html.HiddenFor does not work on Lists in ASP.NET MVC

Question

I'm using a model that contains a List as a property. I'm populating this list with items i grab from SQL Server. I want the List to be hidden in the view and passed to the POST action. Later on i may want to add more items to this List with jQuery which makes an array unsuitable for expansion later on. Normally you would use

@Html.HiddenFor(model => model.MyList)

to accomplish this functionality, but for some reason the List in POST is always null.

Very simple question, anyone know why MVC behaves like this?

Normally you wouldn't hide entire lists like that. What is your desired output in terms of ``s? — Cᴏʀʏ, Feb 21 '12 at 21:17
what does `MyList` contain? `HiddenFor` is only used for one input at a time. — Daniel A. White, Feb 21 '12 at 21:17
What Type is `Model.MyList`? You may need to perform some serialization/deserialization on your list manually. — Kyle Trauberman, Feb 21 '12 at 21:19
[http://stackoverflow.com/questions/4381871/what-is-the-difference-between-html-hidden-and-html-hiddenfor][1] Similar question. — Sanjeevi Subramani, Feb 17 '16 at 06:11
Similar Question: [Use of HiddenFor with intellisense](http://stackoverflow.com/questions/4381871/what-is-the-difference-between-html-hidden-and-html-hiddenfor) — Sanjeevi Subramani, Feb 17 '16 at 06:13

score 196 · Accepted Answer · edited Jul 31 '21 at 13:09

196

I've just come across this issue and solved it simply by doing the following:

@for(int i = 0; i < Model.ToGroups.Count; i++)
{
    @Html.HiddenFor(model => Model.ToGroups[i])
}

By using a for instead of a foreach the model binding will work correctly and pick up all of your hidden values in the list. Seems like the simplest way to solve this problem.

edited Jul 31 '21 at 13:09

Bron Thulke

388
3
19

answered Sep 29 '14 at 06:13

Daniel Mackay

2,298
1
15
19

8

Thanks - nice simple solution. Just a tiny mod needed though: The object's Id field needs to be referred to. So if the field is called RowId, then: `@Html.HiddenFor(model => Model.ToGroups[i].RowId)` – Krishna Gupta Nov 03 '15 at 16:11
4

worked for me, even for when I had multiple fields on the models in the collection. I.e. `@Html.EditorFor(model => Model.ToGroups[i].Id)` followed by `@Html.EditorFor(model => Model.ToGroups[i].Description)` on the next time - both in the for-loop. And the controller was able to map it to a list of the models with those fields. And to make sure none of it showed up on screen, just surround it in `
` – Don Cheadle Feb 12 '16 at 14:21
I ran into issues with this and still haven't figured out a solution. I had something like `@Html.DropdownListFor(m => m.Departments, new SelectList(Model.Lookup, "Code", "Name)` and in my loop I had `for(int i = 0; i < Model.Departments; i++) @Html.HiddenFor(model => Model.Departments[i])` but nothing was being passed in on POST. Am I doing something wrong? – Feb 17 '18 at 00:10
3

@user3186023 Answering a really old comment here, but maybe someone else will have the same issue: Change the `for`-loop to this: `for(int i = 0; i < Model.Departments.Count(); i++)` – Stian Mar 07 '18 at 09:04
Does anyone know if there is an alternative to this insidious hack that bloats all of the HTML? Why doesn't ASP.NET Core MVC just bind via the [Bind] format that's supplied in the post function? Surely there has to be a better way... ? – Peter Suwara Oct 15 '18 at 17:40
One very dummy reason is also that the properties were declared as fields, without { get; set; } ... It took me some time to figure this out in my case – Christos Monogios Apr 23 '20 at 07:40

score 29 · Answer 2 · answered Feb 21 '12 at 21:24

29

HiddenFor is not like a DisplayFor or EditorFor. It won't work with collections, only single values.

You can use the Serialize HTML helper available in the MVC Futures project to serialize an object to a Hidden field, or you will have to write the code yourself. A better solution is to simply serialize an ID of some sort and re-get the data from the database on postback.

answered Feb 21 '12 at 21:24

Erik Funkenbusch

92,674
28
195
291

Do you have an example? I tried this and it failed to bind to the ViewModel value when the form was submitted. – Alan Macdonald Sep 03 '13 at 10:50
@AlanMacdonald - if something fails to bind, it's because your naming is not correct, more than likely because you used a foreach instead of a for with indexer. Or maybe you didn't use the proper attributes in the binding. See http://weblogs.asp.net/shijuvarghese/archive/2010/03/06/persisting-model-state-in-asp-net-mvc-using-html-serialize.aspx – Erik Funkenbusch Sep 03 '13 at 13:52
Thanks. Actually when I tried it is was literally @Html.Serialize("Model.ModelIDs", Model.ModelIDs) where Model was my ViewModel and it had a ModelIDs int array property. So there were no loops or anything. When the form was submitted the ModelIDs were always null in the bound ViewModel. – Alan Macdonald Sep 03 '13 at 15:52
@AlanMacdonald - You don't include "Model" in the name. – Erik Funkenbusch Sep 03 '13 at 18:06

Mark Rhodes · Answer 3 · 2014-01-15T15:45:05.130

19

It's a bit of a hack, but if @Html.EditorFor or @Html.DisplayFor work for your list, if you want to make sure it's sent on the post request but not visible, you could just style it to using display: none; to hide it instead, e.g:

<div style="display: none;">@Html.EditorFor(model => model.MyList)</div>

edited Jan 15 '14 at 15:45

answered Jan 15 '14 at 15:32

Mark Rhodes

10,049
4
48
51

This does not save the value in the model on post of the request. – nldev Jun 07 '16 at 17:26
If .EditorFor is set up to work correctly, then this should work too I believe. – Mark Rhodes Jun 09 '16 at 20:17

score 13 · Answer 4 · answered Nov 25 '15 at 22:37

What about using Newtonsoft to deserialize the object into a json string and then insert that into your Hidden field e.g. (Model.DataResponse.Entity.Commission is a List of simple "CommissionRange" objects as you'll see in the JSON)

@using (Ajax.BeginForm("Settings", "AffiliateProgram", Model.DataResponse, new AjaxOptions { UpdateTargetId = "result" }))
   {
      string commissionJson = JsonConvert.SerializeObject(Model.DataResponse.Entity.Commission);
      @Html.HiddenFor(data => data.DataResponse.Entity.Guid)
      @Html.Hidden("DataResponse_Entity_Commission", commissionJson)
      [Rest of my form]
   }

Renders as:

<input id="DataResponse_Entity_Commission" name="DataResponse_Entity_Commission" type="hidden" value="[{"RangeStart":0,"RangeEnd":0,"CommissionPercent":2.00000},{"RangeStart":1,"RangeEnd":2,"CommissionPercent":3.00000},{"RangeStart":2,"RangeEnd":0,"CommissionPercent":2.00000},{"RangeStart":3,"RangeEnd":2,"CommissionPercent":1.00000},{"RangeStart":15,"RangeEnd":10,"CommissionPercent":5.00000}]">

In my case I do some JS stuff to edit the json in the hidden field before posting back

In my controller I then use Newtonsoft again to deserialize:

string jsonCommissionRange = Request.Form["DataResponse_Entity_Commission"];
List<CommissionRange> commissionRange = JsonConvert.DeserializeObject<List<CommissionRange>>(jsonCommissionRange);

This worked for me. I thought it was much cleaner that the accepted solution. — e-on, Jan 18 '17 at 20:15

score 6 · Answer 5 · answered Feb 21 '12 at 21:22

Html.HiddenFor is designed for only one value. You will need to serialize your list in some way before creating the hidden field.

For example, if your list is of type string, you could join the list into a comma separated list, then split the list after post back in your controller.

score 4 · Answer 6 · edited Oct 09 '15 at 13:30

I've just found out (after a couple of hours of trying to figure out why model values weren't going back to the controller) that hidden for should follow the EditorFor.

Unless I am doing something else wrong this is what I found. I will not make the mistake again.

In the context of a Model that contains a list of another class.

This will NOT work:

        @{
            for (int i = 0; i < Model.Categories.Count; i++)
            {
                <tr>
                    <td>
                        @Html.HiddenFor(modelItem => Model.Categories[i].Id)
                        @Html.HiddenFor(modelItem => Model.Categories[i].ProductCategoryId)
                        @Html.HiddenFor(modelItem => Model.Categories[i].CategoryName)                            
                        @Html.DisplayFor(modelItem => Model.Categories[i].CategoryName)                            
                    </td>
                    <td>
                        @Html.HiddenFor(modelItem => Model.Categories[i].DailyPurchaseLimit)                                                        
                        @Html.EditorFor(modelItem => Model.Categories[i].DailyPurchaseLimit)
                        @Html.ValidationMessageFor(modelItem => Model.Categories[i].DailyPurchaseLimit)
                    </td>
                    <td style="text-align: center">
                        @Html.HiddenFor(modelItem => Model.Categories[i].IsSelected)                            
                        @Html.EditorFor(modelItem => Model.Categories[i].IsSelected)
                    </td>
                </tr>
            }
        }

Where as this WILL......

            for (int i = 0; i < Model.Categories.Count; i++)
            {
                <tr>
                    <td>
                        @Html.HiddenFor(modelItem => Model.Categories[i].Id)
                        @Html.HiddenFor(modelItem => Model.Categories[i].ProductCategoryId)
                        @Html.HiddenFor(modelItem => Model.Categories[i].CategoryName)                            
                        @Html.DisplayFor(modelItem => Model.Categories[i].CategoryName)                            
                    </td>
                    <td>
                        @Html.EditorFor(modelItem => Model.Categories[i].DailyPurchaseLimit)
                        @Html.HiddenFor(modelItem => Model.Categories[i].DailyPurchaseLimit)                            
                        @Html.ValidationMessageFor(modelItem => Model.Categories[i].DailyPurchaseLimit)
                    </td>
                    <td style="text-align: center">
                        @Html.EditorFor(modelItem => Model.Categories[i].IsSelected)
                        @Html.HiddenFor(modelItem => Model.Categories[i].IsSelected)                            
                    </td>
                </tr>
            }

score 3 · Answer 7 · edited May 23 '17 at 10:31

3

You can take a look on this solution.

Put only HiddenFor inside the EditorTemplate.

And in your View put this: @Html.EditorFor(model => model.MyList)

It should works.

edited May 23 '17 at 10:31

Community

1
1

answered Nov 15 '12 at 08:40

Wilfart Benjamin

201
2
4

score 3 · Answer 8 · edited Nov 23 '17 at 09:29

3

Faced the same issue. Without for loop, it only posted the first element of the list. After iterating through for loop, it can keep full list and post successfully.

 @if (Model.MyList!= null)
    {
    for (int i = 0; i < Model.MyList.Count; i++)
      {
        @Html.HiddenFor(x => x.MyList[i])
      }
    }

edited Nov 23 '17 at 09:29

ntg

12,950
7
74
95

answered Nov 23 '17 at 08:55

Keerthi

525
8
14

score 3 · Answer 9 · answered Feb 21 '12 at 21:52

I started digging through the source code for HiddenFor, and I think the roadblock you're seeing is that your complex object MyList is not implicitly convertible to type string, so the framework treats your Model value as null and renders the value attribute empty.

score 2 · Answer 10 · answered Mar 16 '18 at 19:30

2

Another option would be:

<input type="hidden" value=@(string.Join(",", Model.MyList)) />

answered Mar 16 '18 at 19:30

Tiago B

1,937
14
34

This was my first idea too. But I had a view model, that expected an int[] for the MyList field and comma separated string is not parsed into an array by the MVC binding mechanism. – Tadej Mali Apr 19 '19 at 08:01

score 2 · Answer 11 · edited Jul 31 '19 at 13:45

2

The foreach loop instead of a for loop might be a slightly cleaner solution.

@foreach(var item in Model.ToGroups)
{
    @Html.HiddenFor(model => item)
}

edited Jul 31 '19 at 13:45

Lauren Rutledge

1,195
5
18
27

answered Jul 31 '19 at 12:52

Sebastian

21
1

score 1 · Answer 12 · answered Jun 24 '14 at 20:43

1

Another possible way to fix this would be to give each object in your List an ID, then use @Html.DropDownListFor(model => model.IDs) and populate an array which holds the IDs.

answered Jun 24 '14 at 20:43

deckeresq

332
2
14

score 1 · Answer 13 · edited Oct 03 '17 at 14:30

maybe late, but i created extension method for hidden fields from collection (with simple data type items):

So here it is:

/// <summary>
/// Returns an HTML hidden input element for each item in the object's property (collection) that is represented by the specified expression.
/// </summary>
public static IHtmlString HiddenForCollection<TModel, TProperty>(this HtmlHelper<TModel> html, Expression<Func<TModel, TProperty>> expression) where TProperty : ICollection
{
    var model = html.ViewData.Model;
    var property = model != null
                ? expression.Compile().Invoke(model)
                : default(TProperty);

    var result = new StringBuilder();
    if (property != null && property.Count > 0)
    {
        for(int i = 0; i < property.Count; i++)
        {
            var modelExp = expression.Parameters.First();
            var propertyExp = expression.Body;
            var itemExp = Expression.ArrayIndex(propertyExp, Expression.Constant(i));

            var itemExpression = Expression.Lambda<Func<TModel, object>>(itemExp, modelExp);

            result.AppendLine(html.HiddenFor(itemExpression).ToString());
        }
    }

    return new MvcHtmlString(result.ToString());
}

Usage is as simple as:

@Html.HiddenForCollection(m => m.MyList)

score 0 · Answer 14 · answered Jun 10 '22 at 18:51

Adding to this answer, I had a Model with various properties, some of which were IEnumerables. What I did was to serialize it in a variable in the view with:

@{
    var serializedObject = JsonSerializer.Serialize(Model);
}

And then, put that string into a Hidden element (since HiddenFor is intended for a single value from a Model) like this:

@Html.Hidden("serialized", @serializedObject)

And finally, in the controller, I could deserialize it with

JsonSerializer.Deserialize<MyType>(Request.Form["serialized"])

@Html.HiddenFor does not work on Lists in ASP.NET MVC

14 Answers14

Linked

Related