21

i am new to regex. I am trying to parse all contents inside curly brackets in a string. I looked up this post as a reference and did exactly as one of the answers suggest, however the result is unexpected.

Here is what i did

var abc = "test/abcd{string1}test{string2}test" //any string
var regex = /{(.+?)}/
regex.exec(abc) // i got ["{string1}", "string1"]
             //where i am expecting ["string1", "string2"]

i think i am missing something, what am i doing wrong?

update

i was able to get it with /g for a global search

var regex = /{(.*?)}/g
abc.match(regex) //gives ["{string1}", "{string2}"]

how can i get the string w/o brackets?

Community
  • 1
  • 1
MengQi Han
  • 310
  • 1
  • 3
  • 9

6 Answers6

32
"test/abcd{string1}test{string2}test".match(/[^{}]+(?=\})/g)

produces

["string1", "string2"]

It assumes that every } has a corresponding { before it and {...} sections do not nest. It will also not capture the content of empty {} sections.

Mike Samuel
  • 118,113
  • 30
  • 216
  • 245
3
var abc = "test/abcd{string1}test{string2}test" //any string
var regex = /{(.+?)}/g
var matches;

while(matches = regex.exec(abc))
    console.log(matches);
ZER0
  • 24,846
  • 5
  • 51
  • 54
2

Try this:

var abc = "test/abcd{string1}test{string2}test" //any string
var regex = /{(.+?)}/g //g flag so the regex is global
abc.match(regex) //find every match

a good place to read about Regex in javascript is here, and a nice place to test is here

good luck!

nicosantangelo
  • 13,216
  • 3
  • 33
  • 47
  • I don't think g would make a difference here. It is not getting the second match (string2) because it is calling exec only once. – Kash Mar 20 '12 at 18:14
  • @Kash you're right, but I called match, and without the g, it will return `["{string1}", "string1"]` – nicosantangelo Mar 20 '12 at 18:20
1

try this for file

const fs = require('fs');

fs.readFile('logs.txt', function(err, data) {
if(err) throw err;
const paragraph = "'" + data + "'";
const regex = /\d+\<;>\S+\<;>(\d+)\<;/g;
const found = paragraph.match(regex);

console.log(found);
})
1

This result:

["{string1}", "string1"]

is showing you that for the first match, the entire regex matched "{string1}" and the first capturing parentheses matched "string1".

If you want to get all matches and see all capturing parens of each match, you can use the "g" flag and loop through, calling exec() multiple times like this:

var abc = "test/abcd{string1}test{string2}test"; //any string
var regex = /{(.+?)}/g;
var match, results = [];
while (match = regex.exec(abc)) {
    results.push(match[1]);   // save first captured parens sub-match into results array
}

// results == ["string1", "string2"]

You can see it work here: http://jsfiddle.net/jfriend00/sapfm/

jfriend00
  • 683,504
  • 96
  • 985
  • 979
  • assignment in a condition... not my cup of tea. – jbabey Mar 20 '12 at 18:18
  • It's an efficient way to do this type of loop and somewhat common for this exact purpose. I would generally avoid it too, except in this type of case. You can take a couple more lines of code to accomplish the same thing without it if you want. – jfriend00 Mar 20 '12 at 18:20
  • thanks for the explanation, i was wondering why the same string appeared twice. thank you! – MengQi Han Mar 20 '12 at 18:23
1

Nothing wrong. But you'll need to look at your capturing groups (the second element in the array) to get the content you wanted (you can ignore the first). To get all occurences, it's not enough to run exec once, you'll need to loop over the results using match.

Edit: nevermind that, afaik you can't access capturing groups with match. A simpler solution would be using a positive lookahead, as Mike Samuel suggested.

Community
  • 1
  • 1
mgibsonbr
  • 21,755
  • 7
  • 70
  • 112