"Auto Layout still required after executing -layoutSubviews" with UITableViewCell subclass

Question

Using XCode 4.5 and iOS 6, I'm developing an app with a simple table view with custom cells. I've done this a hundred times in iOS 5 and below, but for some reason the new autoLayout system is giving me a lot of trouble.

I setup my table view and prototype cell in IB, added subviews and wired them up as IBOutlets then setup my delegate and dataSource. However now whenever the first cell is fetched from cellForRowAtIndexPath, I get the following error:

*** Assertion failure in -[ShopCell layoutSublayersOfLayer:], /SourceCache/UIKit_Sim/UIKit-2372/UIView.m:5776

*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Auto Layout still required after executing -layoutSubviews. ShopCell's implementation of -layoutSubviews needs to call super.'

I haven't implemented a -layoutSubviews method in my subclassed cell (ShopCell), and even when I try to do that and add the super call as it suggests I still get the same error. If I remove the subviews from the cell in IB, and change it to a standard UITableViewCell, everything works as expected, though of course I'm left with no data in my cells.

I'm almost certain that there's something simple I'm missing, but can't find any documentation or guides to suggest what I've done wrong. Any help would be appreciated.

Edit: Just tried changing it to a UITableViewCell in IB and leaving all the subviews in place, still the same error.

Try `lldb [[UIWindow keyWindow] _autoLayoutTrace]` at debugger area if automatic layout is used. — A-Live, Sep 26 '12 at 22:06
Are you using UIView for the custom cell instead of UITableViewCell ? I had the same problem. I had UIView for the custom cell and was adding sub views to that. Changed to UITableViewCell and it worked. — , Sep 28 '12 at 06:17
Hey mike, how are you defining the outlets? Are they properties in your implementation file in a class extension? — kocodude, Oct 04 '12 at 21:01
@A-Live Whenever I try to use that method I get an error in the debugger....is this method still valid? Edit: Nevermind, it is a lowercase l in autolayout. — borrrden, Oct 18 '12 at 02:30
uncheck the autoLayout box in inspector then clean and run. it will surly work. — Nico, Dec 16 '13 at 08:45
I had the same problem and fought with it for a while. user1705389's solution helped me. For me it happened on a table view footer which was originally a cell, and I forgot to change the cell's superclass from UITableViewCell to simply UIView. — ShayDavidson, Feb 11 '14 at 15:18

score 57 · Answer 1 · answered Sep 27 '12 at 22:42

I encountered the same problem while manually adding constraints in code. In code, I was doing the following:

{
    [self setTranslatesAutoresizingMaskIntoConstraints:YES];
    [self addSubview:someView];
    [self addSubview:someOtherView];
    [self addConstraint:...];
}

Hypothesis

From what I can tell, the issue is that when you disable translatesAutoresizingMaskIntoConstraints, UITableViewCell starts to use Auto Layout and naturally fails because the underlying implementation of layoutSublayersForLayer does not call super. Someone with Hopper or some other tool can confirm this. Since you're using IB you're probably wondering why this is an issue... and that's because using IB automatically disables translatesAutoresizingMaskIntoConstraints for views that it adds constraints to (it will automatically add a width and height constraint in their place).

Solution

My solution was to move everything to the contentView.

{
   [self.contentView addSubview:someView];
   [self.contentView addSubview:someOtherView];
   [self.contentView addConstraint:...];
}

I'm not 100% sure if this will work in Interface Builder, but if you push everything off of your cell (assuming that you have something directly on it) then it should work. Hope this helps you!

I also needed to add `subview.translatesAutoresizingMaskIntoConstraints = NO'` on each subview I was adding to the contentView. — Jay Peyer, Oct 24 '12 at 19:19
This worked for me. Also, make sure you do **not** call `self.contentView.translatesAutoresizingMaskIntoConstraints = NO` for the `UITableViewCell`. — Maurizio, Apr 19 '13 at 15:36

Carl Lindberg · Answer 2 · 2013-10-10T03:36:23.860

53

Apparently, UITableViewCell's layoutSubviews implementation does not call super, which is a problem with auto layout. I'd be interested to see if dropping the below category into projects fixes things. It helped in a test project.

#import <objc/runtime.h>
#import <objc/message.h>

@implementation UITableViewCell (FixUITableViewCellAutolayoutIHope)

+ (void)load
{
    Method existing = class_getInstanceMethod(self, @selector(layoutSubviews));
    Method new = class_getInstanceMethod(self, @selector(_autolayout_replacementLayoutSubviews));

    method_exchangeImplementations(existing, new);
}

- (void)_autolayout_replacementLayoutSubviews
{
    [super layoutSubviews];
    [self _autolayout_replacementLayoutSubviews]; // not recursive due to method swizzling
    [super layoutSubviews];
}

@end

I might add the problem showed up for me when using a backgroundView on the table cell, as that gets added as a subview to the cell (whereas most subviews should be added to the table cell's contentView, which should usually work better).

Note: It appears this bug is fixed in iOS7; I was able to remove this code, or at least add a runtime check so that it's only done if running on iOS6.

edited Oct 10 '13 at 03:36

answered Oct 17 '12 at 18:51

Carl Lindberg

2,902
18
22

The odd thing is that it works fine with a plain UITableViewCell for me, just not for a subclass... – borrrden Oct 18 '12 at 02:09
You'd think that, but all I have is an init method, nothing else ><. I've never overriden layoutSubviews in my life haha. I think the problem is the custom view that UITableViewCell uses as its root view can't use auto layout because it overrides layoutSubviews (so when you try to add constraints to the root view, it will fail) – borrrden Oct 18 '12 at 05:29
Interesting -- because it did work with a subclass here. But adding your custom views/constraints to the contentView is almost always the way to go, even without auto layout. – Carl Lindberg Oct 18 '12 at 13:34
It also worked for me on a subclass after I switched the constraints to the content view instead, just to be clear. – borrrden Oct 18 '12 at 14:49
6

I had to create such a category on `UITableView` for the same reason (iOS 6.1 b1) – Joshua J. McKinnon Nov 28 '12 at 07:13
This works for UICollectionView too if you want to layout the section headers with auto layout after the cell has been dequeued. – Jano Dec 09 '13 at 11:08
The weird thing for me is that auto layout is disabled from in my Storyboard: http://stackoverflow.com/questions/21842987/uitableviewcell-subclass-layout-messed-up-in-autolayout-disabled-storyboard – Rivera Feb 18 '14 at 02:04
This did not work for me. At risk of being marked duplicate, is this the same or a different problem? http://pastebin.com/eG2mFgU5 (UITableViewCell subclass with UITextView) – William Entriken Mar 27 '14 at 03:13
5

Is there a similar fix for TableHeaderView as the problem still exists in ios 7 ? – Softlion Apr 27 '14 at 08:52
1

This works great. I encountered this issue when I attempted to center a UIVIew subview in a UITableView. Even in iOS 7 the assertion occurs. But it doesn't occur in iOS 8, so they must have addressed the bug. – Jordan H Jul 27 '14 at 05:00
i'm trying to achieve the same thing but on a private class on google maps sdk with no luck.. see [here](http://stackoverflow.com/q/26258071/766570) – abbood Oct 09 '14 at 05:43
You are a God! Same problem IOS 7.1 with UINavigationBar – MCMatan Feb 26 '15 at 10:03

Arnaud · Answer 3 · 2013-02-28T15:56:26.720

33

I had the same bug for few months. But I found what was the problem.

When I create an IB file, a UIView is already added. If you use this view, the app doesn't crash when auto layout is disabled (but there are other issues). When you use auto layout, you have to select the right view in the Object Library : UITableViewCell.

In fact, you should always use this item because all subviews are added to the contentView of the UITableViewCell.

That's all. All will be fine.

edited Feb 28 '13 at 15:56

answered Feb 28 '13 at 15:45

Arnaud

539
6
14

This should not be the accepted answer because the question is not about an implementation using IB, and because this problem can happen when you're not using IB. If you're doing your views programmatically, @PhilLoden's answer is more viable. – Eric Oct 02 '14 at 18:30
I didn't understand the answer. can someone explain more clearly? thanks – hasan Dec 18 '14 at 18:52
I think I have that right. is it enough to check class att. in the identity inspector in interface builder? or the that been added was of another type and class att. has been updated later? does that also cause the problem? – hasan Dec 18 '14 at 18:56
@hasan83 You can actually return the cell. A UITableViewCell is basically a UIView with a reuse identifier. – Arnaud Dec 19 '14 at 09:30

score 17 · Answer 4 · answered Dec 05 '14 at 09:56

17

I had same trouble with custom UITableViewHeaderFooterView + xib.

I saw some answers here, but I found what implementation -layoutSubviews in my custom footer view class fixes issue:

-(void)layoutSubviews
{
    [super layoutSubviews];
    [self layoutIfNeeded]; // this line is key
}

answered Dec 05 '14 at 09:56

Sound Blaster

4,778
1
24
32

1

Beware that this can result in endless loop and finally **EXC_BAD_ACCESS** **KERN_PROTECTION_FAILURE** – mbi Jan 26 '16 at 18:43
@mbi Calling `layoutIfNeeded ` of `self` cannot trigger `layoutSubviews`, because nothing can mark `self` as needed to be relayed here. If this situation has arisen, it is a bug in the custom layout code. – Sound Blaster Apr 02 '23 at 13:40

score 15 · Answer 5 · answered May 30 '13 at 06:09

15

I was seeing this as a result of modifying constraints in my implementation of layoutSubviews. Moving the call to super from the beginning to the end of the method fixed the problem.

answered May 30 '13 at 06:09

Phil Loden

1,394
1
15
15

This worked for me. I have a custom UICollectionViewCell that I'm formatting in layoutSubviews. Anyone know why this solution works though? – STANGMMX Sep 13 '13 at 15:12
@STANGMMX, the answer by A'sa Dickens explains why. – Fábio Oliveira Jan 07 '14 at 13:08

score 15 · Answer 6 · answered Oct 17 '14 at 17:55

15

Had the same problem in iOS 7 (iOS 8 seems to fix). The solution for me was to call [self.view layoutIfNeeded] at the end of my viewDidLayoutSubviews method.

answered Oct 17 '14 at 17:55

Keller

17,051
8
55
72

Thank you. It helps me.I met this problem yesterday(on iOS 7). it helps for iOS 7. – Alexander Nov 26 '14 at 17:29
@MaciejSwic see my answer at the top. – Sound Blaster Dec 05 '14 at 09:56
This worked for me! Using iOS 7.1 with Swift. I was removing and adding a constraint on viewDidLayoutSubviews. I removed the super call and it still wasn't working, but this solution did the trick! give this dinosaur a leaf! :) – jomafer Mar 05 '15 at 08:15
Worked for me too using iOS 7.1! – fdlr May 19 '15 at 16:15

score 14 · Answer 7 · answered Apr 05 '13 at 22:06

14

I had the same issue. The problem was in the way I was creating the cell Xib. I created a Xib like normal and just changed the type of the default "UIView" to my custom UITableViewCell class. The correct way to is to first delete the default view and then drag the table view cell object onto the xib. More details here : http://allplayers.github.io/blog/2012/11/18/Custom-UITableViewCell-With-NIB/

answered Apr 05 '13 at 22:06

Trunal Bhanse

1,651
1
17
27

1

Perfect insight! I'd take ages to realize that, specially because my apps wouldn't crash if I user a UIView with AutoLayout disabled. – Guilherme Oct 03 '13 at 21:02
Super! see also @Arnaud respone below – Lubbo Oct 25 '13 at 10:44

score 7 · Answer 8 · answered Feb 14 '13 at 11:11

7

I resolved the issue by turning off "Autolayout" for all the subviews of my custom Table View Cell.

In the xib for a custom cell, select a subview and uncheck File Inspector > Interface Builder Document > Use Autolayout

answered Feb 14 '13 at 11:11

Johno

1,959
1
15
15

4

I did the same. Not really a solution though if you want to use the autolayout though – ajmccall Feb 20 '13 at 14:43

score 7 · Answer 9 · answered Nov 11 '14 at 12:59

I had a similar problem not on UITableViewCell but rather on UITableView itself. Because it is the first result in Google I'll post it here. It turned out that viewForHeaderInSection was the problem. I created a UITableViewHeaderFooterView and set translatesAutoresizingMaskIntoConstraints to NO. Now here comes the interesting part:

iOS 7:

// don't do this on iOS 7
sectionHeader.translatesAutoresizingMaskIntoConstraints = NO;

If I do this the app crashes with

Auto Layout still required after executing -layoutSubviews. UITableView's implementation of -layoutSubviews needs to call super.

OK, I thought you can't use auto layout on a table view header and only on the subviews. But that's not the full truth as you see it later. To sum up: Don't disable auto resizing mask for the header on iOS 7. Otherwise it's working fine.

iOS 8:

// you have to do this, otherwise you get an auto layout error
sectionHeader.translatesAutoresizingMaskIntoConstraints = NO;

If I wouldn't use this I'd get the following output:

Unable to simultaneously satisfy constraints.

For iOS 8 you have to disable auto resizing mask for the header.

Don't know why it behaves in this way but it seems that Apple did fix some things in iOS 8 and auto layout is working differently on iOS 7 and iOS 8.

Mate you just save my day! – Marcin Małysz Apr 10 '15 at 09:51 — Marcin Małysz, Apr 10 '15 at 09:51

Maksymilian Wojakowski · Answer 10 · 2014-01-30T21:46:11.480

As someone above has already stated, when you create a view for use in a UITableView, you have to delete the view created by default and drag a UITableViewCell or UITableViewHeaderFooterView as the root view. However, there is a way to fix the XIB in case you had missed that part. You have to open the XIB file in a text editor and in the root tag and its direct child add/change the attribute translatesAutoresizingMaskIntoConstraints to YES, for example

<view contentMode="scaleToFill" horizontalHuggingPriority="1000" id="1" translatesAutoresizingMaskIntoConstraints="YES" customClass="MXWCollapsibleTableHeaderView">

score 2 · Answer 11 · answered Feb 28 '13 at 17:00

I am encountering this and it seems that it is related to UITableViewCell subclasses as prototype cells that specifically have other custom UIView subclasses added to them. I stress the 'custom' here because I have been successful with cells that just have UIKit children, but it falls over when trying to build the constraints for views I have created bespoke, throwing the error stated in the authors question.

I have had to separate my cells into independent nibs that don't use AutoLayout.

Let's hope Apple clean up this mess.

score 2 · Answer 12 · answered May 28 '13 at 15:12

2

Add your subviews to the contentView of the cell instead of the cell itself. So instead of:

[self addSubview:someView];

you must use

[self.contentView addSubview:someView];

answered May 28 '13 at 15:12

Christian Aberger

315
3
4

score 1 · Answer 13 · answered Feb 25 '13 at 15:59

1

I encountered this one because I had initially added a UIView instead of a UITableViewCell to a xib file.

answered Feb 25 '13 at 15:59

mjmdavis

2,583
3
19
16

score 1 · Answer 14 · answered Mar 22 '13 at 03:57

1

I eliminated this error by uncoupling the backgroundView connector from my background UIImageView and accessoryView connector from my UIButton customisations. I suspect that these were not meant to be used the way I was using them.

answered Mar 22 '13 at 03:57

Owen Godfrey

3,361
2
22
18

score 1 · Answer 15 · answered Apr 16 '13 at 23:06

I had run into this issue first time today. Up until now I had some various experience in using prototype UITableViewCell subclasses but never ran into this issue. What was different about the cell I was working with was that I had an IBOutlet to the -backgroundView which I was using to color the cell. I found that if I created a new property and still added a fresh UIView which stretched the span of the entire cell, this assertion went away. To verify this was the cause, I went back to attaching this view to the backgroundView outlet and the assertion reappeared. So far, no other issues using AutoLayout in a subclassed prototype UITableViewCell since I've made this change.

score 1 · Answer 16 · answered Jul 28 '14 at 14:26

I didn't get any proper solution for this issue but you can fix it by using frames and not setting translatesAutoresizingMaskIntoConstraints property to No (by default its yes, so don't set it)

CGRect headerViewFrame = CGRectMake(0,0,320,60); //Frame for your header/footer view
UIView *tableHeaderView = [[UIView alloc] initWithFrame:headerViewFrame];
tableHeaderView.translatesAutoresizingMaskIntoConstraints = Yes; //Or don't set it at all
[self.tableView setTableHeaderView:tableHeaderView];

score 0 · Answer 17 · answered Oct 03 '12 at 18:13

I have been experiencing the same thing. It turned out that if you programmatically add a subview from your ShopCell .xib/storyboard, that uses auto layout, as a subview to another view, that exception might be thrown, depending on how your constraints are configured. My guess is that the constraints created in IB is what creates the troubles when programmatically adding a view as a subview, since it's then maintaing constraints from viewA --> viewB meanwhile you might add viewB as a subview of viewC. You got it (that sentence is even confusing myself)?

In my situation - since it was very simple views that caused the problem - I created the views programmatically and not in IB. That solved it. You might extract those views to other xib files and disable auto layout for those. I guess that'd work.

score 0 · Answer 18 · answered Sep 18 '13 at 23:11

0

In some situations, this solves the layout problem easily (depending on your layout). Inside you UITableView subclass, in either awakeFromNib or init, set the autoresizing mask:

self.contentView.autoresizingMask = UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight;

By defaut it is set to UIViewAutoresizingNone

answered Sep 18 '13 at 23:11

Arie Litovsky

4,893
2
35
40

This solved the problem I was facing. I am using auto-layout within a table cell combined with `[tableViewCell.contentView systemLayoutSizeFittingSize:UILayoutFittingCompressedSize].height` to get the height, which I then use in `heightForRowAtIndexPath`. – NathanAldenSr Dec 31 '13 at 19:47

score 0 · Answer 19 · answered Sep 23 '13 at 09:07

In my case,

The referenced UIImageView for the auto layout for UITableView is assigned to backgroundView of the UITableView.

self.tableView.backgroundView = self.tableBackgroundImageView;

So, I removed UIImageView for backgroundView from the UIView(Root view) and reset(remove) all auto layout reference to that UIImageView. I placed that UIImageView for background at the outside from the UIView(root view). And then assign to the backgroundView of the UITableView in code.

Then fixed.

score 0 · Answer 20 · answered Jul 05 '14 at 11:34

0

I have found the solution.

In my case, I created cell's view in storyboard (with auto layout enabled) and I defined the custom UITableViewCell interface in my ViewController.m, I have to move interface to ViewController.h.

answered Jul 05 '14 at 11:34

Nim Thitipariwat

778
6
12

jiwq · Answer 21 · 2014-07-16T06:39:32.400

I encountered the same problem when I use the storyboard to create the custom UITableViewCell. Fortunately I found the problem, because I outlet the accessoryView([UITableViewCell setAccessoryView:]) to UIButton which I added to the cell.

So it occurred in my project when run on the iOS6.

Solution

I release the outlet between accessoryView and my button which contained the custom cell.

Proposal

You shouldn't used the UITableViewCell's native elements and change it.

score 0 · Answer 22 · answered Jul 28 '14 at 20:20

0

This problem can be caused by forgetting to call [super viewDidAppear:] within viewDidAppear, but I'm sure it's not the only cause.

answered Jul 28 '14 at 20:20

michaelsnowden

6,031
2
38
83

score 0 · Answer 23 · answered Sep 19 '14 at 02:01

I had exact the same problem. Here is the problem with my project:
When I worked on the Interface Builder to create a custom UITableViewCell, I dragged a View instead of a Table View Cell from the object collection pane in Xcode
as the custom table cell.
If you are in the same situation, here is the solution:
Delete the view in interface builder, make sure you drag a Table View Cell from the object collection pane and redo the custom table cell view. You can copy the objects in the old view and paste them to the canvas for the new Table View Cell.

score 0 · Answer 24 · answered Oct 16 '14 at 09:54

I had a very similar problem with a table footer view I was setting in Xcode 6, iOS 7+. The solution was in the format of the nib file. Apparently it was stuck in Xcode 4 format or something. Changing the file settings to "opens in: Xcode 6.0" (or Default, for that matter), instantly fixed it. Found the solution by chance: it was driving me crazy, so I deleted the entire file and created again, obviously with the default settings. I have no idea why simply editing the file in the latest Xcode didn't convert it to a Xcode 5+ format, as it usually happens.

score 0 · Answer 25 · answered Feb 09 '15 at 06:35

I went had the same issue. I went to my DetailViewController and renamed the identifier to UIView. It was previously on UITableView. It fixed the problem. This problem doesn't have to be in your DetailViewController. It could be in any other one. Try renaming it to the respected identifier.

score 0 · Answer 26 · answered Mar 05 '15 at 13:40

I had a similar issue with static table view cells in IB. One of the cells had a subview that had a class that was mistakenly altered to a subclass of UITextfield. The compiler didn't give any warnings/errors. But at runtime the system was unable to load the view controller with the aforementioned crash as a result.

score 0 · Answer 27 · edited Jun 20 '20 at 09:12

0

Issue is sequencing of the layout calls to the subviews:

Check out

Shows up in iOS < 8

edited Jun 20 '20 at 09:12

Community

1
1

answered Mar 16 '15 at 12:52

Shanu ji

359
4
5

score 0 · Answer 28 · answered Mar 19 '15 at 09:52

0

Solution: change constraints before call super layoutSubviews

- (void)layoutSubviews
{

    [self _updateConstraints];

    [super layoutSubviews];
}

answered Mar 19 '15 at 09:52

abuharsky

1,151
12
21

score 0 · Answer 29 · edited May 23 '17 at 11:46

I modified Carl Lindberg's answer to override UITableView instead and it started working for me:

UITableView+AutoLayoutFix.h

@interface UITableView (AutoLayoutFix)
@end

UITableView+AutoLayoutFix.m

#import <objc/runtime.h>

@implementation UITableView (AutoLayoutFix)

+ (void)load
{
    Method existingMethod = class_getInstanceMethod(self, @selector(layoutSubviews));
    Method newMethod = class_getInstanceMethod(self, @selector(_autolayout_replacementLayoutSubviews));

    method_exchangeImplementations(existingMethod, newMethod);
}

- (void)_autolayout_replacementLayoutSubviews
{
    [super layoutSubviews];
    [self _autolayout_replacementLayoutSubviews]; // not recursive due to method swizzling
    [super layoutSubviews];
}

@end

Then in MyViewController.m I just imported the category:

#import "UITableView+AutoLayoutFix.h"

score 0 · Answer 30 · answered Aug 25 '16 at 03:00

0

I met the same problem and finally found the reason was that I added one constraint to the UITableViewCell, which should be the UITableViewCell's contentView. When I changed the constraint everything went fine!

answered Aug 25 '16 at 03:00

Alfy

889
1
7
17

score -1 · Answer 31 · answered Dec 26 '13 at 19:22

-1

I had the same problem , changing from UIView to UITableViewCell solved the problem.

answered Dec 26 '13 at 19:22

banty

1,019
1
8
9

"Auto Layout still required after executing -layoutSubviews" with UITableViewCell subclass

31 Answers31

Linked

Related