8

Here is what I would like my application to do on a tablet. Fragment (0) has some menu that would display fragments (1)...(n) like this:

-----------------
|   |   |   |   |
|   |   |   |   |
|(0)| X | X | X |
|   |   |   |   |
|   |   |   |   |
-----------------
 becomes
-----------------
|   |   |   |   |
|   |   |   |   |
|(0)|(1)| X | X |
|   |   |   |   |
|   |   |   |   |
-----------------
 and then
-----------------
|   |   |   |   |
|   |   |   |   |
|(0)|(2)|(1)| X |
|   |   |   |   |
|   |   |   |   |
-----------------
 etc...

Fragment0 never moves, the other ones are shifted to the right. Fragments going off the edge to the right will be destroyed.

So I setup my XML layout with a horizontal LinearLayout and containing 4 FrameLayout with the proper IDs (fragment0... fragment3)

I can instantiate and display fragment0 and then fragment1, but I am not able to shift it to the right after, I get:

ERROR/AndroidRuntime(343): FATAL EXCEPTION: main
java.lang.IllegalStateException: Can't change container ID of fragment ...

The only related questions I have found are this one and that one, tried all the different solutions offered with no luck.

Tried FragmentTransaction.remove() followed by .add(), tried .replace(), tried them in different orders and to commit half-way through (even trying to commit twice as somebody suggested), tried to call addToBackStack() ... still no luck.

Question is whether it is possible to move the fragments like this with a FragmentTransaction. If yes, what am I doing wrong (and bonus, is it possible to animate that?). If no, what would be the proper way to implement this?

Note that I don't want to re-instantiate the fragments every time (each do some queries on the web that can take some time). It's possible to extract all the data back to the activity to recreate one, but I'd rather not do that if possible...

Community
  • 1
  • 1
Matthieu
  • 16,103
  • 10
  • 59
  • 86

2 Answers2

24

Yes container of the fragment can be changed using remove() function.

The problem here is commit(). It is an asynchronous call, and will schedule it to be on main thread. So to force the FragmentManager to do this immediately before adding it to the other container.

For this we will have to use executePendingTransactions() function. After calling this try adding the fragment to new container.

Docs : executePendingTransactions()

Code Sample :

FragmentManager fManager = getSupportFragmentManager();
FragGroups fragGroups = (FragGroups) fManager.findFragmentByTag("groups");
if (fragGroups != null) {
     fManager.beginTransaction().remove(fragGroups).commit();
     fManager.executePendingTransactions();
} else {
     fragGroups = new FragGroups();
}
if (mTwoPane) {
    fManager.beginTransaction().replace(R.id.fragment_container_groups, fragGroups, "groups").commit();
} else {
    fManager.beginTransaction().replace(R.id.fragment_container, fragGroups, "groups").commit();
}

Enjoy. Feed-backs are welcomed

Edit

I would like a add a point here. As I had same problem, came across to this thread and applied suggested changes. Problem still persisted. Then i looked into last comment down this thread that solved my problem: remove addToBackStack() method while committing a transaction or if you intentionally using it, remove the fragment from back stack before adding it to another container. Hope it will help to future reader.

Sachin Chandil
  • 17,133
  • 8
  • 47
  • 65
Pavan Jaju
  • 873
  • 11
  • 19
3

I don't know if this is quite what you want but I made a little sample regarding your problem. Basically you'll be doing the right shifting using the layout file, having a wrapper container for each of those shifting fragments. The code sample is a little to big for an answer so I've posted it into a gist that you can find here. In that sample press each of the ListFragment's items(Fragment 1 -> Fragment 2 -> fragment 3) to see the behavior.

user
  • 86,916
  • 18
  • 197
  • 190
  • It does not do what I am looking for, but I am trying to change your code to do it... I'll post it if I am able to... – Matthieu Nov 29 '12 at 02:58
  • Was able to do what I needed... Could not figure out how to push my changes to the gist you created, so I put it there: https://gist.github.com/4166640 – Matthieu Nov 29 '12 at 03:40
  • Excuse me. Is that a typo, that it should be `LinearLayout` instead of `RelativeLayout` in `frag_fragaccordion.xml`? – midnite Apr 06 '13 at 21:20
  • @midnite Why do you ask that? Both samples use `RelativeLayout` in that layout file. – user Apr 11 '13 at 08:34
  • i meant in @Matthieu example, the line 33 `LinearLayout main_linear = (LinearLayout) getActivity().findViewById(R.id.main_linear);` is strange to me. – midnite Apr 11 '13 at 10:10
  • @midnite Well you should ask him, that is not in my code and I can't help you with that(that id also doesn't appear in that layout file?!?). – user Apr 11 '13 at 11:12
  • @Luksprog, sorry to make you misunderstood. i am not challenging him, nor you neither. i just wanna see if that is a typo. And it may help others who need this answer as well :-) – midnite Apr 11 '13 at 13:44
  • @midnite I understand that but I don't know Matthieu's code(and I think he probably used a `LinearLayout` instead of the `RelativeLayout` from my code) – user Apr 11 '13 at 19:26
  • Yes, I was using a LinearLayout, I don't see how that really matters though – Matthieu Oct 04 '13 at 18:01
  • @Matthieu This is an old question so I'm not sure what was the problem, but I think midnite was referring to a difference between our sample codes(yours being more developed). – user Oct 05 '13 at 05:24