211

Has anyone got any experience with overriding the alert() function in JavaScript?

  • Which browsers support this?
  • Which browser-versions support this?
  • What are the dangers in overriding the function?
cllpse
  • 21,396
  • 37
  • 131
  • 170
  • Is that not an infinite loop? – Pool Nov 13 '09 at 14:39
  • 1
    @Nick - no, it is not. The 'normal' window.alert function will be assigned to window._alert. >After< that the window.alert function is redefined. – Chris Shouts Nov 13 '09 at 14:45
  • @roosteronacid: Your code was semantically and syntactically fine, though contrived, as @paper1337 pointed out...no chance of recursion there lol...in essence you just *swapped* function bodies with `_alert` as a sort of *expando* temp in the first instance. – non sequitor Nov 13 '09 at 14:55
  • Aye. I did a roll-back thou, as to not obscure the question :) – cllpse Nov 13 '09 at 14:57

12 Answers12

216

It's definitely "supported". It is your web page, you do whatever you want to with it.

I already did this to track analytics events without modifying a library but by sneaking into events.

Use the proxy pattern:

(function(proxied) {
  window.alert = function() {
    // do something here
    return proxied.apply(this, arguments);
  };
})(window.alert);

You can also bypass the call to the original function if you want (proxied)

More info here: JQuery Types #Proxy Pattern

23

Although most browsers support overriding it, be careful with what you're doing with it.

Since the default alert box blocks the execution thread, some libraries that rely on this behaviour might not work anymore (at best).

You should be a good citizen and avoid touching the native API. If you do, you could break things up, when using 3rd party code.

Yet, if you want to redefine the alert behaviour in a specific context, you could enclose it with an anonymous function, like this:

/* new funky alert */
function myFunkyAlert(msg) { 
    /* here goes your funky alert implementation */
    alert("Look ma!\n" + msg);
}

(function(alert) { // anonymous function redefining the "alert"

    /* sample code */
    alert("Hello World!");

})(myFunkyAlert);
Pablo Cabrera
  • 5,749
  • 4
  • 23
  • 28
18

There are no dangers in Overring alert function. Every browser supprts it.

for example:

// function over riding. Redirecting to Console with Firebug installed.
function alert(message) { 
    console.info(message);
} 

alert('This is an override.');
Robert Koritnik
  • 103,639
  • 52
  • 277
  • 404
user160820
  • 14,866
  • 22
  • 67
  • 94
  • 12
    There *could* be a danger if your replacement is nonblocking. For example, code which calls `alert("Reloading")` and then reloads the webpage. The alert text might never be seen by the user. – Darien Jan 22 '14 at 23:26
14

As said in many of the other answers, you can just override the function with

window.alert = null

or

window.alert = function(){}

however, this doesn't necessarily override the function on the prototype of the Window constructor (note the capital W), so the hacker can still type:

Window.prototype.alert.apply(window, ["You were hacked!"]);

therefore, you also need to override that function with:

Window.prototype.alert = null

or

Window.prototype.alert = function(){}
Sophie
  • 780
  • 6
  • 18
  • This doesn't necessarily override the function in other frames. see http://jsfiddle.net/18znqbjd/1/ – Robert Aug 12 '14 at 06:58
  • Robert: Yes and for good reasons. Different frames are basically different HTML documents, each with their own "instance" of Javascript. – Rolf Oct 21 '15 at 10:37
  • 1
    Are you sure Window.prototype.alert is still a function in 2017? :P – iplus26 Feb 22 '17 at 12:10
13

I think every Javascript implementation will support this, and there is no danger involved with it. It's commonly done to replace the plain OS-styled alert boxes to something more elegant with HTML/CSS. Doing it this way means you don't have to change existing code! The fact that it is possible makes Javascript awesome.

Josh Stodola
  • 81,538
  • 47
  • 180
  • 227
6

Ladislav.
For IE8 you can redefine alert() like this way

/** 
 * Definition of global attached to window properties <br/>
 */ 
    (function() {
      nalert = window.alert;
      Type = {
          native: 'native',
          custom: 'custom'
      };
    })();

/**
 * Factory method for calling alert(). 
 * It will be call a native alert() or a custom redefined alert() by a Type param.
 * This defeinition need for IE
 */ 
    (function(proxy) {

          proxy.alert = function () {
          var message = (!arguments[0]) ? 'null': arguments[0];
          var type = (!arguments[1]) ? '': arguments[1];

          if(type && type == 'native') {
           nalert(message);
          }
          else {
               document.write('<h1>I am redefiend alert()<br/>Alert say: '+message+'</h1>');
          }     
      };
   })(this);

and call as

alert('Hello, hacker!');
nalert('I am native alert');
alert('Hello, user!', Type.custom);
Vitaliy R.
  • 69
  • 1
  • 1
4

All JavaScript implementations in modern browsers support overriding.

The dangers are quite simply, that you would drive other team members absolutely crazy by overriding commonly known functions such as alert().

So unless you are overriding functions as a tool to perhaps debug or hack existing code in some way, I don't see any reason to do it. Just create a new function.

Christopher Tokar
  • 11,644
  • 9
  • 38
  • 56
4

My experience with overriding alert() function is that we once used it to "hack" trial version of JavaScript library that displayed "Please register!" nag screen through alert time to time.

We just defined our own alert() function and voila.

It was for testing purposes only, we bought full version later, so nothing immoral going on here ;-)

Josef Sábl
  • 7,538
  • 9
  • 54
  • 66
3

I have faced a requirement to show a default message along with the actual alert messages. This is how I managed to do it.


    const actualAlertFunc = window.alert;
    window.alert = function(msg) {
         actualAlertFunc('some default message '+ msg);
    }

I have tested it on chrome. I am not sure whether its a good practise, but it serves the purpose.

Badri nath
  • 51
  • 3
2

It sure works in firefox and ie8. I can't see that there'd be any browser it wouldn't work in. This is pretty much fundamental of how javascript works, even though one don't often see it used with native functions like that =)

David Hedlund
  • 128,221
  • 31
  • 203
  • 222
1

A quick hack that I do to find where the alerts are coming from, is to go to console and then enter this

function alert(message) { 
  console.info(message);
  debugger;
} 
zainengineer
  • 13,289
  • 6
  • 38
  • 28
0

When it comes to js browser functions window.alert is pre-eminent and most well known, people who don't know js know alert() -- rest assured it is supported in all browsers in use today and your code snippet is as well. However, I wouldn't override (well this is more like refactoring rather than override in the OOP sense) alert() for a particular use case as yours because when you actually need to use alert() with no template, and you probably will, then you'll need another non-alert function to do so.

non sequitor
  • 18,296
  • 9
  • 45
  • 64