66

Both "Exit Sub" or "Return" seem to accomplish the same thing -- exit a subroutine. Is there any difference in how they work under the covers?

That is,

Private Sub exitNow()
    Exit Sub
End Sub

or

Private Sub exitNow()
    Return
End Sub
Peter Mortensen
  • 30,738
  • 21
  • 105
  • 131
Jeff
  • 8,020
  • 34
  • 99
  • 157

7 Answers7

78

From the doc:

In a Sub or Set procedure, the Return statement is equivalent to an Exit Sub or Exit Property statement, and expression must not be supplied.

So they're the same in this context.

(Return (<value>) is used in functions and property.get's. Obviously slightly different in that context).

RBarryYoung
  • 55,398
  • 14
  • 96
  • 137
24

I tend to prefer Return over Exit Sub. Because once in a while you change from Sub to Function. In this case Exit Sub could be converted to Exit Function, but this assumes that there was a previous assignment to the function name (alike VB 6), which most probably didn't happen. Return would catch this situation - if the method should return a value, Return with no argument will fail at compile time.

Mike
  • 843
  • 7
  • 13
7

If you inspect the IL output of the 2 statements, they are the same. However, since ’return’ is meant for pushing something back to the caller, so strictly speaking, ‘Exit Sub’ is more suitable for using in a Sub.

dipan chikani
  • 199
  • 4
  • 13
  • 6
    Actually return has two meanings. For functions it means returning something back to the caller, and in both functions and subs it means returning execution back to the calling location. This is the case in most languages with a "return" keyword. "Exit Sub" only exists for backwards compatibility with pre-.NET VB. – smead Feb 24 '16 at 22:26
  • 3
    I don't agree with "*‘Exit Sub’ is more suitable for using in a Sub.*" There is nothing wrong with `Exit Sub`, HOWEVER it is specific to Visual Basic; `return` is used to exit from subroutines in all languages inspired by `C`: `C#`, `java`, `C++`, `Objective-C`. – ToolmakerSteve Aug 07 '17 at 04:51
  • @ToolmakerSteve I agree with "‘Exit Sub’ is more suitable for using in a Sub because we are using VB.Net language and this language is more user friendly then other so Exist sub is best option then return because you can check other keywords like IF END IF etc. I hope you understood what I mean. – Rikin Patel Aug 03 '20 at 04:35
4

They are the same in this context.

However, from the code readability point of view, "Exit Sub" would be clearer since the "Return" indicates that something some value is being used as an output (which is not the case with Sub-routines).

Thiago Burgos
  • 947
  • 2
  • 13
  • 17
  • 6
    This should be a comment, rather than an answer. – Timothy Randall Feb 04 '14 at 14:48
  • 4
    I don't agree with "*‘"Exit Sub" would be clearer..*" There is nothing wrong with `Exit Sub`, HOWEVER it is specific to Visual Basic; `return` is used to exit from subroutines in all languages inspired by `C`: `C#`, `java`, `C++`, `Objective-C`. Downvoted because this says the same thing as [chikani's answer](https://stackoverflow.com/a/12576839/199364) two years earlier, so adds nothing to the discussion. – ToolmakerSteve Aug 07 '17 at 04:51
1
  • First of all, Procedures comes with sub, we should know that we are working on specific procedures that don't return a specific value with the ability of passing some specific parameters or even without passing any parameter. Such as:
  • Print something().
  • Calculate the factorial of integer number CalcFact(X).
  • Do some processes for a specific task.

  • Function is a specific process programmed to achieve a specific task by also passing some specific parameters, and it has to return some value that can be used to to complete the overall task, such as validation the user name and user pass.

In short Sub Doesn't return value and we call it directly "Print HelloWorld()" , whereas functions do such as:

  • ValidUsersNameAndPass("Johne","jOhNe13042019") ' This could return a Boolean value.
  • ValidUsersNameAndPass("Johne","jOhNe13042019"); // This could return a Boolean value.
avariant
  • 2,234
  • 5
  • 25
  • 33
MAMPRO
  • 69
  • 6
0

I wanted to confirm that they act the same in lambda expressions too, and they do:

Sub test()

    Dim a As Action = Sub() Exit Sub
    Dim b As Action = Sub() Return

    a()
    b()

    MsgBox("Yes they do!") 
 End Sub
Patrick
  • 196
  • 1
  • 2
  • 9
Slai
  • 22,144
  • 5
  • 45
  • 53
-1

While there are exceptions like guard clauses, in most cases I would consider either a sign that the method is too long.

Joel Coehoorn
  • 399,467
  • 113
  • 570
  • 794