Whats wrong with my mouseup code?

Question

Trying to detect left click vs right click (without using jQuery!) and I have the following code

Javascript:

function cclick(e) {
   if (e.button == 1) {alert("hgbdygwea");}
   else {
      alert(e.button);
   }
}

HTML:

<a onmouseup="cclick()" ...> <img .../> </a> <!-- also tried cclick instead of cclick() -->

using internet explorer 9

What's the issue? Does it fail at detecting the mouseup event? — Waleed Khan, Apr 09 '12 at 06:51
it doesnt alert, and when i replace cclick() with cclick in the html, it says .button is undefined — Oztaco, Apr 09 '12 at 06:52
You do if you're doing it using proper event listeners. Dunno what to do if you're using `onclick`. — Waleed Khan, Apr 09 '12 at 06:54
`button == 1` is middle click. Left button is `0` and right is `2` — kirilloid, Apr 09 '12 at 06:54
@kirilloid yeah i just figured that out after testing nnnnnn's code :) — Oztaco, Apr 09 '12 at 06:56
see more at here : http://stackoverflow.com/questions/2405771/is-right-click-a-javascript-event — OammieR, Apr 09 '12 at 07:02

score 3 · Accepted Answer · answered Apr 09 '12 at 07:00

3

You need to pass the event object to your function:

onmouseup="cclick(event);"

answered Apr 09 '12 at 07:00

nnnnnn

147,572
30
200
241

score 1 · Answer 2 · answered Apr 09 '12 at 07:00

1

Quirksmode has a good write up on the subject of "Which mouse button has been clicked?" and his code works over the top of yours.

answered Apr 09 '12 at 07:00

Marcel

27,922
9
70
85

score 0 · Answer 3 · answered Apr 09 '12 at 07:13

0

Following is another approach

function cclick() {
   var e = window.event;
   if (e.button == 1) {alert("hgbdygwea");}
   else {
      alert(e.button);
   }
}

And call the function as below without passing the event.

<a onmouseup="cclick()" ...> <img .../> </a>

answered Apr 09 '12 at 07:13

prageeth

7,159
7
44
72

This only works in Microsoft browsers. Other browsers do not have a window.event – Eric Apr 09 '12 at 07:16
1

Sure, as he has mentioned he need to run it on 'Internet Explorer 9' – prageeth Apr 09 '12 at 07:38

score 0 · Answer 4 · answered Apr 09 '12 at 07:14

0

I think this code should work for you. e.button is not valid for all browsers (and I cleaned up the code).

function cclick(e) {
    "use strict";
    e || window.event;
    if (e.which) {
        alert((e.which === 1) ? "hgbdygwea" : e.which);
    } else {
        alert((e.button === 1) ? "hgbdygwea" : e.button);
    }
}

<a onmouseup="cclick(event)" ...> <img .../> </a> <!-- also tried cclick instead of cclick() -->

answered Apr 09 '12 at 07:14

Eric

6,563
5
42
66

which browsers is e.which for? i heard it was for netscape so i didnt bother with it since its not popular anymore? – Oztaco Apr 09 '12 at 08:01

Whats wrong with my mouseup code?

4 Answers4