MVC C# view is not allowing if statement in tag

Question

I have some code like:

<table class="invisibleforprint">
    <thead>
        <tr class="mainheader">
            <th>@Html.ActionLink("Invoice Number", "Index", new { sortOrder= ViewBag.NumberSortParm })</th>
        </tr>
    </thead>
    <tbody>
    @foreach (var item in Model) {
        <tr>
            <td class="invoiceActions">
                <input type="button" class="btnresetinvoice button" value="Reset" data-invoiceid="@item.InvoiceId" />
            </td>
        </tr>
    }</tbody>
</table>

Which compiled fine. I went and added an if statement in the input:

<table class="invisibleforprint">
    <thead>
        <tr class="mainheader">
            <th>@Html.ActionLink("Invoice Number", "Index", new { sortOrder= ViewBag.NumberSortParm })</th>
        </tr>
    </thead>
    <tbody>
    @foreach (var item in Model) {
        <tr>
            <td class="invoiceActions">
                <input type="button" class="btnresetinvoice button" value="Reset" data-invoiceid="@item.InvoiceId" @{ if(item.PMApproved != true) { @:disabled="disabled" } } />
            </td>
        </tr>
    }</tbody>
</table>

It's giving the error '} expected'

Say what? I've added an equal amount of opening closing brackets.

Anyone know what I've done wrong?

Why don't you use helpers? That looks like an awful tag soup. — Darin Dimitrov, Apr 16 '12 at 21:06

score 1 · Accepted Answer · answered Apr 16 '12 at 21:15

1

<input type="button" class="btnresetinvoice button" value="Reset" data-invoiceid="@item.InvoiceId" @(item.PMApproved != true ? "disabled='disabled'" : "" ) />

answered Apr 16 '12 at 21:15

superlogical

14,332
9
66
76

score 1 · Answer 2 · answered Apr 16 '12 at 21:39

<input type="button" value="Reset" data-invoiceid="@item.InvoiceId" @(item.PMApproved ? "disabled=\"disabled\"" : null) />

Or you can use @if with <text> tag:

<input type="button" value="Reset" data-invoiceid="@item.InvoiceId" @if(item.PMApproved) { <text>disabled="disabled"</text>} />

score 0 · Answer 3 · answered Apr 16 '12 at 21:01

0

Instead of using curly braces around your if statement, you should be using normal brackets.

i.e.:

@( if(item.PMApproved != true) { @:disabled="disabled" } )

Can you give that a try?

answered Apr 16 '12 at 21:01

Steve Hobbs

3,296
1
22
21

Tried it but it doesn't seem to like it – AnonyMouse Apr 16 '12 at 21:06
Btw there is no need to compare boolean value with true/false. You can simply write `if(item.PMApproved) { ... }` – Sergey Berezovskiy Apr 16 '12 at 21:23
In this case I do because it is a nullable bool – AnonyMouse Apr 16 '12 at 22:12

score 0 · Answer 4 · edited May 23 '17 at 12:16

0

You could perform the following pornography (but please don't):

<input type="button" class="btnresetinvoice button" value="Reset" data-invoiceid="@item.InvoiceId" @Html.Raw(item.PMApproved ? "disabled=\"disabled\"" : "") />

or use helpers as I suggested you:

@Html.ApproveButton(item)

edited May 23 '17 at 12:16

Community

1
1

answered Apr 16 '12 at 21:14

Darin Dimitrov

1,023,142
271
3,287
2,928

MVC C# view is not allowing if statement in tag

4 Answers4