1

Best practices question: Is there anything improper about creating a new object within another class method? I have a small example below:

public function export() {

$orders = new Orders($id);
$all_orders = $orders->get_all_orders();

  }
stevenpepe
  • 267
  • 4
  • 16

2 Answers2

2

The example you gave is perfectly acceptable.

If for example, you were instantiating the same object in all of your methods then you could store the object as a property instead.

Example: The Orders object is instantiated in the constructor and stored as a property.

class Something
{    
    protected $orders;

    public function __construct($id)
    {
        $this->orders = new Orders($id);
    }

    public function export()
    {

        // use $this->orders to access the Orders object
        $all_orders = $this->orders->get_all_orders();
    }

}
MrCode
  • 63,975
  • 10
  • 90
  • 112
  • Could you give me an example of doing that? – stevenpepe May 04 '12 at 13:15
  • @stevenpepe The above code is about 2 steps away from [dependency injection](http://en.wikipedia.org/wiki/Dependency_injection) and it might be worth taking those steps if you can. – DampeS8N May 04 '12 at 13:48
0

Passing Order object in constructor would be a better approach in my opinion. That would make testing easier.

It all depends on the big picture of the problem, obviously the id needs to be passed to Order object somewhere else:

class Something
{    
    protected $orders;

    public function __construct(Order $order)
    {
        $this->orders = $order;
    }

}
LDusan
  • 205
  • 2
  • 8
  • http://stackoverflow.com/questions/15901861/why-not-instantiate-a-new-object-inside-object-constructor?rq=1 – LDusan Jan 11 '14 at 04:03