3

I'm messing around with the source code for an old Java game written in the early nineties. If I remember correctly, it's written for JDK 1.1.

Somewhere in the code, int primitives (in the range of 0 to about 120) are converted to chars. Here's an example:

char c = (char)(i+32);

This causes a problem for ints greater than 95. Here's the code and some of the output from a test case:

for(int i = 120; i >= 0; i--)
   System.out.println(i + " -> " + (char)(i+32));

Output:

...
100 -> ?
99 -> ?
98 -> ?
97 -> ?
96 -> ?
95 -> 
94 -> ~
93 -> }
92 -> |
91 -> {
90 -> z
89 -> y
88 -> x
87 -> w
...
3 -> #
2 -> "
1 -> !
0 ->

The integer value seems to be lost since the index goes past the bounds of normal character values.

This seems to be the root cause of a bug on the client-side portion of the game's UI. This encoded integer is sent back to the client, which then performs the inverse operation (subtracting 32 from the char and casting to get an int back).

It seems that the '?' is taken literally by the client-side processing module, as the bar is redundantly filled with the mapped integer value for '?' until the server starts sending back values smaller than 95.

  1. What character encoding might have been used on the authors' platform?
  2. What exactly is happening on my platform differently?
  3. What is, in your opinion, the easiest solution to this problem?
kwikness
  • 1,425
  • 4
  • 21
  • 37

4 Answers4

2

The integer value seems to be lost since the index goes past the bounds of normal character values.

Well, it's not really "lost" - it's just going into a range of control characters.

What character encoding might have been used on the authors' platform?

I don't believe this is a "normal" encoding on any platform.

What exactly is happening on my platform differently?

It's not clear what you expected to happen, but those characters can't be displayed by your console, so it's translating them into '?'

What is, in your opinion, the easiest solution to this problem?

You'd have to define the problem better to start with, in terms of what you want to happen, to get a solution to this. It's not clear whether this is really a console game or something else, or what you want to happen.

Work out exactly what you want the behaviour to be first, and then it may well be quite easy to accomplish it - I suspect the problem may be that you don't (yet) have a very clear idea of what the final outcome should be. Often, then act of just defining that very specifically is enough to get you going.

Jon Skeet
  • 1,421,763
  • 867
  • 9,128
  • 9,194
  • Thanks; I've updated my post to describe what I'm trying to fix. – kwikness May 06 '12 at 15:16
  • @kwikness: Well, you've now not given any indication of *how* the characters are transmitted back to the client... if that's losing information, then the details of that process are vital to working out what's going on. – Jon Skeet May 06 '12 at 15:33
  • lol-- I indicated how they were processed client-side. I think that's enough. Thanks for your help. – kwikness May 06 '12 at 15:37
  • @kwikness: No, that's *not* enough: "This encoded integer is sent back to the client, which then performs the inverse operation" - without saying *how* the encoded integer is sent to the client side, we can't tell whether it's losing information or not. If you lose data *before* you process it on the client side, you're not going to be able to recover the data whatever you do. When I ask for more information, it's because that information is important. But hey, if you don't actually want help, that's fine. – Jon Skeet May 06 '12 at 15:54
1

What is, in your opinion, the easiest solution to this problem?

First, you have to understand what the application is actually trying to output; i.e. what those integer values really mean. That will determine the requirements for rendering them to (I guess) printable characters.

If you are simply trying to render the integers as something printable, then you could do it with a lookup table implemented as an array of characters; e.g.

char[] map = new char[128];  // ... or whatever the limit is 
for (int i = 0; i < 96; i++) {
    map[i] = (char) (i + 32);
}
// fill the rest of the array with suitable Unicode characters.
map[96] = ...
map[97] = ...

and then map the characters like this:

char c = (i >= 0 && i < 128) ? map[i] : '?'; // ... or throw an exception.
Stephen C
  • 698,415
  • 94
  • 811
  • 1,216
1

char in Java is a 16bit Unicode character. It is possible the old code was expecting to treat the int values as bytes and you could then convert the bytes to chars specifying different character sets until you get one that makes sense (i.e. new String(byteArrayData, "ASCII")).

What you will need to take account of is that bytes are signed in Java and so range from -128->+127. If your old game code was expecting to use the values in the extended ascii set (> 127), then you'll need to subtract 256 from any int > 127 to get the correct byte value. See: How does Java convert int into byte? for more details.

Community
  • 1
  • 1
Malcolm Smith
  • 3,540
  • 25
  • 29
  • You should also take account of the fact that ASCII itself only goes up to 127. If the server was using an ASCII encoding to transmit the data back to the client, then any characters over 127 wouldn't be transmitted properly. But the OP seems to believe that's not relevant, for some reason... – Jon Skeet May 06 '12 at 15:55
0

It could be that an 8-bit encoding such as Win1252 was used, which has visible characters in the 80-9F range.

See http://en.wikipedia.org/wiki/Windows-1252

Christopher Oezbek
  • 23,994
  • 6
  • 61
  • 85