PHP, 'Haystack contains Needle?'

Question

Assuming this works properly for telling if a substring is in a string, is there a more concise way to do this?

if(is_int(strpos($haystack, $needle))){
   ...
}

score 6 · Accepted Answer · answered May 07 '12 at 01:59

6

I wouldn't do it that way. Just make a strict comparison to FALSE.

$found = strpos($haystack, $needle) !== FALSE;

answered May 07 '12 at 01:59

alex

479,566
201
878
984

1

@bfavaretto It's a needless extra function call, which among other things is [expensive](http://stackoverflow.com/questions/3691625/why-are-php-function-calls-so-expensive). – alex May 07 '12 at 02:03
This is correct, strpos returns FALSE when no needle is found. – kintsukuroi Apr 20 '19 at 06:44

score 3 · Answer 2 · answered May 07 '12 at 02:00

Not really. It really comes down to your preference for which one is the clearest way to express what you're doing. Some alternatives:

if( strpos( $h, $n ) !== FALSE ){
    // stuff
}

if( strpos( $h, $n ) > -1 ){
    // stuff
}

The most common approach is probably to use the strict FALSE comparison, so if you're working on an open-source project or have a lot of other people using your code, consider that option.

PHP, 'Haystack contains Needle?'

2 Answers2