C++ strings connecting with char arrays

Question

Is this good way to do it?

char* array = "blah blah";
char* array2 = "bloh bloh";
string str = string() + array + array2;

Can't do direct string str = array + array2, can't add 2 pointers. Or should I do this

string str();
str += array;
str += array2;

By the way, this code isn’t valid C++ any more (with C++11), and should generate warnings even when using older C++ for the use of deprecated non-const `char*` literals. Furthermore, the second code doesn’t compile anyway due to the [most vexing parse](http://stackoverflow.com/q/1424510/1968). — Konrad Rudolph, May 09 '12 at 16:50
@usoban: There is a reason that `std::string` defines a conversion from `char*` to `std::string`. Sometimes you have a `char*` to deal with and there's no way around it. — Ed S., May 09 '12 at 16:50

score 4 · Accepted Answer · edited May 23 '17 at 11:57

4

I would write:

string str = string(array) + array2;

Note that your second version is not valid code. You should remove the parentheses:

string str;
str += array;
str += array2;

Lastly, array and array2 should be of type constchar *.

edited May 23 '17 at 11:57

Community

answered May 09 '12 at 16:48

NPE

@user1112008: I am not sure I understand your question. – NPE May 09 '12 at 16:56
I just need to glue 2(or more) char arrays to string. – user1112008 May 09 '12 at 16:59

score 3 · Answer 2 · answered May 09 '12 at 16:52

3

There are lots of ways to do this:

string str(array);
str += array2;

or

string str = string(array) + array2;

or even

string str = array + string(array2);

or string streams:

stringstream ss;
ss << array << array2;

answered May 09 '12 at 16:52

Luchian Grigore

2 Answers2