array.push() throws weird error

Question

I'm trying to push elements into array X while iterating through array Y. At some point, while pushing a new element into array X, I get an "Unexpected token :" error in the browser console. I am able to push several elements properly before it fails (almost every time around 7th element).

It is recursive function, and maybe that causes an issue... Here is the code:

function getPosition(img) {
    var tmpRandPosition = Math.floor(Math.random() * (9));

    if($.inArray(galleryPositions[tmpRandPosition], populatedPositions) != -1) {
        setTimeout("getPosition("+img+")",1);
    } else {
        populatedPositions.push(galleryPositions[tmpRandPosition]);

        return true;
    }
}

As you can see from the script, I'm trying to display photos randomly at 8 different positioned elements in HTML.

I think, its more likely that there is a problem with the filename of that particular image or something like that. Oh, and pass a function instead of a string to that setTimeout. — Christoph, May 10 '12 at 14:22
The problem was, as @antyrat pointed, in wrong function passing from setTimeout(). — jMn, May 10 '12 at 14:35

score 3 · Accepted Answer · edited Dec 06 '12 at 16:56

3

Seems the problem is in the setTimeout function. Try to pass the argument to that function using an anonymous function instead of concatenation:

setTimeout(function() { getPosition(img) }, 1);

edited Dec 06 '12 at 16:56

Andreas Louv

46,145
13
104
123

answered May 10 '12 at 14:22

antyrat

27,479
9
75
76

Yes, that was the issue. Thanks a lot. :) – jMn May 10 '12 at 14:32

Andreas Louv · Answer 2 · 2012-12-04T11:51:54.603

This will break:

setTimeout("getPosition("+img+")",1);

as it actually writes:

setTimeout("getPosition(img_path.jpg)",1);

and tries to evaluate it (using eval).

The problem is that JS consider img_path.jpg as a variable.

Fix:

setTimeout("getPosition('"+img+"')",1);

But never do it this way as it's not good or fast to evaluate a string.

Send instead an anonymous function to setTimeout:

REALFIX:

setTimeout(function() {
    getPosition(img);
}, 1);

score 1 · Answer 3 · edited May 23 '17 at 12:04

1

Don't call setTimeout with a string argument. Always use a function. Using the string in this case subjects this code to injection attacks if the img variable is vulnerable.

edited May 23 '17 at 12:04

Community

1
1

answered May 10 '12 at 14:31

Will

6,601
3
31
42

array.push() throws weird error

3 Answers3