Text from the array isn't being read

Question

I am trying to create an IRC Bot, below is the code, however, when it runs, it will not detect "001" whatever I try, I'm running it on JRE6 and using JDK6. I'm developing it with Eclipse and using the debug feature to run it. I've tried with both "java.exe" and "javaw.exe". When running, debugex shows 001 is clearly there.

Here is my code:

package bot;
import java.io.*;
import java.net.*;
public class Main {
    static PrintWriter out = null;
    @SuppressWarnings("unused")
    public static void main(String[] args) {
        Socket sock = null;
        BufferedReader in = null;
        try {
            sock = new Socket("irc.jermc.co.cc",6667);
            in = new BufferedReader(new InputStreamReader(sock.getInputStream()));
            out = new PrintWriter(sock.getOutputStream(), true);
        } catch (UnknownHostException e) {
            e.printStackTrace();
        } catch (IOException e) {
            e.printStackTrace();
        }
        boolean sentconnect = false;
        while(sock.isConnected() == true){
            if(sentconnect == false){
                writeout("NICK GBot");
                writeout("USER GBot GBot GBot :GBot");
                sentconnect = true;
            }
            String data = "";
            try {
                data = in.readLine();
            } catch (IOException e) {
                e.printStackTrace();
            }
            data = data.trim();
            if(data != ""){
                System.out.println("[IN] " + data);
            }
            String[] ex;
            ex = data.split(" ");
            for(String debugex : ex){
                //System.out.println("DEBUGEX: " + debugex);
            }
            if(ex[1] == "001"){
                writeout("JOIN #minecraft");
            }
            try {
                Thread.sleep((long) 0.5);
            } catch (InterruptedException e) {
                e.printStackTrace();
            }
            if(ex[0] == "PING"){
                writeout("PONG " + ex[1]);
            }
        }
    }

    private static void writeout(String msg) {
        out.println(msg);
        System.out.println("[OUT] " + msg);
    }
}

Instead of using `if(condition == true)` just use `if(condition)`. Same for `== false`, except you would use `!condition`. — Jeffrey, May 17 '12 at 22:40
Possible duplicate - [How do I compare strings in Java](http://stackoverflow.com/q/513832/1048330) — tenorsax, May 17 '12 at 22:46
@Max: well, it's only a duplicate once you've figured out what the problem is. — Greg Kopff, May 17 '12 at 22:47

score 2 · Accepted Answer · edited May 23 '17 at 12:27

2

String equality must be tested using String.equals(), not ==.

It should be:

        if(! data.isEmpty()){                     // rather than: data != ""
            System.out.println("[IN] " + data);
        }
        ...
        if(ex[1].equals("001")){                  // rather than: ex[1] == "001"
            writeout("JOIN #minecraft");
        }
        ...
        if(ex[0].equals("PING")){                 // rather than: ex[0] == "PING"
            writeout("PONG " + ex[1]);
        }

See How do I compare strings in Java.

edited May 23 '17 at 12:27

Community

1
1

answered May 17 '12 at 22:41

Greg Kopff

15,945
12
55
78

2

Also, to check empty strings, don´t use `data != ""` use `!data.isEmpty()` – Luiggi Mendoza May 17 '12 at 22:50

Text from the array isn't being read

1 Answers1