Is there a better way to formulate this entity framework 4 update?

Question

I have the following code:

List<Item> csItems = (from i in context.Items
                      where i.CSItem == true
                      select i).ToList<Item>();
csItems.ForEach(i => i.Active = false);
context.SaveChanges();

Seems like this is horribly inefficient as I have to read the entire table in first, then update the tables. Is there a better way to do this so that I am only doing an update without reading everything?

score 2 · Answer 1 · edited May 23 '17 at 11:49

2

Linq2EF doesn't have a built-in bulk update, but you can use Alex James, articles to do it yourself, actually you should implement it yourself. Also simple way is using stored procedures. But if you want to have it yourself you can read all of 4 article series, they are easy to read.

edited May 23 '17 at 11:49

Community

1
1

answered May 22 '12 at 19:11

Saeed Amiri

22,252
5
45
83

score 1 · Accepted Answer · edited May 23 '17 at 12:27

There is no need to build the List<T> of the items. I, personally, would just enumerate the results and set the values:

IQueryable<Item> csItems = (from i in context.Items
                  where i.CSItem == true
                  select i);
foreach(var item in csItems)
     item.Active = false;

context.SaveChanges();

Note that there is no bulk-update functionality built-in with Entity Framework, so doing something more efficient would require some other technique.

Is there a better way to formulate this entity framework 4 update?

2 Answers2