why doesn't my jspSmartUpload code work?

Question

I want to implement an upload component in my servlet file,but it doesn't work. The code episode seems like follows:

SmartUpload smartUpload=new SmartUpload();
StringBuffer stringBuffer=new StringBuffer();
smartUpload.initialize(config,request, response);
try {
     smartUpload.upload();
 File file=smartUpload.getFiles().getFile(0);
 stringBuffer.append(file.getFileName());
 file.saveAs("/upload_resources/"+stringBuffer);
} catch (SmartUploadException e) {
 e.printStackTrace();
}

The upload_resource directory is just under the WebRoot directory,the code runs without any errors ,but the file is just not uploaded. By the way , even I changed the line

file.saveAs("/upload_resources/"+stringBuffer);

to

file.saveAs(request.getRealPath("/upload_resources/")+"/"+stringBuffer);

that is to use an absolute path, the file is not uploaded. Any help will be appreciate. Thanks.

Wow that's a really ancient library. Why exactly have you chosen for SmartUpload? These days with Servlet 3.0 you can just use `request.getPart()`. Otherwise there's always Apache Commons FileUpload which is the defacto standard library to handle file uploads. See also http://stackoverflow.com/questions/2422468/how-to-upload-files-in-jsp-servlet/2424824#2424824 — BalusC, May 31 '12 at 12:46
Thanks for your advice . It works after using Apache Commons FileUpload, It is really awesome — xuqin1019, Jun 01 '12 at 02:55

score 0 · Accepted Answer · answered May 31 '12 at 12:53

I've never really worked with SmartUpload, but I can tell that you shouldn't be saving uploaded files in the webapp's deploy folder. They may all get lost whenever the webapp get redeployed with the simple reason that the uploaded files are not contained in the original WAR file. So you should not prepare the upload folder in the webapp's deploy folder, but on a fixed path outside the deploy folder.

If SmartUpload is well designed, I'd expect that

file.saveAs("/upload_resources/"+stringBuffer);

will save it to the /uploaded_resources folder on the root of the same disk as where the webserver is started from. So in for example Windows that would be C:\uploaded_resources. Prepare and use that folder instead.

Further there's another potential problem when you're using the MSIE browser. This browser namely incorrectly includes the full client side path in the filename. I'm not sure if SmartUpload handles this properly, but you might want to debug the actual value of file.getFileName() and make sure that it's really only the filename in the form of filename.ext. Otherwise, you'd need to use String#substring() to substring the part after the last / and \.

appreciate for your effort to help. good advice to me ,Thanks! — xuqin1019, Jun 01 '12 at 02:56

why doesn't my jspSmartUpload code work?

1 Answers1