WPF UserControl MVVM how to close a dialog

Question

I'm new to MVVM and run into the problem how to open a dialog and close afterwards the dialog in its own ViewModel c#-file. Search for possible solution and found nothing suitable. My solution looks as follows, but I'm not sure if this has some drawbacks. Defined a UserControl and open it with:

void ChangeDataPathExecute()
{
    Window window = new Window
    {
        Content = new ChangeDataRootPathUserControl(),
    };

    window.ShowDialog(); 
}

In the ViewModel of the UserControl file implement:

private void DetermineMyWindow()
{
    foreach (Window window in App.Current.Windows)
    {
        ChangeDataRootPathUserControl uc = window.Content as ChangeDataRootPathUserControl;
        if (uc == null)
            continue;

        myWindow = window;
    }

and finally in the Close method:

void OkChangeDataRootPathExecute()
{
    DetermineMyWindow();

    myWindow.Close();
}

What do you think about this? Hack or good solution? Thanks for feedback Beat

score 2 · Answer 1 · answered May 31 '12 at 16:22

The ViewModel in an MVVM scenario shouldn't have to know anything about the View. In your example, it seems to have to know a lot about the view.

Many people use many different patterns to open/close windows from the ViewModel. I prefer events/callbacks:

class ViewModel {
    public event EventHandler ChangeDataRootPath;
}

class View : Window {
    public View() {
        InitializeComponent();

        var vm = new ViewModel();
        vm.ChangeDataRootPath += (s, e) => {
            Window window = new Window {
                Content = new ChangeDataRootPathUserControl {
                    DataContext = vm
                }
            };
            window.ShowDialog(); 
        };
        DataContext = vm;
    }
}

Thanks for this idea. I would say this is called "code behind" which I try to avoid — Vik, Jun 02 '12 at 09:17

score 1 · Answer 2 · answered May 31 '12 at 16:16

You can access the window more easily by referencing this.Parent from inside the UserControl (as long as it is the first content element).

A more orthodox method for what you're trying to do would be to create a new XAML file for a Window, place an instance of your UserControl inside the Window in the XAML.

If you want your UserControl to be able to close its parent window, then add a simple Close event to the UserControl. Now in your Window XAML you can add an event handler to the close event and have the Window call Close() when the UserControl raises the event.

// UserControl.cs
public event EventHandler Close;

void OkChangeDataRootPathExecute()
{
    if (Close != null)
        Close(this, EventArgs.Empty);
}


// Window.cs
void UserControl_Close(object sender, EventArgs e)
{
    Close();
}

Then if you want to add any extra options or styling you can add it to your XAML, such as SizeToContent, WindowStartupLocation, BorderStyle, etc., to control the look and feel of your dialog.

Then when you want to show your dialog in code, you write it like:

void ChangeDataPathExecute()
{
    var window = new ChangeDataRootPathWindow();

    window.ShowDialog();
}

score 0 · Answer 3 · edited May 23 '17 at 12:23

0

your viewmodel should just open a DialogService. look here to get a starting point.

edited May 23 '17 at 12:23

Community

1
1

answered Jun 01 '12 at 06:19

blindmeis

22,175
7
55
74

Thanks for the link. What I try to avoid there is the line _... do anything with the dialog result..._ in the module creating the dialog. As a beginner I expect to implement this in the close action of the dialog itself – Vik Jun 02 '12 at 09:13

score 0 · Answer 4 · answered Jun 01 '12 at 06:33

In my personal implementations, I don't let my view model to know anything about windows, user controls or any other visual elements. But this needs the definition of a whole framework. There are plenty, just search and use the one that fits you best.

But to a quick solution, if the window you want to close from anywhere is the one that currently has the focus, you can use this method to access it:

public static Window GetCurrentFocusedWindow()
{
    Window window = null;

    Control currentControl = System.Windows.Input.Keyboard.FocusedElement as Control;

    if (currentControl != null)
        window = Window.GetWindow(currentControl);

    return window;
}

Thanks for this. I think that's better – Vik Jun 02 '12 at 09:14 — Vik, Jun 02 '12 at 09:14

score -1 · Answer 5 · answered May 31 '12 at 16:33

-1

If you're going to do MVVM, you'll want an MVVM framework. I recommend Caliburn.Micro, and have a look at its window manager.

answered May 31 '12 at 16:33

devdigital

34,151
9
98
120

score -2 · Answer 6 · answered Nov 13 '13 at 22:25

-2

How about this one?

Window parentWindow = (Window)this.Parent;
parentWindow.Close();

answered Nov 13 '13 at 22:25

inside

3,047
10
49
75

WPF UserControl MVVM how to close a dialog

6 Answers6