Spinner : onItemSelected not called when selected item remains the same

Question

I have a OnItemSelectedListener for my Spinner, but it is not called when the selected item is the same as the previous one. Apparently the OnClickListener is not an option for a Spinner. I need to catch everytime a user click on an item. Any idea?

Maybe the fact that this Spinner is inside the ActionBar disturbs normal behavior?

@Override
public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) {
    inflater.inflate(R.menu.tracklist_menu, menu);
    Spinner spinner = (Spinner) menu.findItem(R.id.option_ordering_spinner)
            .getActionView();
    spinner.setAdapter(mSpinnerAdapter);
    spinner.setSelection(PrefsHelper.getOrderingSpinnerPos(prefs));
    spinner.setOnItemSelectedListener(new OnItemSelectedListener() {

        @Override
        public void onItemSelected(AdapterView<?> parent, View view,
                int position, long id) {
            String str = "selected";
            System.out.println(str);
            if (optionMenuInitialized) {

                switch (position) {
                case 0:
                    // rdm
                    getActivity()
                            .sendBroadcast(
                                    new Intent(
                                            MyIntentAction.DO_RESHUFFLE_PLAYLIST));
                    smp.setCurrentTracklistCursorPos(-1);
                    trackAdapter.notifyDataSetChanged();
                    break;
                case 1:
                    // artist
                    getActivity()
                            .sendBroadcast(
                                    new Intent(
                                            MyIntentAction.DO_ORDER_PLAYLIST_BY_ARTIST));
                    smp.setCurrentTracklistCursorPos(-1);
                    trackAdapter.notifyDataSetChanged();
                    break;
                case 2:
                    // folder
                    getActivity()
                            .sendBroadcast(
                                    new Intent(
                                            MyIntentAction.DO_ORDER_PLAYLIST_BY_FOLDER));
                    smp.setCurrentTracklistCursorPos(-1);
                    trackAdapter.notifyDataSetChanged();
                    break;
                }
                PrefsHelper.setOrderingSpinnerPos(prefEditor, position);
                prefEditor.commit();
            }
            optionMenuInitialized = true;
        }

        @Override
        public void onNothingSelected(AdapterView<?> parent) {
        }
    });
}

Do you read this post http://stackoverflow.com/questions/3928071/android-setting-a-spinner-onclicklistener — Zain Ali, Jun 27 '12 at 13:14
yup, and that didn't help... anyway, I just found the solution, and am about to write it down here =) — elgui, Jun 27 '12 at 13:48
This is not related but setting Spinner visibility to VIEW.GONE also cause this problem. — Megha Maniar, Nov 02 '20 at 10:07

score 90 · Accepted Answer · answered Jun 27 '12 at 13:53

90

Ok, I finally found a solution, by creating my own class extending Spinner :

public class MySpinner extends Spinner {
OnItemSelectedListener listener;

public MySpinner(Context context, AttributeSet attrs) {
    super(context, attrs);
}

@Override
public void setSelection(int position) {
    super.setSelection(position);
    if (listener != null)
        listener.onItemSelected(null, null, position, 0);
}

public void setOnItemSelectedEvenIfUnchangedListener(
        OnItemSelectedListener listener) {
    this.listener = listener;
}
}

answered Jun 27 '12 at 13:53

elgui

3,303
4
28
37

3

Can you share some thoughts on how to achieve the same functionality for ActionBar navigation list? – Alex Semeniuk Mar 07 '13 at 09:56
@benoffi7 Where is your answer ? – dharmendra Jul 05 '13 at 13:31
@dhams Sorry, I make a mistake with my answer and I delete it. – benoffi7 Jul 05 '13 at 17:02
@elgui This line listener.onItemSelected(null, null, position, 0); give me a NPE, can you please tell me how can i get the AdapterView & View to pass in the above line. Thanks – Shrikant Jul 09 '13 at 07:15
@AlexSemeniuk For everyone who wants to reselect an item in the ActionBar spinner, I found a little solution: http://stackoverflow.com/a/22961995/2633814 – blackfizz Apr 09 '14 at 12:07
in my case, onitemselectedlistener returns null and does not work – kaplanfat May 23 '14 at 12:30
Just a comment that may be useful. In case you are using this custom View in an XML layout you should change the tag for – Martillador81 Sep 22 '14 at 13:05
1

How do I get the parent and view in listener.onItemSelected(null, null, position, 0);? – Jesus Almaral - Hackaprende Sep 25 '15 at 22:44
Saved me much time :) Thank you! – Oleksandr Berdnikov Dec 21 '16 at 02:04
I have made a small modification to avoid duplicate events posted in case you've got both listeners: @Override public void setSelection(int position) { int oldSelection = getSelectedItemPosition(); super.setSelection(position); if (this.listener != null && oldSelection == position) { this.listener.onItemSelected(null, null, position, 0); } } – strangetimes May 09 '17 at 00:24
@elgui How do I call this class. Please help me – Bala Raja May 23 '17 at 05:48
To also get the adapter/parent (adapterView) set following instead of null: listener.onItemSelected(this, getSelectedView(), position, 0); @JesusAlmaral-Hackaprende – Franklin84 Jan 16 '22 at 07:22

score 26 · Answer 2 · answered Aug 25 '14 at 02:14

I found out this work instead of the one provided

/** Spinner extension that calls onItemSelected even when the selection is the same as its previous value */
public class NDSpinner extends Spinner {

  public NDSpinner(Context context)
  { super(context); }

  public NDSpinner(Context context, AttributeSet attrs)
  { super(context, attrs); }

  public NDSpinner(Context context, AttributeSet attrs, int defStyle)
  { super(context, attrs, defStyle); }

  @Override public void
  setSelection(int position, boolean animate)
  {
    boolean sameSelected = position == getSelectedItemPosition();
    super.setSelection(position, animate);
    if (sameSelected) {
      // Spinner does not call the OnItemSelectedListener if the same item is selected, so do it manually now
      getOnItemSelectedListener().onItemSelected(this, getSelectedView(), position, getSelectedItemId());
    }
  }

  @Override public void
  setSelection(int position)
  {
    boolean sameSelected = position == getSelectedItemPosition();
    super.setSelection(position);
    if (sameSelected) {
      // Spinner does not call the OnItemSelectedListener if the same item is selected, so do it manually now
      getOnItemSelectedListener().onItemSelected(this, getSelectedView(), position, getSelectedItemId());
    }
  }
}

You will get an NPE if no `OnItemSelectedListener` is set and the same item is selected. — Andrey Makarov, Dec 11 '14 at 12:29
To give credit to the original author: https://stackoverflow.com/a/11323043/3726133 — Raimund Krämer, Oct 28 '20 at 14:46

score 6 · Answer 3 · edited Jun 30 '17 at 22:58

6

To make your spinner change despite the value of the last index selected just use a:

spinner.setSelection(0);

before your other selection is called

spinner.setSelection(number);

this way, the spinner will trigger two times the OnItemSelected event. Just make sure the second time it does whatever you need.

edited Jun 30 '17 at 22:58

Sᴀᴍ Onᴇᴌᴀ

8,218
8
36
58

answered Jun 30 '17 at 22:52

Ramiro G.M.

357
4
7

1

what if the same item position is 0? – V-rund Puro-hit Apr 09 '19 at 06:35
spinner.setSelection(0); if(number!=0) spinner.setSelection(number); – Ramiro G.M. Jun 19 '19 at 03:55

soshial · Answer 4 · 2020-03-13T08:37:47.387

Rewrote the common solution but with:

androidx in mind
extended from AppCompatSpinner
use built-in OnItemSelectedListener listener instead of creating own one
added initial listener call hack

Here:

import android.content.Context;

import androidx.annotation.Nullable;
import androidx.appcompat.widget.AppCompatSpinner;


public class FixedSpinner extends AppCompatSpinner {
    // add other constructors that you need
    public FixedSpinner(Context context, int mode) {
        super(context, mode);
    }

    private void processSelection(int position) {
        boolean sameSelected = position == getSelectedItemPosition();
        final OnItemSelectedListener listener = getOnItemSelectedListener();
        if (sameSelected && listener != null) {
            // Spinner does not call the OnItemSelectedListener if the same item is selected, so do it manually now
            listener.onItemSelected(this, getSelectedView(), position, getSelectedItemId());
        }
    }

    @Override
    public void setSelection(int position) {
        processSelection(position);
        super.setSelection(position);
    }

    @Override
    public void setSelection(int position, boolean animate) {
        processSelection(position);
        super.setSelection(position, animate);
    }

    @Override
    public void setOnItemSelectedListener(@Nullable OnItemSelectedListener listener) {
        // This hack fixes bug, when immediately after initialization, listener is called
        // To make this fix work, first add data, only then set listener
        // Having done this, you may refresh adapter data as many times as you want
        setSelection(0, false);
        super.setOnItemSelectedListener(listener);
    }
}

boolean sameSelected = position == getSelectedItemPosition(); Always TRUE, getSelectedItemPosition() method return the same value as position. — Vishal Yadav, Jul 14 '20 at 11:11

score 5 · Answer 5 · answered Mar 25 '16 at 09:10

Here a little better implementation:

public class SpinnerPlus extends Spinner {
    AdapterView.OnItemSelectedListener listener;

    public SpinnerPlus(Context context, AttributeSet attrs) {
        super(context, attrs);
    }

    @Override
    public void setSelection(int position) {
        super.setSelection(position);
        if (listener != null)
            listener.onItemSelected(this, getSelectedView(), position, 0);
    }

    public void setOnItemSelectedEvenIfUnchangedListener(
            AdapterView.OnItemSelectedListener listener) {
        this.listener = listener;
    }
}

score 5 · Answer 6 · answered Jul 14 '20 at 11:25

Here is a better implementation -

Custom Spinner Class -

import android.content.Context;
import android.util.AttributeSet;
import androidx.appcompat.widget.AppCompatSpinner;

public class CSpinner extends AppCompatSpinner {

    private int lastPosition = 0;

    public CSpinner(Context context, AttributeSet attrs) {
        super(context, attrs);
    }

    @Override
    public void setSelection(int position) {
        super.setSelection(position);
        boolean sameSelected = lastPosition == getSelectedItemPosition();
        OnItemSelectedListener onItemSelectedListener = getOnItemSelectedListener();
        if (sameSelected && onItemSelectedListener != null) {
            onItemSelectedListener.onItemSelected(this, getSelectedView(), position, getSelectedItemId());
        }
        lastPosition = position;
    }
}

Setting Listener -

spn.setOnItemSelectedListener(new AdapterView.OnItemSelectedListener() {
        @Override
        public void onItemSelected(AdapterView<?> parent, View view, int position, long id) {
            Log.d("onItemSelected", String.valueOf(position));
        }

        @Override
        public void onNothingSelected(AdapterView<?> parent) {
            
        }
    });

score 2 · Answer 7 · edited Jul 02 '21 at 07:52

2

If it's still actual, correct call of the callback should be

@Override
public void setSelection(int position) {
    super.setSelection(position);
    if(listener != null)
        listener.onItemSelected(this, getChildAt(position), position, 0);
}

edited Jul 02 '21 at 07:52

Vishal Yadav

3,642
3
25
42

answered Jan 09 '14 at 17:52

Martin Edlman

665
7
15

This is not the correct callback. First, you should use `getItemIdAtPosition(position)` as the last param, at second `getChildAt(position)` should not be used in this case. `Spinner`s use `View` recycling just like `ListView`s, so `getChildAt` cannot be used the retrive the position'th item from the adapter. – WonderCsabo Mar 11 '14 at 18:51
You're right about the last param to get correct ID. But to get view it's fine to use getChildAt() as we either get a correct view if it exists or null if it doesn't. In most cases the code gets called when an item is clicked and thus visible in a spinner, so getChildAt() returns correct view. At least I've never encountered a situation where wrong view was returned. – Martin Edlman Mar 26 '14 at 19:31
1

No, you are not correct. For example, the spinner has 100 items, the last is clicked. But there are only 10 visible. In this case, `getChildAt()` will always return null with 99 position becuase it does not have 100 child `Views`. You cannot rely on `getChildAt()` with any `AdapterView`s. You could call `onItemSelected(this, getSelectedView(), position, getItemIdAtPosition(position));`. – WonderCsabo Mar 27 '14 at 17:05
Maybe I'm mistaken, but do you want to say that getChildAt() returns only views for index 0-9 (for 10 visible items)? I didn't try but it sounds weird. I would expect it should return view from the underlaying adapter for all items in adapter - more specifically it should return view if it's visible or null when it's not. I'll try when I have some spare time which I don't have right now. Spinner with 100 items (index 0-99) will return null when I click 100th item (pos 99)? I don't understand. When I click the last item, then it must be visible and getChildAt(99) must return it. Or not? – Martin Edlman Mar 28 '14 at 18:44
Are you aware of [view recycling](http://lucasr.org/2012/04/05/performance-tips-for-androids-listview/)? There are no `View`s for every item, only some `View`s are added which are necessary. That's why `getChild(99)` will return null. 10 and 99 were only examples, clearly it depends on the current scenario. – WonderCsabo Mar 28 '14 at 22:20

score 1 · Answer 8 · answered Jul 06 '15 at 11:37

1

Simplest solution :

spinner.performItemClick(view,position,id)

answered Jul 06 '15 at 11:37

Nishant Shah

2,022
22
20

score 0 · Answer 9 · answered Jul 22 '19 at 09:51

0

I had same problem, I solved it by setting onItemSelectedListener every time adapter changes items.

answered Jul 22 '19 at 09:51

Marek Kondracki

1,372
2
8
13

LXJ · Answer 10 · 2021-11-27T19:06:35.033

Further from the answer from @Vishal Yadav, if you want to set an initial position without triggering the OnItemSelectedListener by calling spinner.setSelection(pos, false); then the custom spinner should be:

public class CSpinner extends AppCompatSpinner {

    private int lastPosition = 0;

    public CSpinner(Context context, AttributeSet attrs) {
        super(context, attrs);
    }

    @Override
    public void setSelection(int position, boolean animate) {
        OnItemSelectedListener listener = getOnItemSelectedListener();
        setOnItemSelectedListener(null);
        super.setSelection(position, animate);
        lastPosition = position;
        setOnItemSelectedListener(listener);
    }

    @Override
    public void setSelection(int position) {
        super.setSelection(position);
        boolean sameSelected = lastPosition == getSelectedItemPosition();
        OnItemSelectedListener onItemSelectedListener = getOnItemSelectedListener();
        if (sameSelected && onItemSelectedListener != null) {
            onItemSelectedListener.onItemSelected(this, getSelectedView(), position, getSelectedItemId());
        }
        lastPosition = position;
    }
}

score -1 · Answer 11 · answered May 17 '20 at 11:44

-1

i found a simple solution

just call setAdapter again in place of notifyDataSetChanged for the second spinner

answered May 17 '20 at 11:44

Abhishek Vishwakarma

139
1
4

Spinner : onItemSelected not called when selected item remains the same

11 Answers11

Linked

Related