Which is better?

Question

which one of the following is better?

<c:set var="var1" value="false" scope="request"/>
<c:if test="${someCondition}">
    <c:set var="var1" value="true" scope="request"/>
</c:if>

Or the following

<c:choose>
    <c:when test="${someCondition}">
        <c:set var="var1" value="true" scope="request"/>
    </c:when>
    <c:otherwise>
        <c:set var="var1" value="false" scope="request"/>
    <c:otherwise>
</c:choose>

score 5 · Accepted Answer · answered Jun 18 '12 at 20:10

5

Neither, this looks best for me:

<c:set var="var1" value="${someCondition}" scope="request"/>

answered Jun 18 '12 at 20:10

Tomasz Nurkiewicz

334,321
69
703
674

2

I agree this is easier if the value to be set is a Boolean. But I used boolean as an example here. what if we are setting non-boolean values? – user624558 Jun 18 '12 at 20:13
Use what you find the clearer. – JB Nizet Jun 18 '12 at 21:34

score 2 · Answer 2 · answered Jun 18 '12 at 20:09

2

The first, because it is more concise.

answered Jun 18 '12 at 20:09

Ned Batchelder

364,293
75
561
662

score 1 · Answer 3 · answered Jun 18 '12 at 21:35

1

I'd do what Tomasz suggested. If you have different values rather than booleans, you can use a ternary statement:

<c:set var="var1" value="${someCondition == 'someValue' ? 'valueA' : 'valueB'}" scope="request"/>

answered Jun 18 '12 at 21:35

alextiley

31
1
5

Which is better?

3 Answers3

Linked