Rails 3 Contact Form, undefined method?

Question

I'm building a contact form in Rails 3 using this Railscast: http://railscasts.com/episodes/326-activeattr?view=asciicast

I know that the only thing I'm doing wrong is filling out where the message should be sent. I used the following code to send the message:

mail(:to => "me@myemail.com")

However, this doesn't seem to work, because everytime I submit the form, I get this error:

NoMethodError in MessagesController#create

undefined method `mail' for #<MessagesController:0x00000103734bd8>

Application Trace | Framework Trace | Full Trace
app/controllers/messages_controller.rb:10:in `create'

What should I replace this line with to send the message?

messages_controller.rb

class MessagesController < ApplicationController

  def new
    @message = Message.new
  end

  def create
    @message = Message.new(params[:message])
    if @message.valid?
      UserMailer.contact_message(@message).deliver
      redirect_to root_url, notice: "Message sent! Thank you for contacting us."
    else
      render "new"
    end
  end

end

user_mailer.rb

class UserMailer < ActionMailer::Base

def contact_message(message)
@message = message
mail(:to => "myemail@mymail.com", :subject => "New Message")
end

end

setup_mail.rb

ActionMailer::Base.smtp_settings = {
:address              => "smtp.gmail.com",
:port                 => 587,
:domain               => "mywebsite.com",
:user_name            => "myemail",
:password             => "secret",
:authentication       => "plain",
:enable_starttls_auto => true
}

ActionMailer::Base.default_url_options[:host] = "localhost:3000"

http://guides.rubyonrails.org/action_mailer_basics.html – vellvisher Jun 22 '12 at 17:39 — vellvisher, Jun 22 '12 at 17:39
You have an application controller and not an Action Mailer – vellvisher Jun 22 '12 at 17:40 — vellvisher, Jun 22 '12 at 17:40

score 0 · Answer 1 · answered Jun 22 '12 at 17:52

there's no object created on the mail variable on your controller. Actualy to user Mailer on rails you don't have to instantiate a variable just call you mailer with the method. Like:

YourMailer.send(params)

You can always go to rails guides to see how some stuff works: http://guides.rubyonrails.org/action_mailer_basics.html

score 0 · Answer 2 · answered Jun 22 '12 at 17:53

0

The Message object you're creating is just an object that can be used in a form with validations. You still need to actually create a Mailer object, and fill it with the name/email/message that you get from the @message object.

If you create a Mailer (see Episode 206 - Action Mailer), and you'd do something like this in your controller after creating a MessageMailer

def create
  if @message.valid?
    MessageMailer.contact_message(@message).deliver
    redirect_to root_url, notice: "Message sent! Thank you for contacting us."
  else
    render "new"
  end
end

answered Jun 22 '12 at 17:53

Jesse Wolgamott

40,197
4
83
109

https://github.com/plataformatec/mail_form is awesome -- takes the concept one step and combines into one class. – Jesse Wolgamott Jun 22 '12 at 17:57
OK...I followed your advice and watched Episode 206. I've added the changes I've made above. When I submit the contact form now, it successfully redirects to the home page, but no email is sent to me, and there is no notice stating that the message was sent. What am I missing? – user1429496 Jun 22 '12 at 21:41
Change this to true in your config/environments/development.rb to see if any failures are occurring: `config.action_mailer.raise_delivery_errors = true` – Jesse Wolgamott Jun 23 '12 at 16:45

score 0 · Answer 3 · edited May 23 '17 at 12:13

0

I just answered a similar question here: https://stackoverflow.com/a/17883328/307308

You are missing the from attribute in your mail method.

mail(:from => 'system@mymail.com', :to => "myemail@mymail.com", :subject => "New Message")

edited May 23 '17 at 12:13

Community

1
1

answered Jul 27 '13 at 02:52

scarver2

7,887
2
53
61

Rails 3 Contact Form, undefined method?

3 Answers3

Linked