Is using foreach over an HttpContext.Current inside a static method thread safe?

Question

Keeping these in mind

I'm having trouble wrapping my head around this... Is this code "thread safe" in ASP.NET?

public static bool IsCookieMissing()
{
    foreach (string cookieKey in HttpContext.Current.Request.Cookies.AllKeys)
    {
        if (cookieKey.EndsWith("cookie_name"))
        {
            return false;
        }
    }
    return true;
}

score 4 · Answer 1 · edited Jan 06 '22 at 15:15

Technically, yes, this code is thread-safe.

HttpContext.Current returns the context associated with the current request. Although IIS might use several threads to handle a given request (thread agility), it will not run these threads in parallel (it will only switch threads during asynchronous I/O).

Therefore, no more than one thread will access HttpContext.Current.Request.Cookies at the same time, and you don't need locking here.

score 2 · Accepted Answer · edited May 23 '17 at 10:09

2

Is this code "thread safe" in ASP.NET?

That depends on what you expect it to do. It most likely does what you expect to do, so it is "thread safe", unless you are starting your own threads that are calling it. HttpContext.Current is the Current HttpContext at which time it was called. Your concern about the issues in this question that you linked to aren't needed - you aren't using any closures.

edited May 23 '17 at 10:09

Community

1
1

answered Jun 25 '12 at 14:44

vcsjones

138,677
31
291
286

good point about starting your own threads. My code does implement that pattern to do various utility tasks within ASP.NET. – felickz Jul 11 '12 at 13:16

Is using foreach over an HttpContext.Current inside a static method thread safe?

2 Answers2