39

I'm not completely sure how to do this in C:

char* curToken = strtok(string, ";");
//curToken = "ls -l" we will say
//I need a array of strings containing "ls", "-l", and NULL for execvp()

How would I go about doing this?

Jordan
  • 2,070
  • 6
  • 24
  • 41

2 Answers2

67

Since you've already looked into strtok just continue down the same path and split your string using space (' ') as a delimiter, then use something as realloc to increase the size of the array containing the elements to be passed to execvp.

See the below example, but keep in mind that strtok will modify the string passed to it. If you don't want this to happen you are required to make a copy of the original string, using strcpy or similar function.

char    str[]= "ls -l";
char ** res  = NULL;
char *  p    = strtok (str, " ");
int n_spaces = 0, i;


/* split string and append tokens to 'res' */

while (p) {
  res = realloc (res, sizeof (char*) * ++n_spaces);

  if (res == NULL)
    exit (-1); /* memory allocation failed */

  res[n_spaces-1] = p;

  p = strtok (NULL, " ");
}

/* realloc one extra element for the last NULL */

res = realloc (res, sizeof (char*) * (n_spaces+1));
res[n_spaces] = 0;

/* print the result */

for (i = 0; i < (n_spaces+1); ++i)
  printf ("res[%d] = %s\n", i, res[i]);

/* free the memory allocated */

free (res);

res[0] = ls
res[1] = -l
res[2] = (null)
Filip Roséen - refp
  • 62,493
  • 20
  • 150
  • 196
  • 1
    @JordanCarney glad to be of service. – Filip Roséen - refp Jun 25 '12 at 23:20
  • @FilipRoséen-refp Can you explain the last code block before the printing and freeing the memory, the: `/* realloc one extra element for the last NULL */`? I'm having difficulty understanding it – Honinbo Shusaku Oct 16 '15 at 20:49
  • @Abdul I believe usually there is a null character at the end of each array so that the computer can differentiate between two different arrays. – Charles Nov 18 '15 at 13:42
  • if I wrap this into a function and return the `res` pointer, I get a warning after freeing the pointer I assigned `res` to, saying: `warning: attempt to free a non-heap object [-Wfree-nonheap-object]`. Do you have any insight of the cause? – MattSom May 02 '20 at 09:23
6

Here is an example of how to use strtok borrowed from MSDN.

And the relevant bits, you need to call it multiple times. The token char* is the part you would stuff into an array (you can figure that part out).

char string[] = "A string\tof ,,tokens\nand some  more tokens";
char seps[]   = " ,\t\n";
char *token;

int main( void )
{
    printf( "Tokens:\n" );
    /* Establish string and get the first token: */
    token = strtok( string, seps );
    while( token != NULL )
    {
        /* While there are tokens in "string" */
        printf( " %s\n", token );
        /* Get next token: */
        token = strtok( NULL, seps );
    }
}
Chris O
  • 5,017
  • 3
  • 35
  • 42