Read lines of numbers from a file to a 2d array using a for loop

Question

I want to read lines of numbers from a file. The code is as follows but the IDE shows NullPointerException runtime exception. Not sure what I am doing wrong.

//reading the contents of the file into an array
public static void readAndStoreNumbers() {
    //initialising the new object
    arr = new int[15][];

    try {
        //create file reader
        File f = new File("E:\\Eclipse Projects\\triangle.txt");
        BufferedReader br = new BufferedReader(new FileReader(f));

        //read from file
        String nums;
        int index = 0;
        while ((nums = br.readLine()) != null) {
            String[] numbers = nums.split(" ");

            //store the numbers into 'arr' after converting into integers
            for (int i = 0; i < arr[index].length; i++) {
                arr[index][i] = Integer.parseInt(numbers[i]);
            }
            index++;
        }
    } catch (IOException e) {
        e.printStackTrace();
    }
}

I would rather us a simple `List` of `List`, with index being the line number and value being the ints. — , Jun 26 '12 at 05:05

score 5 · Answer 1 · answered Jun 26 '12 at 04:55

5

Your second dimension of arr is uninitialized, and you are invoking

arr[index].length

answered Jun 26 '12 at 04:55

jmj

237,923
42
401
438

score 1 · Answer 2 · edited May 23 '17 at 11:48

You could be running into an NPEX for two reasons.

You don't finish your definition of arr - it's not evident in your code that you declare arr as int arr[][];
Even if you had the above, you wouldn't have set aside space for your second array. What you have now is a jagged array; you can have elements of whatever length in the second dimension you wish in your second array.

The only modification I made to your code to get it to work would be the following line:
```
arr[index] = new int[numbers.length];
```
...after pulling elements into numbers, and before entering the loop.

score 0 · Answer 3 · edited Apr 10 '21 at 00:08

I think you should use StringBuilder..

//reading the contents of the file into an array
public static void readAndStoreNumbers() {
    //initialising the StringBuffer 
    StringBuilder sb = new StringBuilder();

    try {
        //create file reader
        File f = new File("E:\\Eclipse Projects\\triangle.txt");
        BufferedReader br = new BufferedReader(new FileReader(f));

        //read from file
        String nums;
        int index = 0;
        while ((nums = br.readLine()) != null) {
            String[] numbers = nums.split(" ");

            //store the numbers into 'arr' after converting into integers
            for (int i = 0; i < arr[index].length; i++) {
                sb.append(Integer.parseInt(numbers[i])).append("\n");
            }
        }
    } catch (IOException e) {
        e.printStackTrace();
    }
}

score 0 · Answer 4 · answered Jun 26 '12 at 05:06

0

you need to change -

for(int i=0; i<arr[index].length; i++) {

to

arr[index] = new int[numbers.length];
for (int i = 0; i < numbers.length; i++) {

answered Jun 26 '12 at 05:06

Kshitij

8,474
2
26
34

score 0 · Answer 5 · answered Jun 26 '12 at 05:13

Java doesn't have real multidimensional arrays. What you are using is actually an array of int arrays: new int[n][] actually creates an array with room for n objects of type int[].

Consequently you will have to initialize each of those int arrays separately. That would have been obvious from the fact that you never actually specified the length of the second dimension anywhere in your program.

Read lines of numbers from a file to a 2d array using a for loop

5 Answers5