Shortest way to check for null and assign another value if not

Question

I am pulling varchar values out of a DB and want to set the string I am assigning them to as "" if they are null. I'm currently doing it like this:

if (string.IsNullOrEmpty(planRec.approved_by) == true)
  this.approved_by = "";
else
  this.approved_by = planRec.approved_by.toString();

There seems like there should be a way to do this in a single line something like:

this.approved_by = "" || planRec.approved_by.toString();

However I can't find an optimal way to do this. Is there a better way or is what I have the best way to do it?

The == true is superfluous here... – cjk Jul 13 '09 at 16:35 — cjk, Jul 13 '09 at 16:35

score 146 · Accepted Answer · edited May 09 '23 at 01:58

146

Try this:

this.approved_by = IsNullOrEmpty(planRec.approved_by) ? string.Empty : planRec.approved_by.toString();

You can also use the null-coalescing operator as other have said - since no one has given an example that works with your code here is one:

this.approved_by = planRec.approved_by ?? planRec.approved_by.toString();

But this example only works since a possible value for this.approved_by is the same as one of the potential values that you wish to set it to. For all other cases you will need to use the conditional operator as I showed in my first example.

edited May 09 '23 at 01:58

Flimtix

356
1
4
17

answered Jul 13 '09 at 16:29

Andrew Hare

344,730
71
640
635

11

Doesn't this null coalescing operator throw a nullreference anyways? The way I see this code does the following: `if (planRec.approved_by == null) { this.approved_by = planRec.approved_by.toString(); //<= nullref } else { this.approved_by = planRec.approved_by;}`. If I'm wrong please point out the error. – Destrictor Feb 19 '13 at 08:18
15

@Destrictor is right, the code is broken. Here's a fix using another fun operator: `this.approved_by = planRec.approved_by?.toString() ?? "";` <- That's the null-conditional operator, and I don't think it was around when this question was first asked and answered. Hopefully OP sees this, so he can go refactor his 7 year old code, from two jobs ago :) . – Patrick Jul 20 '16 at 05:56
I could swear I've seen some kind of syntax that lets you assign to an attribute of an object if that object isn't null, like someObject?.someAttribute = value; but I can't seem to find anything like that. – Shavais Oct 20 '21 at 22:28

score 78 · Answer 2 · edited Feb 01 '23 at 12:39

78

Starting with C# 8.0, you can use the ??= operator to replace the code of the form

if (variable is null)
{
    variable = expression;
}

with the following code:

variable ??= expression;

More information is here

edited Feb 01 '23 at 12:39

phoenix

7,988
6
39
45

answered Oct 07 '19 at 12:55

nzrytmn

6,193
1
41
38

Is there a VB.net version of this? – Le-roy Staines May 28 '21 at 12:00
3

Be awesome if you could extend this with conditional access as well eg variable1.variable2?.variable3 ??= value; – rollsch Mar 16 '22 at 03:15

score 61 · Answer 3 · answered Jul 13 '09 at 16:31

61

You are looking for the C# coalesce operator: ??. This operator takes a left and right argument. If the left hand side of the operator is null or a nullable with no value it will return the right argument. Otherwise it will return the left.

var x = somePossiblyNullValue ?? valueIfNull;

answered Jul 13 '09 at 16:31

JaredPar

733,204
149
1,241
1,454

This answer does not cover the all cases from the question (only partially). Notice, that there is "string.IsNullOrEmpty". So Empty case is not handled here. – Bronek Jan 23 '20 at 10:43
2

upvoted because this was the answer I was looking for. (I just needed the null check) – edank Jan 26 '21 at 06:16

score 41 · Answer 4 · answered Jul 13 '09 at 16:29

41

The coalesce operator (??) is what you want, I believe.

answered Jul 13 '09 at 16:29

Dave Ward

59,815
13
117
134

4

Yep...but only because the default is "". – Paul Alexander Jul 13 '09 at 16:31
2

Um, how so? One can use any expression to replace null with.. – TaW Aug 19 '20 at 19:45

score 30 · Answer 5 · answered Jul 13 '09 at 16:33

My guess is the best you can come up with is

this.approved_by = IsNullOrEmpty(planRec.approved_by) ? string.Empty
                                                      : planRec.approved_by.ToString();

Of course since you're hinting at the fact that approved_by is an object (which cannot equal ""), this would be rewritten as

this.approved_by = (planRec.approved_by ?? string.Empty).ToString();

score 26 · Answer 6 · answered Jul 07 '16 at 15:06

26

With C#6 there is a slightly shorter way for the case where planRec.approved_by is not a string:

this.approved_by = planRec.approved_by?.ToString() ?? "";

answered Jul 07 '16 at 15:06

Malcolm

1,239
1
14
25

score 25 · Answer 7 · edited May 15 '19 at 20:51

25

Use the C# coalesce operator: ??

// if Value is not null, newValue = Value else if Value is null newValue is YournullValue
var newValue = Value ?? YourNullReplacement;

edited May 15 '19 at 20:51

Nova Ardent

161
1
16

answered Jul 17 '17 at 01:57

Ramgy Borja

2,330
2
19
40

score 13 · Answer 8 · edited May 23 '17 at 12:03

13

To extend @Dave's answer...if planRec.approved_by is already a string

this.approved_by = planRec.approved_by ?? "";

edited May 23 '17 at 12:03

Community

1
1

answered Jul 13 '09 at 16:33

Paul Alexander

31,970
14
96
151

I'm not sure why this answer is the 8th most voted :/ – tymtam Apr 25 '21 at 06:43

score 3 · Answer 9 · edited Nov 28 '17 at 17:36

To assign a non-empty variable without repeating the actual variable name (and without assigning anything if variable is null!), you can use a little helper method with a Action parameter:

public static void CallIfNonEmpty(string value, Action<string> action)
{
    if (!string.IsNullOrEmpty(value))
        action(value);
}

And then just use it:

CallIfNonEmpty(this.approved_by, (s) => planRec.approved_by = s);

score 3 · Answer 10 · answered Sep 23 '21 at 12:13

3

The accepted answer was correct in time, when it was given.

For people still finding this question: Today you can use the ??= Operator.

e.g:

private string _test = null;

private void InitIfNull(){
 _test ??= "Init";
}

answered Sep 23 '21 at 12:13

Steav

1,478
13
28

score 1 · Answer 11 · edited May 26 '13 at 18:26

1

You can also do it in your query, for instance in sql server, google ISNULL and CASE built-in functions.

edited May 26 '13 at 18:26

Taryn

242,637
56
362
405

answered Jul 13 '09 at 17:19

user133371

323
2
6
18

score -4 · Answer 12 · answered Nov 05 '15 at 23:47

-4

I use extention method SelfChk

static class MyExt {
//Self Check 
 public static void SC(this string you,ref string me)
    {
        me = me ?? you;
    }
}

Then use like

string a = null;
"A".SC(ref a);

answered Nov 05 '15 at 23:47

Ali Humayun

1,756
1
15
12

1

I guess you mean but not easy to read and understand, is that so? – Ali Humayun Sep 01 '17 at 20:58
4

Ups! You are absolutely right: Very short, but NOT easy to read and understand (at least if you are not used to this notation) – Jack Miller Sep 02 '17 at 16:34

Shortest way to check for null and assign another value if not

12 Answers12

Linked

Related