insertion of system date and time into mysql table in their respective fields

Question

i am not new to php but facing a problem of very basic level but dont know how to overcome it. i have a table for comments in which fields are name ,email, comment, date and time. now what i want to do is to insert system date and time in their respective fields but it only enters time not date. the types of field date is date and of time is time. here is my query

 $insert = 'insert into tbl_comment 
      (name, email, desc, date, time)
      VALUES 
 ("'.$_POST['name'].'","'.$_POST['email'].'","'.$_POST['comment'].'"
 ,CURDATE(),"CURTIME()",CURTIME())';   
      mysql_query($insert);
 }

plz help me out

why you have date and time as different column? one column with data type as datetime or timestamp would have done... — Fahim Parkar, Jun 27 '12 at 11:08
infact i need them separate according to the requirments of client — Kashif Waheed, Jun 27 '12 at 11:10

score 0 · Answer 1 · edited May 23 '17 at 11:56

0

Your code is vulnerable to SQL injection. Fix this immediately!

//Function to sanitize values received from the form. Prevents SQL injection
function clean($str) {
    $str = @trim($str);
    if(get_magic_quotes_gpc()) {
        $str = stripslashes($str);
    }
    return mysql_real_escape_string($str);
}

$myName = clean($_POST['name']);
$myEmail = clean($_POST['email']);
$myDesc = clean($_POST['comment']);
$insert = "insert into tbl_comment 
           (name, email, desc, `date`, `time`)
           VALUES 
           ('$myName','$myEmail','$myDesc',CURDATE(),CURTIME())";   
mysql_query($insert);

If you have data & time as field name, use backticks as they are reserved keywords.

Also read, how to insert data in PHP/ MySQL

edited May 23 '17 at 11:56

Community

1
1

answered Jun 27 '12 at 11:11

Fahim Parkar

30,974
45
160
276

i tried this as well before but it also not working i dont know why – Kashif Waheed Jun 27 '12 at 11:18
@KashifWaheed : What error are you getting? Also see my updated answer with backticks... – Fahim Parkar Jun 27 '12 at 11:27
dear the resulting query is wrong and once query is wrong then its impossible to insert data into the table thats the error – Kashif Waheed Jun 27 '12 at 11:35
@KashifWaheed : can u type `echo $insert` before mysql_query and let me know what you get? – Fahim Parkar Jun 27 '12 at 11:46
@KashifWaheed : also are you using backticks ` as I suggested?? – Fahim Parkar Jun 27 '12 at 11:48

insertion of system date and time into mysql table in their respective fields

1 Answers1