How to improve this code using c#

Question

Possible Duplicate:
Is there a simpler way to do this if statement in C#

I have this code:

while ((txtSource.Text[startPos].ToString() == " ") || 
       (txtSource.Text[startPos].ToString() == ",") || 
       (txtSource.Text[startPos].ToString() == ".")))
        {
            // do something
        }

is there any way to do the above like for instance:

while (!txtSource.Text[startPos].ToString() in (" ",",","."))

Instead of doing `.ToString()`, just do `txtSource.Text[startPos] == ','` (with single quotes). Also consider using a switch statement. — Matthew, Jul 06 '12 at 13:51
ok, let's say that to shorten the code, to make it clearer :) — Somebody, Jul 06 '12 at 13:52
@Somebody - The code is already clear. Why do you want to make it more complicated? If the code does what you want, what exactly is the problem, sometimes simple is better. — Security Hound, Jul 06 '12 at 14:00
@Ramhound don't be silly. Every solution is better when complicated with LINQ! — jrummell, Jul 06 '12 at 14:06

score 7 · Accepted Answer · answered Jul 06 '12 at 13:53

7

while ((new char[] {' ', ',', '.'}).Contains(txtSource.Text[startPos]))

answered Jul 06 '12 at 13:53

Steven Doggart

43,358
8
68
105

score 5 · Answer 2 · answered Jul 06 '12 at 13:52

5

LINQ Any() for help:

string text = "some text";
char[] controlChars = { ' ', ',', '.' };
int index = 1;
bool passed = controlChars.Any(c => c == text[index]);

answered Jul 06 '12 at 13:52

sll

61,540
22
104
156

While I question the reasons the author wants a "better" way to improve their code, this is an elegant solution, and does provide some clarity to the code. – Security Hound Jul 06 '12 at 14:02

score 4 · Answer 3 · answered Jul 06 '12 at 13:53

4

string[] SearchList =  {" ",",","."};

while (SearchList.Contains(txtSource.Text[startPos].ToString() ))
{
   // Do Something
}

answered Jul 06 '12 at 13:53

David

72,686
18
132
173

Nice David! thank you :) – Somebody Jul 06 '12 at 13:56
I like @SteveDog's format better, though. He did the same thing in one line of code, and (more properly than my answer) used chars, which also shortened it up and eliminate the need for .ToString(). – David Jul 06 '12 at 14:03

Guillaume · Answer 4 · 2012-07-06T14:03:47.013

4

private static bool IsStopChar(char c)
{
  switch (c)
  {
    case ' ':
    case ',':
    case '.':
      return false;
    default:
      return true;
  }
}

//...

  while (!IsStopChar(txtSource.Text[startPos]))
  {
    //...
  }

With this solution you avoid collection iteration, memory allocation, initialization,... Modifying cases remains easy.

edited Jul 06 '12 at 14:03

answered Jul 06 '12 at 13:56

Guillaume

12,824
3
40
48

1

-1 need moar LINQ! Just kidding, I upvoted ... this is very straight forward and readable. Shorter is not always better. – jrummell Jul 06 '12 at 14:09

How to improve this code using c#

4 Answers4