Ruby on Rails: Form Error

Question

I have a form which takes users information and stores it in the database. For some of the fields the user can put new information in a field, or select previous info from the database. It was working earlier, however I recently cleaned the database and now I get this error when I try to access the page.

undefined method `empty?' for nil:NilClass

Extracted source (around line #27):

27: <%= f.select( :client, Project.all.map {|p| [p.client]}.uniq!, :prompt => "Select a previous Client") %>

Form view example:

<div class="field">
<%= label_tag :new_client, "Client" %><br/>
<%= text_field_tag :new_client %>
Or
<%= f.select( :client, Project.all.map {|p| [p.client]}.uniq!, :prompt => "Select a previous Client") %>
</div>

Project Controller:

def create
@project = Project.new(params[:project])


@project.client = params[:new_client] unless params[:new_client].empty?
@project.exception_pm = params[:new_exception_pm] unless params[:new_exception_pm].empty?
@project.project_owner = params[:new_project_owner] unless params[:new_project_owner].empty?
@project.role = params[:new_role] unless params[:new_role].empty?
@project.industry = params[:new_industry] unless params[:new_industry].empty?
@project.business_div = params[:new_business_div] unless params[:new_business_div].empty?

respond_to do |format|
  if @project.save
    format.html { redirect_to @project, notice: 'Project was successfully created.' }
    format.json { render json: @project, status: :created, location: @project }
  else
    format.html { render action: "new" }
    format.json { render json: @project.errors, status: :unprocessable_entity }
  end
end
end

UPDATE:

I think the error is coming from the .uniq! method in my form view. Any other ideas?

Thanks

Have you tried outputting the params variables to see which one is nil? Put this on a line above the first `params[...].empty?` call: `logger.debug "--- params[:new_client]: #{params[:new_client]}, params[:new_exception_pm]: #{params[:new_exception_pm]}, params[:new_project_owner]: #{params[:new_project_owner]}, params[:new_role]: #{params[:new_role]}, params[:new_industry]: #{params[:new_industry]}, params[:new_business_div]: #{params[:new_business_div]}"`. Also, you should consider using `.blank?`. See [http://stackoverflow.com/a/888877/664833](http://stackoverflow.com/a/888877/664833) — user664833, Jul 18 '12 at 16:25

score 1 · Answer 1 · answered Jul 18 '12 at 19:04

1

You should use blank? method instead of empty?

answered Jul 18 '12 at 19:04

Alexandr Yakubenko

564
4
6

I tried your suggestion and the error still reads the same, even though I changed all `empty?` to `blank?` – Jazz Jul 19 '12 at 08:12
I now see it was to do with the `.uniq!`. I changed it to `uniq`, which seems to work, and I left your suggestion in. Thanks – Jazz Jul 19 '12 at 08:46

score 0 · Answer 2 · answered Jul 18 '12 at 16:17

0

You don't have any projects to map into your drop down.

Add a project and you should be ok.

answered Jul 18 '12 at 16:17

Edward

3,429
2
27
43

I thought that so I tried adding two. Didn't seem to make a difference. Cheers anyway – Jazz Jul 18 '12 at 16:18
Instead of your `unless empty?` tests try `unless(params.has_key?(:new_client)` etc – Edward Jul 18 '12 at 16:26
I should maybe have mentioned that I am brand new to Ruby on Rails – Jazz Jul 18 '12 at 16:29

score 0 · Accepted Answer · answered Jul 19 '12 at 10:16

0

I changed from using uniq! to uniq.

That seemed to solve the problem.

answered Jul 19 '12 at 10:16

Jazz

1,090
6
23
55

Ruby on Rails: Form Error

3 Answers3