Right click setIcon() to mark bomb - Minesweeper

Question

I am pretty new to programming and am trying to make a Minesweeper GUI. The game worked perfectly right clicking a JToggleButton displayed a "B" for bomb on the button, but when I replaced the setText() with setIcon() in the mouselistener it shows the icon when both left and right clicking occurs. I didn't have this problem when setText().

    public void mousePressed(MouseEvent e){
        if(e.isMetaDown())
            if(btnPresses == 0)
            {
                startTime = System.currentTimeMillis();
                btnPresses++;
            }
            //if(btn[y][x].getText().equals("B"))
            if(btn[y][x].getIcon()==flag)
            {
                //btn[y][x].setText("");
                btn[y][x].setIcon(null);
                if(bombs[y][x]!=BOMB)
                    markers++;
            }
            else
            {
                //btn[y][x].setText("B");
                btn[y][x].setIcon(flag);
                if(bombs[y][x]==BOMB)
                    markers++;
                else
                    markers--;
            }

I added a btn[y][x].setIcon(null) to the actionlistener, which causes the flag icon to appear only briefly when left clicking but I'd rather it not appear at all.

score 2 · Accepted Answer · answered Jul 20 '12 at 01:20

2

You need to distinguish between a left mouse button click, MouseEvent.BUTTON3, and a right mouse button click, MouseEvent.BUTTON3, and then act accordingly. For example, when I did something like this, I set the "flag" boolean in my model (using MVC) via:

@Override
public void mousePressed(MouseEvent e) {
   if (e.getButton() == MouseEvent.BUTTON3) {
      model.upDateButtonFlag();
   }
}

The MouseListener should be used only to set or unset the flag. Otherwise you should have your JButton respond via its ActionListener for left button clicks.

answered Jul 20 '12 at 01:20

Hovercraft Full Of Eels

283,665
25
256
373

OMG! I forgot the braces under the "if(e.isMetaDown)" – A H Jul 20 '12 at 01:27
1

@AH: yes, *all* blocks should be enclosed in curly braces, even one line blocks. Make this a habit now. – Hovercraft Full Of Eels Jul 20 '12 at 01:29
1

+1 example by using [SwingUtilities.isRightMouseButton](http://stackoverflow.com/a/9369476/714968) – mKorbel Jul 20 '12 at 07:20
Good catch! Many IDEs can highlight such vagaries – trashgod Jul 21 '12 at 17:40

score 0 · Answer 2 · answered Jul 20 '12 at 01:00

0

Add a System.err.println("" + System.currentTimeMillis() + " " + e); to the beginning of your handler. I strongly suspect your code is being called more times than you think - as a single click can generate multiple events. Once you know what is going on, it should be easy to fix.

answered Jul 20 '12 at 01:00

tucuxi

17,561
2
43
74

Tried this line and it is outputting only one event per click. Output: "1342746827280 java.awt.event.MouseEvent[MOUSE_PRESSED,(40,17),absolute(295,191),button=1,modifiers=Button1,extModifiers=Button1,clickCount=1] on javax.swing.JToggleButton..." – A H Jul 20 '12 at 01:21

Right click setIcon() to mark bomb - Minesweeper

2 Answers2