1

I am building the server part of a webapp, using node.js. This involves getting data from thetvdb.com (API documentation of thetvdb). The data comes as a zip file. HTTP download is no problem, however, parsing the file is. I actually never save the file, but just keep it in memory, as suggested in How to download and unzip a zip file in memory in NodeJs?

I have a buffer with valid data (same data as when I download the file with browser/curl...). However, adm-zip (I also tired other zip libraries, some suggest invalid zip length) can't open it. It does not show an error, but the zipEntries in the end have length of 0. When I write out the buffer to the filesystem and open it with gui or cli tools it works.

I can't give a direkt link to the file, as it would involve my API key, however I re-uploaded it here.

Community
  • 1
  • 1
Marc Fischer
  • 1,296
  • 1
  • 13
  • 16
  • Add some code of how you're using `adm-zip`. Your problem might be that you're unzipping in `on('data', ...)` and not waiting for `on('end', ...)`, but we'll need to see some code to help you. – rdrey Jul 30 '12 at 14:40
  • I use the same code as in the accepted answer in the other question I linked. (http://stackoverflow.com/questions/10359485/how-to-download-and-unzip-a-zip-file-in-memory-in-nodejs) – Marc Fischer Jul 30 '12 at 14:49

1 Answers1

1

I think I might have an answer for you:

Don't rely on npm install. I just ran the example that you linked to with the zip file you provided, and I get an output of "0".

I saw a comment on that other StackOverflow page, saying that the version of adm-zip on npm is not up to date. I grabbed a fresh copy of adm-zip from github, overwrote the one in my node_modules folder and reran the example code and now get the following:

...
<Actor>
  <id>237811</id>
  <Image>actors/237811.jpg</Image>
  <Name>Peter Pratt</Name>
  <Role>The Master</Role>
  <SortOrder>3</SortOrder>
</Actor>
<Actor>
  <id>23780s/237811.jpg</Image>

Give that a shot!

Community
  • 1
  • 1
rdrey
  • 9,379
  • 4
  • 40
  • 52
  • I wish `npm install https://github.com/cthackers/adm-zip.git` worked, but it fails on both my work laptop (Windows) and now at home (Mac). So for now, you'll just have to manually copy-paste it from a github tarball/zip. – rdrey Jul 30 '12 at 17:05
  • I added the git repository as dependency in package.json. So `npm i` works. – Marc Fischer Jul 30 '12 at 19:14