MVC Compare attribute not working on server-side

Question

I have following code

[Required]
[StringLength(100, ErrorMessage = "The {0} must be at least {2} characters long.", MinimumLength = 8)]
[Display(Name = "Password")]
[DataType(DataType.Password)]
public string Password { get; set; }

[Required]
[DataType(DataType.Password)]
[Display(Name = "Confirm password")]
[StringLength(100, ErrorMessage = "The {0} must be at least {2} characters long.", MinimumLength = 8)]
[Compare("Password", ErrorMessage = "The password and confirmation password do not match.")]
public string ConfirmPassword { get; set; }

When I show the form, the client-side validation works but when I test it on server side, it's always valid (tried with Password=pass1234 and ConfirmPassword=nonmatchingpassword)

I also tried with some other attributes like EqualTo in http://foolproof.codeplex.com/ but same problem.

I have included method

[HttpPost]
[ValidateAntiForgeryToken]
public ActionResult Register(RegisterViewModel model) 
{
    if (WebSecurity.IsAuthenticated)
    {
        return RedirectToAction("Index", "Home");
    }

    if (ModelState.IsValid) 
    {
        // register user...
    }

    model.Countries = this.Countries.FindAll().OrderBy(c => c.Name);
    return View(model);
}

and this is how I render it

@using (Html.BeginForm(null, null, FormMethod.Post, new { @class = "form", @id = "register-form" }))
{
@Html.AntiForgeryToken()
<ul class="form-fields">
    ...
    <li class="form-field">
        @Html.LabelFor(m => m.Password)
        @Html.ValidationMessageFor(m => m.Password)
        @Html.EditorFor(m => m.Password)
    </li>
    <li class="form-field">
        @Html.LabelFor(m => m.ConfirmPassword)
        @Html.ValidationMessageFor(m => m.ConfirmPassword)
        @Html.EditorFor(m => m.ConfirmPassword)
    </li>
    ...     
    <li class="form-actions"> 
        <button class="submit">register</button>
    </li>
</ul>
}

Any ideas what could be wrong? Im using MVC4 RC.

Try fluent validation http://fluentvalidation.codeplex.com/. Theres also a nuget package for MVC http://nuget.org/packages/FluentValidation.MVC3. — cubski, Aug 01 '12 at 20:19
What do you mean exactly by "test on the server side"? Is the model you've posted a domain object or a view model? — Forty-Two, Aug 01 '12 at 20:36
It's view model and every other validation work except Compare. — FrEaKmAn, Aug 01 '12 at 20:42

score 1 · Accepted Answer · answered Aug 02 '12 at 12:15

This is how Microsoft does it in their default MVC project templates:

    [PropertiesMustMatch( "Password", "ConfirmPassword", ErrorMessage = "The                    password and confirmation password do not match." )]
    public class RegisterModel
    {
        [Required]
        [DisplayName( "User name" )]
        public string UserName { get; set; }

        [Required]
        [DataType( DataType.EmailAddress )]
        [DisplayName( "Email address" )]
        public string Email { get; set; }

        [Required]
        [ValidatePasswordLength]
        [DataType( DataType.Password )]
        [DisplayName( "Password" )]
        public string Password { get; set; }

        [Required]
        [DataType( DataType.Password )]
        [DisplayName( "Confirm password" )]
        public string ConfirmPassword { get; set; }
}

I'm not sure exactly how you're doing your server side testing. If this doesn't work for you, perhaps you could post the test that fails?

score 0 · Answer 2 · answered Aug 01 '12 at 20:20

0

Take the StringLength out on the second item. You don't need it because the first item already has it.

answered Aug 01 '12 at 20:20

Erik Funkenbusch

92,674
28
195
291

1

@FrEaKmAn - you also don't need the required. – Erik Funkenbusch Aug 01 '12 at 20:27

score 0 · Answer 3 · edited May 23 '17 at 10:31

0

A bit late to the party, but I only just ran into a similar issue. This is being caused by an error in the jquery unobstrusive javascript file. A later version will fix it, I just ran

Install-Package jQuery.Validation.Unobtrusive

which installed v2, which works fine for me. Your mileage may vary.

This question has been properly answered here.

edited May 23 '17 at 10:31

Community

1
1

answered Oct 09 '13 at 07:11

keithl8041

2,383
20
27

MVC Compare attribute not working on server-side

3 Answers3