Object reference not set to an instance, public array with..Split(",")

Question

i wonder what is wrong with the following vb.net code.

Public Class Form10

Public IDs() As String = TextBox1.Text.Split(",")

Private Sub Form10_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Load
End Sub

Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click
    For Each id In IDs
        MsgBox(id)
    Next
End Sub

End Class

when i do

Form10.show()

i get an error "Object reference not set to an instance"

possible duplicate of [What is a NullReferenceException in .NET?](http://stackoverflow.com/questions/4660142/what-is-a-nullreferenceexception-in-net) — John Saunders, Aug 09 '12 at 04:02
i think its about that the text box is empty, but i want to fill it when i show the form..how can i get over this? — user1570048, Aug 09 '12 at 04:06
It's really hard to answer you, since the problem is that you don't understand the basics of the form lifecycle. — John Saunders, Aug 09 '12 at 04:10
i solved it by making the array a local variable then passing it to a function, thanks anyway — user1570048, Aug 09 '12 at 04:16

David W · Accepted Answer · 2012-08-09T04:42:01.093

1

You have declared a field in your class to be initialized with a value from a control on the corresponding form that does not yet exist. The control is not initialized and loaded by the time your initializer on your field member is accessed, thus causing the error.

To keep the public IDs declaration, you could remove the initialization from the field declaration, then move the assignment to the Button1_Click event, as follows:

Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click
    IDs=TextBox1.Text.Split(",")
    ' Do something interesting with IDs now...
End Sub

edited Aug 09 '12 at 04:42

answered Aug 09 '12 at 04:19

David W

10,062
34
60

how would you solve this keeping the array as public variable? – user1570048 Aug 09 '12 at 04:34
1

Since the code has no way of knowing when the textbox is populated, it will have to be done as a result of user action, eg a button click. Keep the field declaration, omit the initialization, and move the Split code into the _Click event of Button1, eg: IDs=TextBox.Text.Split(",") – David W Aug 09 '12 at 04:38
Great! Glad to be able to help. – David W Aug 09 '12 at 05:01

score 0 · Answer 2 · answered Aug 09 '12 at 04:18

Public Class Form10
Private Sub Form10_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Load
End Sub

Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click
    Dim IDs() As String = TextBox1.Text.Split(",")
    Form1.somefunction(IDs)
End Sub

and in Form1

  Public Sub somefunction(ByVal IDs() As String)
    For Each id In IDs
        MsgBox(id)
    Next
End Sub

Object reference not set to an instance, public array with..Split(",")

2 Answers2