Javascript/jQuery - "Cannot call method 'push' of undefined" while it IS defined

Question

In a simple script that goes through some form fields, gets the user input and stores it into arrays I ran into a problem.

It works when I do this:

var q1A = parseFloat($('#q1-1').val());
if(isNaN(q1A)) {
    var q1A = 0;
}
parameter.push(' ');
answers.push(q1A);

But now I added another array which, in this case, is supposed to simply store the same q1A variable. But somehow I end up with an "Uncaught TypeError" stating that the variable is undefined! The new code block is:

var q1A = parseFloat($('#q1-1').val());
if(isNaN(q1A)) {
    var q1A = 0;
}
input.push(q1A);
parameter.push(' ');
answers.push(q1A);

I logged the variable in the console and it works just fine, it's set and has a value. Any idea why it says it's undefined? The 'answers' array stores the value just fine.

Thanks in advance!

EDIT:

Of course I defined the variables. I just didn't post that part of the code...

var groups = new Array();
var questions = new Array();
var input = new Array();
var parameter = new Array();
var answers = new Array();
var amounts = new Array();

`input` is not an array, you can't push to any variable, only to an array that has been previously defined. — adeneo, Aug 09 '12 at 11:44
Works perfectly fine for me: http://jsfiddle.net/mP6NT/1. If we cannot replicate the error, it's very difficult for us to help you. Please create your own http://jsfiddle.net/ demo which shows this problem. — Felix Kling, Aug 09 '12 at 11:47
Alright, thanks. I will try to recreate the error there and come back to you guys! — Galadre, Aug 09 '12 at 11:52
Why are you redeclaring the variable q1A inside the if block? — victorvartan, Aug 09 '12 at 13:17

Aaron Digulla · Accepted Answer · 2012-08-09T12:10:12.160

5

Since it's possible to push an undefined variable into an array without error, the problem must be that input isn't defined when you try to call push() on it.

The usual reason for this problem is that there is another place where the variable input is declared and it's never initialized in the unexpected place.

edited Aug 09 '12 at 12:10

answered Aug 09 '12 at 12:00

Aaron Digulla

321,842
108
597
820

It's about the input array, answers works fine. But regardless of which one it is, everything works fine if I remove the input array. But when I add it, the function stops as soon as it gets to the first push into that array. I only declared the arrays once, at the start of the function. I am trying to recreate the problem in jsfiddle. – Galadre Aug 09 '12 at 12:06
Search your code for `var input`; I'm sure you'll find at least one result that you don't expect. – Aaron Digulla Aug 09 '12 at 12:09
Ok, nevermind. You were right after all. Thanks! I did however declare input again after the point where the error occurred. – Galadre Aug 09 '12 at 13:38
`var` has function scope; there is no block level scope in JavaScript. See http://stackoverflow.com/questions/500431/javascript-variable-scope – Aaron Digulla Aug 09 '12 at 14:32

score 4 · Answer 2 · answered Aug 09 '12 at 11:57

4

First you have to define as array.

var   input=[];

then try to push the element.

input.push(element);

answered Aug 09 '12 at 11:57

kongaraju

9,344
11
55
78

1

I already declared the arrays, just didn't post that part of the code. – Galadre Aug 09 '12 at 12:04

Javascript/jQuery - "Cannot call method 'push' of undefined" while it IS defined

2 Answers2

Linked